From: Alan Stern <stern@rowland.harvard.edu>
To: Vinod Koul <vkoul@kernel.org>
Cc: "Mathias Nyman" <mathias.nyman@intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-arm-msm@vger.kernel.org,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Christian Lamparter" <chunkeey@googlemail.com>,
"John Stultz" <john.stultz@linaro.org>,
"Andreas Böhler" <dev@aboehler.at>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"Mathias Nyman" <mathias.nyman@linux.intel.com>
Subject: Re: [PATCH v7 1/5] usb: hci: add hc_driver as argument for usb_hcd_pci_probe
Date: Mon, 23 Mar 2020 11:25:13 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44L0.2003231124190.24254-100000@netrider.rowland.org> (raw)
In-Reply-To: <20200323101121.243906-2-vkoul@kernel.org>
On Mon, 23 Mar 2020, Vinod Koul wrote:
> usb_hcd_pci_probe expects users to call this with driver_data set as
> hc_driver, that limits the possibility of using the driver_data for
> driver data.
>
> Add hc_driver as argument to usb_hcd_pci_probe and modify the callers
> ehci/ohci/xhci/uhci to pass hc_driver as argument and freeup the
> driver_data used
>
> Tested xhci driver on Dragon-board RB3, compile tested ehci and ohci.
> Couldn't compile uhci
>
> Suggested-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> drivers/usb/core/hcd-pci.c | 7 ++++---
> drivers/usb/host/ehci-pci.c | 6 ++----
> drivers/usb/host/ohci-pci.c | 9 ++++++---
> drivers/usb/host/uhci-pci.c | 8 ++++++--
> drivers/usb/host/xhci-pci.c | 14 +++++---------
> include/linux/usb/hcd.h | 3 ++-
> 6 files changed, 25 insertions(+), 22 deletions(-)
For all but the xHCI parts:
Acked-by: Alan Stern <stern@rowland.harvard.edu>
next prev parent reply other threads:[~2020-03-23 15:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 10:11 [PATCH v7 0/5] usb: xhci: Add support for Renesas USB controllers Vinod Koul
2020-03-23 10:11 ` [PATCH v7 1/5] usb: hci: add hc_driver as argument for usb_hcd_pci_probe Vinod Koul
2020-03-23 15:25 ` Alan Stern [this message]
2020-03-23 15:37 ` Vinod Koul
2020-03-23 10:11 ` [PATCH v7 2/5] usb: renesas-xhci: Add the renesas xhci driver Vinod Koul
2020-03-23 10:11 ` [PATCH v7 3/5] usb: xhci: Add support for Renesas controller with memory Vinod Koul
2020-03-23 10:11 ` [PATCH v7 4/5] usb: renesas-xhci: Add ROM loader for uPD720201 Vinod Koul
2020-03-23 10:11 ` [PATCH v7 5/5] usb: xhci: provide a debugfs hook for erasing rom Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.2003231124190.24254-100000@netrider.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=bjorn.andersson@linaro.org \
--cc=chunkeey@googlemail.com \
--cc=dev@aboehler.at \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mathias.nyman@linux.intel.com \
--cc=vkoul@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).