From: "Balakrishna Godavarthi (QUIC)" <quic_bgodavar@quicinc.com>
To: Miao-chen Chou <mcchou@chromium.org>,
"Balakrishna Godavarthi (QUIC)" <quic_bgodavar@quicinc.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Andy Gross <agross@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
"mka@chromium.org" <mka@chromium.org>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
"Hemant Gupta (QUIC)" <quic_hemantg@quicinc.com>,
"Sai Teja Aluvala (Temp) (QUIC)" <quic_saluvala@quicinc.com>,
"Rocky Liao (QUIC)" <quic_rjliao@quicinc.com>,
Alain Michaud <alainmichaud@google.com>,
Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Subject: RE: [PATCH v1 3/3] Bluetooth: hci_qca: WAR to handle WCN6750 HW issue
Date: Wed, 22 Jun 2022 07:27:21 +0000 [thread overview]
Message-ID: <SJ0PR02MB7135746D204F13550E9BAE77F8B29@SJ0PR02MB7135.namprd02.prod.outlook.com> (raw)
In-Reply-To: <CABmPvSFiAC474WthmMX0nE20UEOxUD5dEYBVbiKh7HOovCnCkA@mail.gmail.com>
Hi Marcel/Miao,
We are working on new driver, by 7/29 we will submit initial patch for review.
Regards
Bala
-----Original Message-----
From: Miao-chen Chou <mcchou@chromium.org>
Sent: Tuesday, May 10, 2022 8:47 AM
To: Balakrishna Godavarthi (QUIC) <quic_bgodavar@quicinc.com>
Cc: Marcel Holtmann <marcel@holtmann.org>; Andy Gross <agross@kernel.org>; robh+dt@kernel.org; bjorn.andersson@linaro.org; linux-arm-msm@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Johan Hedberg <johan.hedberg@gmail.com>; mka@chromium.org; linux-bluetooth@vger.kernel.org; Hemant Gupta (QUIC) <quic_hemantg@quicinc.com>; Sai Teja Aluvala (Temp) (QUIC) <quic_saluvala@quicinc.com>; quic_rjliao <quic_rjliao@quicinc.com>; Alain Michaud <alainmichaud@google.com>; Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Subject: Re: [PATCH v1 3/3] Bluetooth: hci_qca: WAR to handle WCN6750 HW issue
Hi Bala,
When is the estimated start date and timeline of the driver development?
Thanks,
Miao
On Fri, Apr 29, 2022 at 8:09 PM Balakrishna Godavarthi (QUIC) <quic_bgodavar@quicinc.com> wrote:
>
> Hi Marcel,
>
> -----Original Message-----
> From: Marcel Holtmann <marcel@holtmann.org>
> Sent: Friday, April 29, 2022 8:24 PM
> To: Balakrishna Godavarthi (QUIC) <quic_bgodavar@quicinc.com>
> Cc: Andy Gross <agross@kernel.org>; robh+dt@kernel.org;
> bjorn.andersson@linaro.org; linux-arm-msm@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Johan
> Hedberg <johan.hedberg@gmail.com>; mka@chromium.org;
> linux-bluetooth@vger.kernel.org; Hemant Gupta (QUIC)
> <quic_hemantg@quicinc.com>; Sai Teja Aluvala (Temp) (QUIC)
> <quic_saluvala@quicinc.com>; quic_rjliao <quic_rjliao@quicinc.com>;
> mcchou@chromium.org
> Subject: Re: [PATCH v1 3/3] Bluetooth: hci_qca: WAR to handle WCN6750
> HW issue
>
> Hi Balakrishna,
>
> > The patch is workaround for hardware issue on WCN6750.
> > On WCN6750 sometimes observed AON power source takes 100ms time to
> > fully discharge voltage during OFF. As WCN6750 is combo chip for
> > WLAN and BT. If any of the tech area ON is triggered during
> > discharge phase, it fails to turn ON.
> > To overcome this hardware issue, During BT ON, driver check for
> > WLAN_EN pin status. If it high, it will pull BT_EN to high
> > immediately else it will wait for 100ms assuming WLAN was just
> > powered OFF and then BT_EN will be pulled to high.
> >
> > Fixes: d8f97da1b92d2 ("Bluetooth: hci_qca: Add support for QTI
> > Bluetooth chip wcn6750")
> > Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
> > Signed-off-by: Sai Teja Aluvala <quic_saluvala@quicinc.com>
> > Signed-off-by: Balakrishna Godavarthi <quic_bgodavar@quicinc.com>
> > ---
> > drivers/bluetooth/hci_qca.c | 30 ++++++++++++++++++++++++------
> > 1 file changed, 24 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/bluetooth/hci_qca.c
> > b/drivers/bluetooth/hci_qca.c index eab34e2..c3862d1 100644
> > --- a/drivers/bluetooth/hci_qca.c
> > +++ b/drivers/bluetooth/hci_qca.c
> > @@ -219,6 +219,7 @@ struct qca_serdev {
> > struct hci_uart serdev_hu;
> > struct gpio_desc *bt_en;
> > struct gpio_desc *sw_ctrl;
> > + struct gpio_desc *wlan_en;
> > struct clk *susclk;
> > enum qca_btsoc_type btsoc_type;
> > struct qca_power *bt_power;
>
> I am really against these intermixing of Bluetooth and WiFi details. There is work ongoing to do some sequence power procedure. Maybe that is something you should look into. This is a mess.
>
> And again, we are still hacking around hci_qca.c instead of writing a clean serdev only driver for this hardware. I have the feeling that nobody listens to review comments these days. It is just hacking patches together to get hardware enabled somehow and then disappear.
>
> [Bala]: We are working on serdev like driver for our QCA platform. We are in initial stages of discussion, and soon we will start the driver development work.
> In mean to stop stability or functional issues we are trying to add these HACKs in QCA driver.
>
> Regards
>
> Marcel
>
next prev parent reply other threads:[~2022-06-22 7:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 10:27 [PATCH v1 0/3] WAR to handle WCN6750 hardware issue Balakrishna Godavarthi
2022-04-29 10:27 ` [PATCH v1 1/3] dt-bindings: net: bluetooth: Add wlan-gpio entry for wcn6750 Balakrishna Godavarthi
2022-04-29 14:50 ` Marcel Holtmann
2022-05-04 20:31 ` Rob Herring
2022-04-29 10:27 ` [PATCH v1 2/3] arm64: dts: qcom: sc7280: Add wlan enable gpio to bluetooth node Balakrishna Godavarthi
2022-04-29 10:27 ` [PATCH v1 3/3] Bluetooth: hci_qca: WAR to handle WCN6750 HW issue Balakrishna Godavarthi
2022-04-29 14:54 ` Marcel Holtmann
2022-04-30 3:09 ` Balakrishna Godavarthi (QUIC)
2022-05-10 3:17 ` Miao-chen Chou
2022-06-22 7:27 ` Balakrishna Godavarthi (QUIC) [this message]
2022-10-13 19:11 ` mka
2022-10-13 20:06 ` Luiz Augusto von Dentz
2022-10-13 20:12 ` mka
2022-04-29 22:59 ` [PATCH] Bluetooth: hci_qca: fix excluded_middle.cocci warnings kernel test robot
2022-04-29 23:05 ` [PATCH v1 3/3] Bluetooth: hci_qca: WAR to handle WCN6750 HW issue kernel test robot
2022-06-22 7:33 ` [PATCH v1 0/3] WAR to handle WCN6750 hardware issue Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR02MB7135746D204F13550E9BAE77F8B29@SJ0PR02MB7135.namprd02.prod.outlook.com \
--to=quic_bgodavar@quicinc.com \
--cc=abhishekpandit@chromium.org \
--cc=agross@kernel.org \
--cc=alainmichaud@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mcchou@chromium.org \
--cc=mka@chromium.org \
--cc=quic_hemantg@quicinc.com \
--cc=quic_rjliao@quicinc.com \
--cc=quic_saluvala@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).