From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97891C43214 for ; Thu, 2 Sep 2021 09:42:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F821610E8 for ; Thu, 2 Sep 2021 09:42:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245693AbhIBJnx (ORCPT ); Thu, 2 Sep 2021 05:43:53 -0400 Received: from mail-4325.protonmail.ch ([185.70.43.25]:61473 "EHLO mail-4325.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245185AbhIBJnw (ORCPT ); Thu, 2 Sep 2021 05:43:52 -0400 Date: Thu, 02 Sep 2021 09:42:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1630575772; bh=xRF9eqv4PKo+kZdEnxZf3slEfaXPEv4ICmGtDtFFhr0=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=wf/2sLr+/ZxXhfe0qyapMX8pS587V7p1N27/s2WJgjM3SOUs+CYlEFEHut78r4LcB JEjb4vIvf6QDTkk4B9UWDfaTgdJm5LqSJOomxhnu12RoDcyHDoBtmIkjZm6x1RzLQo WyIJAWORp36Wf43sqL3Qe6yr/w7XzZnKDuzJK2wQ= To: Dmitry Baryshkov From: Yassine Oudjana Cc: AngeloGioacchino Del Regno , Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , AngeloGioacchino Del Regno , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Shawn Guo , Marijn Suijten , Konrad Dybcio Reply-To: Yassine Oudjana Subject: Re: [PATCH v4 1/5] interconnect: qcom: sdm660: Commonize RPM-QoS Message-ID: In-Reply-To: References: <20210901121518.152481-1-y.oudjana@protonmail.com> <20210901121518.152481-2-y.oudjana@protonmail.com> <9af0f031-101e-53b4-514e-9ead44320f4e@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Sep 2 2021 at 02:01:59 +0400, Dmitry Baryshkov=20 wrote: > On 01/09/2021 21:48, AngeloGioacchino Del Regno wrote: >> Il 01/09/21 14:15, Yassine Oudjana ha scritto: >>> SoCs such as MSM8996 also control bus QoS in a similar fashion to=20 >>> SDM660, >>> with some paths being controlled by RPM and others directly by the=20 >>> AP. >>> Move relevant functions and defines to a new object so that they=20 >>> can >>> be used >>> in multiple drivers. >>>=20 >>> Signed-off-by: Yassine Oudjana >>=20 >> Hey guys! >>=20 >> I'm waiting for the interconnect RPM-QoS commonization to be merged=20 >> as I >> have fresh >> interconnect drivers for MSM8998 and MSM8976, ready to send, that=20 >> are >> also using >> the very same QoS mechanism as SDM660. >=20 > We were also looking onto this. I'd propose to merge sdm660 code into > main icc-rpm.c instead of splitting it into separate file. We have > enabled QoS for apq8096 (msm8916) and msm8939. See > https://lore.kernel.org/linux-arm-msm/20210818015732.1717810-1-dmitry.bar= yshkov@linaro.org/ > for the reference. I'm waiting for Shawn to publish v2 of his fix,=20 > then > I can post v2 of my patchset. I'll wait for your v2 to post v5 of this series then. Please add me to Cc when you send it. >=20 >>=20 >> Yassine, please check Shawn's recent patches for SDM660=20 >> interconnect, >> which are >> fixing some bits for the QoS implementation and adding some required >> clocks to the >> SDM660 interconnect driver. >>=20 >> Adding Shawn to the Ccs as to make him aware of this patch; >> also adding Marijn and Konrad from SoMainline as probably interested >> parties. >>=20 >> Cheers! >> - Angelo >=20 >=20 > -- > With best wishes > Dmitry Thanks, Yassine