linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Heidelberg <david@ixit.cz>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Stephen Boyd <sboyd@codeaurora.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: arm: qcom: add ipq4019 standalone entry
Date: Sat, 09 Oct 2021 21:30:32 +0200	[thread overview]
Message-ID: <W66Q0R.AIXYHM0GGPWB3@ixit.cz> (raw)
In-Reply-To: <YUgLx7zKmD/QTCfn@builder.lan>

Yeah, this one patch is nonsense. Sending new patch series adding 
compatible to the IPQ40xx/AP-DK01.1-C1 instead of accepting generic 
board compatible.
David

On Sun, Sep 19 2021 at 23:19:19 -0500, Bjorn Andersson 
<bjorn.andersson@linaro.org> wrote:
> On Thu 09 Sep 01:04 CDT 2021, David Heidelberg wrote:
> 
>>  It seems that some ipq4019 boards just accepted architecture.
>> 
>>  Signed-off-by: David Heidelberg <david@ixit.cz>
>>  ---
>>   Documentation/devicetree/bindings/arm/qcom.yaml | 3 +++
>>   1 file changed, 3 insertions(+)
>> 
>>  diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml 
>> b/Documentation/devicetree/bindings/arm/qcom.yaml
>>  index 5169ebb97946..9b6dd7dc3825 100644
>>  --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>>  +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>>  @@ -174,6 +174,9 @@ properties:
>>                 - qcom,ipq4019-dk04.1-c1
>>             - const: qcom,ipq4019
> 
> It seems reasonable to expect that the board isn't just a 
> "qcom,ipq4019"
> and in that case I believe this should cover all boards.
> 
> Please let me know if I'm misunderstanding things.
> 
> Regards,
> Bjorn
> 
>> 
>>  +      - items:
>>  +          - const: qcom,ipq4019
>>  +
>>         - items:
>>             - enum:
>>                 - qcom,ipq8064-ap148
>>  --
>>  2.33.0
>> 



      reply	other threads:[~2021-10-09 19:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-09  6:04 [PATCH] dt-bindings: arm: qcom: add ipq4019 standalone entry David Heidelberg
2021-09-20  4:19 ` Bjorn Andersson
2021-10-09 19:30   ` David Heidelberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=W66Q0R.AIXYHM0GGPWB3@ixit.cz \
    --to=david@ixit.cz \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).