From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D2DBC433E0 for ; Tue, 5 Jan 2021 00:55:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1FE942256F for ; Tue, 5 Jan 2021 00:55:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726589AbhAEAys (ORCPT ); Mon, 4 Jan 2021 19:54:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726545AbhAEAys (ORCPT ); Mon, 4 Jan 2021 19:54:48 -0500 Received: from mail-oo1-xc2e.google.com (mail-oo1-xc2e.google.com [IPv6:2607:f8b0:4864:20::c2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDD20C061794 for ; Mon, 4 Jan 2021 16:54:07 -0800 (PST) Received: by mail-oo1-xc2e.google.com with SMTP id j21so6707639oou.11 for ; Mon, 04 Jan 2021 16:54:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jtqEQP8dMn914fve/E2X3TGiywCoAD5JLxrBTJ+dQpA=; b=E8KfBWO1IhdIwqUnpbbl+Ggs+RC266Bfh4VFOhsoXt2O3DQSQnBMhFx3x/0nRYwcKL G1P1AnqXdF8WBF/wCNNh1PaZ/6BSrl5GXLFBbUb+5mvpvCzZzIYZo74ofV8wAh8hOAoF p84NobMaBbsEfTOREXZ6aAeyBGZPhrVY6RARe95UzweKBkVGhlIJC+kD1mnQ+lnhps27 yTT+f8NIYQDsioKHRNiymXzPq0jnefiIs2Fbqt9DkdjbPVRt0kcrfbtoX2jBM2y6u6Ut NrduKsaNKXNysMOjtEiPGOJF2c2CfSV5L3Z50GpRMGpTPbhRqdMd398ho07qY+I48bhC Zamw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jtqEQP8dMn914fve/E2X3TGiywCoAD5JLxrBTJ+dQpA=; b=IjNFiElw+vv565PkvN5AH1TQiFDsDssKkvrMzI+0Va/njXM+oOPIpAJfQNn4/mhXpq a/gm7ywYUfEOOFFHYD42w91C2NkNvmMEh8/tKduxe6/B8p1MIxejY1EZ9hcavEtvUgTJ NnAM1TxoLZopMGCGWIm8ZkhICK7vWZVeyFFUpUeWzLqU51/w58fA3wMUOEKSoGZ/IbhT PEkEWOeOeipNDKOhlX1qveVjOVJ3zSVug3ZMQabd8tyEq6P9MypiPvDnYmweQ92uYi4j 9rVsxx3/78Iqh081waT8UWJEy6653kTHL62ydhWznWLqilUEsnkohAJrqNULrHxCQfmE SrWQ== X-Gm-Message-State: AOAM532+rZwqH70QUhxBIzRhm9zfoC4uKBMDNY6VU0eME0XKymCrIR6S CwhNyhmkjYbTHUDzJz70MpARpA== X-Google-Smtp-Source: ABdhPJxpr8Tjmjv+Dd1D+ni2oQ9dH6AS/6Q2QSyDsCPhM5GBoOmvu30Ud9bTE/JY0nBg6v4nzfacTw== X-Received: by 2002:a4a:5590:: with SMTP id e138mr50970690oob.13.1609808047293; Mon, 04 Jan 2021 16:54:07 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id t72sm13502220oie.47.2021.01.04.16.54.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Jan 2021 16:54:06 -0800 (PST) Date: Mon, 4 Jan 2021 18:54:05 -0600 From: Bjorn Andersson To: Arnaud Pouliquen Cc: Ohad Ben-Cohen , Mathieu Poirier , Andy Gross , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 07/16] rpmsg: char: clean up rpmsg class Message-ID: References: <20201222105726.16906-1-arnaud.pouliquen@foss.st.com> <20201222105726.16906-8-arnaud.pouliquen@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon 04 Jan 18:47 CST 2021, Bjorn Andersson wrote: > On Tue 22 Dec 04:57 CST 2020, Arnaud Pouliquen wrote: > > This patch doesn't "clean up" the class, as described in $subject. It > just removes it. > > > Suppress the management of the rpmsg class as attribute. It is already > > handled in /sys/bus rpmsg as specified in > > documentation/ABI/testing/sysfs-bus-rpmsg. > > Afaict it doesn't relate to /sys/bus/rpmsg, but rather what attributes > should be associated with the rpmsg_device (and thereby present in its > sysfs directory). But if these attributes are also added by the bus, > then why do we have this code? If that's the case this seems like a nice > cleanup that we should do outside/before merging the other patches. > > > This patch prepares the migration of the control device in rpmsg_ctrl. > > > > It would be useful if the commit message described how it prepares for > the migration and why. > Now I see what this patch does, it removes the attributes from the character device's struct device, because they are provided by the struct rpmsg_device's bus! I wish your commit message made this obvious. Also, this implies that for a few patches here rpmsg_char is just broken - which I don't like. Regards, Bjorn > Regards, > Bjorn > > > Signed-off-by: Arnaud Pouliquen > > --- > > drivers/rpmsg/rpmsg_char.c | 48 -------------------------------------- > > 1 file changed, 48 deletions(-) > > > > diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c > > index 4bbbacdbf3bb..732f5caf068a 100644 > > --- a/drivers/rpmsg/rpmsg_char.c > > +++ b/drivers/rpmsg/rpmsg_char.c > > @@ -27,7 +27,6 @@ > > #define RPMSG_DEV_MAX (MINORMASK + 1) > > > > static dev_t rpmsg_major; > > -static struct class *rpmsg_class; > > > > static DEFINE_IDA(rpmsg_ctrl_ida); > > static DEFINE_IDA(rpmsg_ept_ida); > > @@ -291,41 +290,6 @@ static const struct file_operations rpmsg_eptdev_fops = { > > .compat_ioctl = compat_ptr_ioctl, > > }; > > > > -static ssize_t name_show(struct device *dev, struct device_attribute *attr, > > - char *buf) > > -{ > > - struct rpmsg_eptdev *eptdev = dev_get_drvdata(dev); > > - > > - return sprintf(buf, "%s\n", eptdev->chinfo.name); > > -} > > -static DEVICE_ATTR_RO(name); > > - > > -static ssize_t src_show(struct device *dev, struct device_attribute *attr, > > - char *buf) > > -{ > > - struct rpmsg_eptdev *eptdev = dev_get_drvdata(dev); > > - > > - return sprintf(buf, "%d\n", eptdev->chinfo.src); > > -} > > -static DEVICE_ATTR_RO(src); > > - > > -static ssize_t dst_show(struct device *dev, struct device_attribute *attr, > > - char *buf) > > -{ > > - struct rpmsg_eptdev *eptdev = dev_get_drvdata(dev); > > - > > - return sprintf(buf, "%d\n", eptdev->chinfo.dst); > > -} > > -static DEVICE_ATTR_RO(dst); > > - > > -static struct attribute *rpmsg_eptdev_attrs[] = { > > - &dev_attr_name.attr, > > - &dev_attr_src.attr, > > - &dev_attr_dst.attr, > > - NULL > > -}; > > -ATTRIBUTE_GROUPS(rpmsg_eptdev); > > - > > static void rpmsg_eptdev_release_device(struct device *dev) > > { > > struct rpmsg_eptdev *eptdev = dev_to_eptdev(dev); > > @@ -358,9 +322,7 @@ static int rpmsg_eptdev_create(struct rpmsg_ctrldev *ctrldev, > > init_waitqueue_head(&eptdev->readq); > > > > device_initialize(dev); > > - dev->class = rpmsg_class; > > dev->parent = &ctrldev->dev; > > - dev->groups = rpmsg_eptdev_groups; > > dev_set_drvdata(dev, eptdev); > > > > cdev_init(&eptdev->cdev, &rpmsg_eptdev_fops); > > @@ -477,7 +439,6 @@ static int rpmsg_chrdev_probe(struct rpmsg_device *rpdev) > > dev = &ctrldev->dev; > > device_initialize(dev); > > dev->parent = &rpdev->dev; > > - dev->class = rpmsg_class; > > > > cdev_init(&ctrldev->cdev, &rpmsg_ctrldev_fops); > > ctrldev->cdev.owner = THIS_MODULE; > > @@ -553,17 +514,9 @@ static int rpmsg_char_init(void) > > return ret; > > } > > > > - rpmsg_class = class_create(THIS_MODULE, "rpmsg"); > > - if (IS_ERR(rpmsg_class)) { > > - pr_err("failed to create rpmsg class\n"); > > - unregister_chrdev_region(rpmsg_major, RPMSG_DEV_MAX); > > - return PTR_ERR(rpmsg_class); > > - } > > - > > ret = register_rpmsg_driver(&rpmsg_chrdev_driver); > > if (ret < 0) { > > pr_err("rpmsgchr: failed to register rpmsg driver\n"); > > - class_destroy(rpmsg_class); > > unregister_chrdev_region(rpmsg_major, RPMSG_DEV_MAX); > > } > > > > @@ -574,7 +527,6 @@ postcore_initcall(rpmsg_char_init); > > static void rpmsg_chrdev_exit(void) > > { > > unregister_rpmsg_driver(&rpmsg_chrdev_driver); > > - class_destroy(rpmsg_class); > > unregister_chrdev_region(rpmsg_major, RPMSG_DEV_MAX); > > } > > module_exit(rpmsg_chrdev_exit); > > -- > > 2.17.1 > >