From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Andy Gross <agross@kernel.org>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 00/16] introduce generic IOCTL interface for RPMsg channels management
Date: Mon, 4 Jan 2021 17:03:19 -0600 [thread overview]
Message-ID: <X/Oet4lT9Hf14adx@builder.lan> (raw)
In-Reply-To: <20201222105726.16906-1-arnaud.pouliquen@foss.st.com>
On Tue 22 Dec 04:57 CST 2020, Arnaud Pouliquen wrote:
> This series is a restructuring of the RPMsg char driver, to create a generic
> RPMsg ioctl interface for all rpmsg services.
>
> The RPMsg char driver provides interfaces that:
> - expose a char RPMsg device for communication with the remote processor,
> - expose controls interface for applications to create and release endpoints.
>
> The objective of this series is to decorrelate the two interfaces:
> - Provide a char device for a RPMsg raw service in the rpmsg_char that can be
> probed by a RPMsg bus on a ns announcement.
> - Generalize the use of the ioctl for all RPMsg services by creating the
> rpmsg_ctrl, but keep it compatibile with the legacy.
>
> If the V1 create a new rpmsg_raw driver in addition to the rpmsg_ctrl this
> version try to reuse the rpmsg_char driver by addapting QCOM GLINK and SMD
> drivers.
> So a goal of this version is to help to determine the best strategy to move
> forward:
> - reuse rpmsg_char.
> - introduce a new driver and keep rpmsg_char as a legacy driver for a while.
>
> Notice that SMD and GLINK patches have to be tested, only build has been tested.
>
> 1) RPMsg control driver: rpmsg_ctrl.c
> This driver is based on the control part of the RPMsg_char driver.
> On probe a /dev/rpmsg_ctrl<X> interface is created to allow to manage the
> channels.
> The principles are the following:
> - The RPMsg service driver registers it's name and the associated service
> using the rpmsg_ctrl_unregister_ctl API. The list of supported services
> is defined in include/uapi/linux/rpmsg.h and exposed to the
> application thanks to a new field in rpmsg_endpoint_info struct.
> - On the RPMsg bus probe(e.g virtio bus) an rpmsg_ctrl device is
> registered that creates the control interface.
> - The application can then create or release a channel by specifying:
> - the name service
> - the source address.
> - the destination address.
Why is this useful?
> - The rpmsg_ctrl uses the same interface than the ns announcement to
> create and release the associated channel but using the driver_override
> field to force the service name.
> The "driver_override" allows to force the name service associated to
> an RPMsg driver, bypassing the rpmsg_device_id based match check.
You mean, the chinfo driver_override allows the ioctl to specify which
driver should be bound to the device created for the newly registered
endpoint?
> - At least for virtio bus, an associated ns announcement is sent to the
> remote side.
>
> 2) rpmsg char driver: rpmsg_char.c
> - The rpmsg class has not been removed. The associated attributes
> are already available in /sys/bus/rpmsg/.
So today a rpmsg_device gets the same attributes both from the class and
the bus? So the only difference is that there will no longer be a
/sys/class/rpmsg ?
Regards,
Bjorn
> - The eptdev device is now an RPMsg device probed by a RPMsg bus driver
> (probed only by the ioctl in rpmsg_char driver).
>
> Know current Limitations:
> - Tested only with virtio RPMsg bus and for one vdev instance.
> - The glink and smd drivers adaptations have not been tested (not able to test).
> - To limit commit and not update the IOCT interface some features have been not
> implemented in this first step:
> - the NS announcement as not been updated, it is not possible to create an
> endpoint with a destibnation address set to RPMSG_ADDR_ANY (-1),
> - not possible to destroy the channel,
> - only the "rpmsg-raw" service is supported.
>
> This series can be applied in Bjorn's rpmsg-next branch on top of the
> RPMsg_ns series(4c0943255805).
>
> This series can be tested using rpmsgexport tools available here:
> https://github.com/andersson/rpmsgexport.
> ---
> new from V1[1]:
> - In V1 the rpmsg_char.c was not impacted, a rpmsg_raw.c has been created
> instead.
> - IOCTL interface as not been updated (to go by steps).
> - smd and glink drivers has been updated to support channels creation and
> release.
>
> [1] https://patchwork.kernel.org/project/linux-remoteproc/list/?series=327277
>
> Arnaud Pouliquen (16):
> rpmsg: introduce RPMsg control driver for channel creation
> rpmsg: add RPMsg control API to register service
> rpmsg: add override field in channel info
> rpmsg: ctrl: implement the ioctl function to create device
> rpmsg: ns: initialize channel info override field
> rpmsg: add helper to register the rpmsg ctrl device
> rpmsg: char: clean up rpmsg class
> rpmsg: char: make char rpmsg a rpmsg device without the control part
> rpmsg: char: register RPMsg raw service to the ioctl interface.
> rpmsg: char: allow only one endpoint per device
> rpmsg: char: check destination address is not null
> rpmsg: virtio: use the driver_override in channel creation ops
> rpmsg: virtio: probe the rpmsg_ctl device
> rpmsg: glink: add create and release rpmsg channel ops
> rpmsg: smd: add create and release rpmsg channel ops
> rpmsg: replace rpmsg_chrdev_register_device use
>
> drivers/rpmsg/Kconfig | 8 +
> drivers/rpmsg/Makefile | 1 +
> drivers/rpmsg/qcom_glink_native.c | 96 +++++++--
> drivers/rpmsg/qcom_smd.c | 59 +++++-
> drivers/rpmsg/rpmsg_char.c | 246 ++++++-----------------
> drivers/rpmsg/rpmsg_ctrl.c | 320 ++++++++++++++++++++++++++++++
> drivers/rpmsg/rpmsg_internal.h | 14 --
> drivers/rpmsg/rpmsg_ns.c | 1 +
> drivers/rpmsg/virtio_rpmsg_bus.c | 38 +++-
> include/linux/rpmsg.h | 40 ++++
> include/uapi/linux/rpmsg.h | 14 ++
> 11 files changed, 606 insertions(+), 231 deletions(-)
> create mode 100644 drivers/rpmsg/rpmsg_ctrl.c
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-01-04 23:12 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 10:57 [PATCH v2 00/16] introduce generic IOCTL interface for RPMsg channels management Arnaud Pouliquen
2020-12-22 10:57 ` [PATCH v2 01/16] rpmsg: introduce RPMsg control driver for channel creation Arnaud Pouliquen
2020-12-22 16:45 ` Randy Dunlap
2021-01-05 0:21 ` Bjorn Andersson
2021-01-21 23:31 ` Mathieu Poirier
2020-12-22 10:57 ` [PATCH v2 02/16] rpmsg: add RPMsg control API to register service Arnaud Pouliquen
2021-01-05 0:34 ` Bjorn Andersson
2021-01-05 16:53 ` Arnaud POULIQUEN
2021-01-21 23:46 ` Mathieu Poirier
2020-12-22 10:57 ` [PATCH v2 03/16] rpmsg: add override field in channel info Arnaud Pouliquen
2020-12-22 10:57 ` [PATCH v2 04/16] rpmsg: ctrl: implement the ioctl function to create device Arnaud Pouliquen
2021-01-05 1:33 ` Bjorn Andersson
2021-01-05 18:07 ` Arnaud POULIQUEN
2021-01-21 23:52 ` Mathieu Poirier
2021-01-22 13:05 ` Arnaud POULIQUEN
2021-01-22 20:59 ` Mathieu Poirier
2021-01-25 10:52 ` Arnaud POULIQUEN
2021-01-29 0:13 ` Mathieu Poirier
2021-01-29 9:45 ` Arnaud POULIQUEN
2020-12-22 10:57 ` [PATCH v2 05/16] rpmsg: ns: initialize channel info override field Arnaud Pouliquen
2021-01-05 0:38 ` Bjorn Andersson
2021-01-05 17:02 ` Arnaud POULIQUEN
2020-12-22 10:57 ` [PATCH v2 06/16] rpmsg: add helper to register the rpmsg ctrl device Arnaud Pouliquen
2020-12-22 10:57 ` [PATCH v2 07/16] rpmsg: char: clean up rpmsg class Arnaud Pouliquen
2021-01-05 0:47 ` Bjorn Andersson
2021-01-05 0:54 ` Bjorn Andersson
2021-01-05 17:03 ` Arnaud POULIQUEN
2020-12-22 10:57 ` [PATCH v2 08/16] rpmsg: char: make char rpmsg a rpmsg device without the control part Arnaud Pouliquen
2020-12-22 10:57 ` [PATCH v2 09/16] rpmsg: char: register RPMsg raw service to the ioctl interface Arnaud Pouliquen
2020-12-22 10:57 ` [PATCH v2 10/16] rpmsg: char: allow only one endpoint per device Arnaud Pouliquen
2021-01-05 0:59 ` Bjorn Andersson
2021-01-05 17:05 ` Arnaud POULIQUEN
2020-12-22 10:57 ` [PATCH v2 11/16] rpmsg: char: check destination address is not null Arnaud Pouliquen
2021-01-05 1:03 ` Bjorn Andersson
2021-01-05 17:08 ` Arnaud POULIQUEN
2020-12-22 10:57 ` [PATCH v2 12/16] rpmsg: virtio: use the driver_override in channel creation ops Arnaud Pouliquen
2020-12-22 10:57 ` [PATCH v2 13/16] rpmsg: virtio: probe the rpmsg_ctl device Arnaud Pouliquen
2020-12-29 4:16 ` kernel test robot
2021-01-04 12:59 ` Dan Carpenter
2020-12-22 10:57 ` [PATCH v2 14/16] rpmsg: glink: add create and release rpmsg channel ops Arnaud Pouliquen
2021-01-05 1:08 ` Bjorn Andersson
2021-01-05 17:29 ` Arnaud POULIQUEN
2020-12-22 10:57 ` [PATCH v2 15/16] rpmsg: smd: " Arnaud Pouliquen
2020-12-22 10:57 ` [PATCH v2 16/16] rpmsg: replace rpmsg_chrdev_register_device use Arnaud Pouliquen
2021-01-05 1:10 ` Bjorn Andersson
2021-01-04 23:03 ` Bjorn Andersson [this message]
2021-01-05 16:59 ` [PATCH v2 00/16] introduce generic IOCTL interface for RPMsg channels management Arnaud POULIQUEN
2021-01-13 20:31 ` Mathieu Poirier
2021-01-14 9:05 ` Arnaud POULIQUEN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/Oet4lT9Hf14adx@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=arnaud.pouliquen@foss.st.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).