From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Roja Rani Yarubandi <rojay@codeaurora.org>
Cc: ulf.hansson@linaro.org, robh+dt@kernel.org, wsa@kernel.org,
swboyd@chromium.org, dianders@chromium.org,
saiprakash.ranjan@codeaurora.org, mka@chromium.org,
akashast@codeaurora.org, msavaliy@qti.qualcomm.com,
parashar@codeaurora.org, rnayak@codeaurora.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
agross@kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: power: Introduce 'assigned-performance-states' property
Date: Fri, 15 Jan 2021 10:15:32 -0600 [thread overview]
Message-ID: <YAG/pNXQOS+C2zLr@builder.lan> (raw)
In-Reply-To: <20201224111210.1214-2-rojay@codeaurora.org>
On Thu 24 Dec 05:12 CST 2020, Roja Rani Yarubandi wrote:
> While most devices within power-domains which support performance states,
> scale the performance state dynamically, some devices might want to
> set a static/default performance state while the device is active.
> These devices typically would also run off a fixed clock and not support
> dynamically scaling the device's performance, also known as DVFS
> techniques.
>
> Add a property 'assigned-performance-states' which client devices can
> use to set this default performance state on their power-domains.
>
> Signed-off-by: Roja Rani Yarubandi <rojay@codeaurora.org>
> ---
> .../bindings/power/power-domain.yaml | 49 +++++++++++++++++++
> 1 file changed, 49 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/power-domain.yaml b/Documentation/devicetree/bindings/power/power-domain.yaml
> index aed51e9dcb11..a42977a82d06 100644
> --- a/Documentation/devicetree/bindings/power/power-domain.yaml
> +++ b/Documentation/devicetree/bindings/power/power-domain.yaml
> @@ -66,6 +66,18 @@ properties:
> by the given provider should be subdomains of the domain specified
> by this binding.
>
> + assigned-performance-states:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + description:
> + Some devices might need to configure their power domains in a default
> + performance state while the device is active. These devices typcially
> + would also run off a fixed clock and not support dynamically scaling
> + the device's performance, also known as DVFS techniques. Each cell in
> + performance state value corresponds to one power domain specified as
> + part of the power-domains property. Performance state value can be an
> + opp-level inside an OPP table of the power-domain and need not match
> + with any OPP table performance state.
> +
> required:
> - "#power-domain-cells"
>
> @@ -131,3 +143,40 @@ examples:
> min-residency-us = <7000>;
> };
> };
> +
> + - |
> + parent4: power-controller@12340000 {
> + compatible = "foo,power-controller";
> + reg = <0x12340000 0x1000>;
> + #power-domain-cells = <0>;
> + };
> +
> + parent5: power-controller@43210000 {
> + compatible = "foo,power-controller";
> + reg = <0x43210000 0x1000>;
> + #power-domain-cells = <0>;
> + operating-points-v2 = <&power_opp_table>;
> +
> + power_opp_table: opp-table {
> + compatible = "operating-points-v2";
> +
> + power_opp_low: opp1 {
> + opp-level = <16>;
> + };
> +
> + rpmpd_opp_ret: opp2 {
> + opp-level = <64>;
> + };
> +
> + rpmpd_opp_svs: opp3 {
> + opp-level = <256>;
> + };
> + };
> + };
> +
> + child4: consumer@12341000 {
> + compatible = "foo,consumer";
> + reg = <0x12341000 0x1000>;
> + power-domains = <&parent4>, <&parent5>;
> + assigned-performance-states = <0>, <256>;
May I ask how this is different from saying something like:
required-opps = <&??>, <&rpmpd_opp_svs>:
Regards,
Bjorn
> + };
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
next prev parent reply other threads:[~2021-01-15 16:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-24 11:12 [PATCH 0/3] Add support for assigned-performance-states for geni i2c driver Roja Rani Yarubandi
2020-12-24 11:12 ` [PATCH 1/3] dt-bindings: power: Introduce 'assigned-performance-states' property Roja Rani Yarubandi
2020-12-26 0:16 ` Rob Herring
2020-12-27 16:56 ` Rob Herring
2020-12-31 15:49 ` Rob Herring
2021-01-08 9:39 ` Ulf Hansson
2021-01-15 16:15 ` Bjorn Andersson [this message]
2021-01-18 5:39 ` Rajendra Nayak
2020-12-24 11:12 ` [PATCH 2/3] arm64: dts: sc7180: Add assigned-performance-states for i2c Roja Rani Yarubandi
2020-12-24 11:12 ` [PATCH 3/3] i2c: i2c-qcom-geni: Add support for 'assigned-performance-states' Roja Rani Yarubandi
2021-01-15 14:43 ` Bjorn Andersson
2021-01-18 5:36 ` Rajendra Nayak
2021-01-19 11:02 ` Ulf Hansson
2021-01-19 11:05 ` Viresh Kumar
2021-01-20 13:31 ` Ulf Hansson
2021-02-12 9:21 ` rojay
2021-04-01 6:39 ` rojay
2021-04-29 7:02 ` rojay
2021-04-29 7:50 ` Viresh Kumar
2021-05-04 7:17 ` Rajendra Nayak
2021-05-07 9:06 ` Ulf Hansson
2021-05-10 6:37 ` Rajendra Nayak
2021-05-12 13:50 ` Ulf Hansson
-- strict thread matches above, loose matches on Subject: below --
2020-08-04 11:46 [PATCH 0/3] Add support for assigned-performance-states Rajendra Nayak
2020-08-04 11:46 ` [PATCH 1/3] dt-bindings: power: Introduce 'assigned-performance-states' property Rajendra Nayak
2020-08-05 6:39 ` Stephen Boyd
2020-08-05 8:13 ` Rajendra Nayak
2020-08-05 23:57 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAG/pNXQOS+C2zLr@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=msavaliy@qti.qualcomm.com \
--cc=parashar@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rojay@codeaurora.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).