From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Roja Rani Yarubandi <rojay@codeaurora.org>,
ulf.hansson@linaro.org, viresh.kumar@linaro.org
Cc: robh+dt@kernel.org, wsa@kernel.org, swboyd@chromium.org,
dianders@chromium.org, saiprakash.ranjan@codeaurora.org,
mka@chromium.org, akashast@codeaurora.org,
msavaliy@qti.qualcomm.com, parashar@codeaurora.org,
rnayak@codeaurora.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, agross@kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH 3/3] i2c: i2c-qcom-geni: Add support for 'assigned-performance-states'
Date: Fri, 15 Jan 2021 08:43:53 -0600 [thread overview]
Message-ID: <YAGqKfDfB7EEuZVn@builder.lan> (raw)
In-Reply-To: <20201224111210.1214-4-rojay@codeaurora.org>
On Thu 24 Dec 05:12 CST 2020, Roja Rani Yarubandi wrote:
> @@ -629,6 +658,16 @@ static int __maybe_unused geni_i2c_runtime_suspend(struct device *dev)
> struct geni_i2c_dev *gi2c = dev_get_drvdata(dev);
>
> disable_irq(gi2c->irq);
> +
> + /* Drop the assigned performance state */
> + if (gi2c->assigned_pstate) {
> + ret = dev_pm_genpd_set_performance_state(dev, 0);
> + if (ret) {
> + dev_err(dev, "Failed to set performance state\n");
> + return ret;
> + }
> + }
> +
Ulf, Viresh, I think we discussed this at the time of introducing the
performance states.
The client's state does not affect if its performance_state should
be included in the calculation of the aggregated performance_state, so
each driver that needs to keep some minimum performance state needs to
have these two snippets.
Would it not make sense to on enable/disable re-evaluate the
performance_state and potentially reconfigure the hardware
automatically?
Regards,
Bjorn
> ret = geni_se_resources_off(&gi2c->se);
> if (ret) {
> enable_irq(gi2c->irq);
> @@ -654,6 +693,16 @@ static int __maybe_unused geni_i2c_runtime_resume(struct device *dev)
> if (ret)
> return ret;
>
> + /* Set the assigned performance state */
> + if (gi2c->assigned_pstate) {
> + ret = dev_pm_genpd_set_performance_state(dev,
> + gi2c->assigned_pstate);
> + if (ret) {
> + dev_err(dev, "Failed to set performance state\n");
> + return ret;
> + }
> + }
> +
> enable_irq(gi2c->irq);
> gi2c->suspended = 0;
> return 0;
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
next prev parent reply other threads:[~2021-01-15 14:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-24 11:12 [PATCH 0/3] Add support for assigned-performance-states for geni i2c driver Roja Rani Yarubandi
2020-12-24 11:12 ` [PATCH 1/3] dt-bindings: power: Introduce 'assigned-performance-states' property Roja Rani Yarubandi
2020-12-26 0:16 ` Rob Herring
2020-12-27 16:56 ` Rob Herring
2020-12-31 15:49 ` Rob Herring
2021-01-08 9:39 ` Ulf Hansson
2021-01-15 16:15 ` Bjorn Andersson
2021-01-18 5:39 ` Rajendra Nayak
2020-12-24 11:12 ` [PATCH 2/3] arm64: dts: sc7180: Add assigned-performance-states for i2c Roja Rani Yarubandi
2020-12-24 11:12 ` [PATCH 3/3] i2c: i2c-qcom-geni: Add support for 'assigned-performance-states' Roja Rani Yarubandi
2021-01-15 14:43 ` Bjorn Andersson [this message]
2021-01-18 5:36 ` Rajendra Nayak
2021-01-19 11:02 ` Ulf Hansson
2021-01-19 11:05 ` Viresh Kumar
2021-01-20 13:31 ` Ulf Hansson
2021-02-12 9:21 ` rojay
2021-04-01 6:39 ` rojay
2021-04-29 7:02 ` rojay
2021-04-29 7:50 ` Viresh Kumar
2021-05-04 7:17 ` Rajendra Nayak
2021-05-07 9:06 ` Ulf Hansson
2021-05-10 6:37 ` Rajendra Nayak
2021-05-12 13:50 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAGqKfDfB7EEuZVn@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=msavaliy@qti.qualcomm.com \
--cc=parashar@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rojay@codeaurora.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=ulf.hansson@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).