From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 616EEC433DB for ; Wed, 10 Feb 2021 19:00:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2944764E35 for ; Wed, 10 Feb 2021 19:00:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234410AbhBJS7r (ORCPT ); Wed, 10 Feb 2021 13:59:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234417AbhBJS5p (ORCPT ); Wed, 10 Feb 2021 13:57:45 -0500 Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF1C9C061786 for ; Wed, 10 Feb 2021 10:57:02 -0800 (PST) Received: by mail-oi1-x22e.google.com with SMTP id g84so3235430oib.0 for ; Wed, 10 Feb 2021 10:57:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Bkp2B9buNUd2R4MwP22SzoD89Af1VRonca+aGPvTVAM=; b=XZmKlRwqBRfl3vj90AZg8SZ/p/WgkxRwZRoMznOaDnSPCe8FH5BSR/oSHASBqyV+LK Wgz0PXwIzFQuuTCXKmy6BgWZaE5vYziHTMPA8F8CXj631uNwOy/Kzhn5NqTBpL6D8HWz IxDk9GDhJHEWluAqDgUmml6HLAs1E03jk0D4+jHoatIzJUFkPg2AZpWJW3tdzwid9TvY 8QoLd80AtZvtzp+E2IApXsxQ8UeentIjxU1jopYW7hckah39dkRS98HZVRKKcD9jJkfC n5NH4SV63QWh8RryU8Ky48MErSeZQzYo4q8QwPB0gv94TNB66KF6BSYFyoavQg4yC/tA +fhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Bkp2B9buNUd2R4MwP22SzoD89Af1VRonca+aGPvTVAM=; b=sZ9Hn1U4g49eyPk4Jzmn8QYEdQyuWPUtOqIedUoe+rlAfEJLMPx5guQ6EL7oHGyNw9 6Byi+s0GqD8Kik/BeRWxBtV9VtwW4eWQnwGPnphiSP1Y5Z8srYNw6HEEvSX0k/naG0vK wGdT/ibSlXgdkqTRQ1cwGdeTojrmB/XveZZXBVC7W+tBZE05U/MwCoJ0DxZrGg1TENLD sc0w7aarkQm7yd1SlTGcD2KyECedN1mHp9HROnfvb26uwptbntxsNDul+sSUXz+fVWjX sZpAweYtCf59D41rKZfZoQ5T3k4Z834GhmZ5zUjdf/44ylkBvXAOWsSW1Xes0yKvx7ob P9zA== X-Gm-Message-State: AOAM531GaNxs6hN/lQlx+tKm4kXhrHMjiLtU4ldpvszwETDoj+qHowkv Tz8JyondY3L6BWzYvXrt4BAFpg== X-Google-Smtp-Source: ABdhPJxTQUanvr6NVDmymhAJQN9m3BNjh4gp1tV5Wen8hgMuiwhv5d/plkiv7mZHa1MQg1J41M9aLA== X-Received: by 2002:aca:4717:: with SMTP id u23mr310399oia.2.1612983422201; Wed, 10 Feb 2021 10:57:02 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id y5sm536082oti.59.2021.02.10.10.57.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 10:57:01 -0800 (PST) Date: Wed, 10 Feb 2021 12:56:59 -0600 From: Bjorn Andersson To: Serge Semin Cc: Rob Herring , Serge Semin , Felipe Balbi , Krzysztof Kozlowski , Florian Fainelli , Greg Kroah-Hartman , Andy Gross , Linux USB List , linux-arm-msm , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v6 09/10] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names Message-ID: References: <20210210172850.20849-1-Sergey.Semin@baikalelectronics.ru> <20210210172850.20849-10-Sergey.Semin@baikalelectronics.ru> <20210210184051.ncvvs5xgyo7o3uzq@mobilestation> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210210184051.ncvvs5xgyo7o3uzq@mobilestation> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed 10 Feb 12:40 CST 2021, Serge Semin wrote: > On Wed, Feb 10, 2021 at 12:17:27PM -0600, Rob Herring wrote: > > On Wed, Feb 10, 2021 at 11:29 AM Serge Semin > > wrote: > > > > > > In accordance with the USB HCD/DRD schema all the USB controllers are > > > supposed to have DT-nodes named with prefix "^usb(@.*)?". Since the > > > existing DT-nodes will be renamed in a subsequent patch let's first make > > > sure the DWC3 Qualcomm driver supports them and second falls back to the > > > deprecated naming so not to fail on the legacy DTS-files passed to the > > > newer kernels. > > > > > > Signed-off-by: Serge Semin > > > Reviewed-by: Bjorn Andersson > > > --- > > > drivers/usb/dwc3/dwc3-qcom.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c > > > index c703d552bbcf..49ad8d507d37 100644 > > > --- a/drivers/usb/dwc3/dwc3-qcom.c > > > +++ b/drivers/usb/dwc3/dwc3-qcom.c > > > @@ -630,7 +630,8 @@ static int dwc3_qcom_of_register_core(struct platform_device *pdev) > > > struct device *dev = &pdev->dev; > > > int ret; > > > > > > - dwc3_np = of_get_child_by_name(np, "dwc3"); > > > + dwc3_np = of_get_child_by_name(np, "usb") ?: > > > + of_get_child_by_name(np, "dwc3"); > > > > > Is there some reason using compatible instead wouldn't work here? > > I don't know for sure. The fix has been requested in the framework of > this discussion: > https://lore.kernel.org/linux-usb/20201020115959.2658-30-Sergey.Semin@baikalelectronics.ru/#t > by the driver maintainer Bjorn. To get a firm answer it's better to > have him asked. My feedback was simply that it has to catch both cases, I didn't consider the fact that we have a compatible to match against. > As I see it having of_get_compatible_child() utilized > here would also work. At least for the available in kernel dt-files. > See the affected dts-es in: > https://lore.kernel.org/linux-usb/20210210172850.20849-11-Sergey.Semin@baikalelectronics.ru/ > > A problem may happen if some older versions of DTS-es had another > compatible string in the dwc3 sub-node... > Afaict all Qualcomm dts files has "snps,dwc3", so you can match against that instead. Regards, Bjorn