From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
Rob Herring <robh+dt@kernel.org>,
linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8350 remoteprocs
Date: Thu, 11 Feb 2021 12:52:01 -0600 [thread overview]
Message-ID: <YCV80dfkxXEPBveo@builder.lan> (raw)
In-Reply-To: <20210210104539.340349-1-vkoul@kernel.org>
On Wed 10 Feb 04:45 CST 2021, Vinod Koul wrote:
> Add the SM8350 audio, compute, modem and sensor remoteprocs to the PAS
> DT binding.
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> .../devicetree/bindings/remoteproc/qcom,adsp.txt | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> index 54737024da20..41eaa2466aab 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> @@ -25,6 +25,10 @@ on the Qualcomm ADSP Hexagon core.
> "qcom,sm8250-adsp-pas"
> "qcom,sm8250-cdsp-pas"
> "qcom,sm8250-slpi-pas"
> + "qcom,sm8350-adsp-pas"
> + "qcom,sm8350-cdsp-pas"
> + "qcom,sm8350-slpi-pas"
> + "qcom,sm8350-mpss-pas"
>
> - interrupts-extended:
> Usage: required
> @@ -51,10 +55,14 @@ on the Qualcomm ADSP Hexagon core.
> qcom,sm8250-adsp-pas:
> qcom,sm8250-cdsp-pas:
> qcom,sm8250-slpi-pas:
> + qcom,sm8350-adsp-pas:
> + qcom,sm8350-cdsp-pas:
> + qcom,sm8350-slpi-pas:
> must be "wdog", "fatal", "ready", "handover", "stop-ack"
> qcom,qcs404-wcss-pas:
> qcom,sc7180-mpss-pas:
> qcom,sm8150-mpss-pas:
> + qcom,sm8350-mpss-pas:
> must be "wdog", "fatal", "ready", "handover", "stop-ack",
> "shutdown-ack"
>
> @@ -113,14 +121,18 @@ on the Qualcomm ADSP Hexagon core.
> qcom,sdm845-cdsp-pas:
> qcom,sm8150-adsp-pas:
> qcom,sm8150-cdsp-pas:
> + qcom,sm8250-cdsp-pas:
This should be sm8350, I fixed this up and applied the patch.
Thanks,
Bjorn
> qcom,sm8250-cdsp-pas:
> must be "cx", "load_state"
> qcom,sc7180-mpss-pas:
> qcom,sm8150-mpss-pas:
> + qcom,sm8350-mpss-pas:
> must be "cx", "load_state", "mss"
> qcom,sm8250-adsp-pas:
> + qcom,sm8350-adsp-pas:
> qcom,sm8150-slpi-pas:
> qcom,sm8250-slpi-pas:
> + qcom,sm8350-slpi-pas:
> must be "lcx", "lmx", "load_state"
>
> - memory-region:
> --
> 2.26.2
>
next prev parent reply other threads:[~2021-02-11 18:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 10:45 [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8350 remoteprocs Vinod Koul
2021-02-10 10:45 ` [PATCH 2/2] remoteproc: qcom: pas: Add SM8350 PAS remoteprocs Vinod Koul
2021-02-11 18:52 ` Bjorn Andersson [this message]
2021-02-12 4:37 ` [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8350 remoteprocs Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCV80dfkxXEPBveo@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).