From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 0/2] Add ACPI support for SC8180X pinctrl driver
Date: Thu, 4 Mar 2021 14:44:53 +0200 [thread overview]
Message-ID: <YEDWRXwAp7wouzFN@smile.fi.intel.com> (raw)
In-Reply-To: <20210304060520.24975-1-shawn.guo@linaro.org>
On Thu, Mar 04, 2021 at 02:05:18PM +0800, Shawn Guo wrote:
> This is a couple of patches that enable ACPI probe for SC8180X pinctrl
> driver. It takes pinctrl-sdm845 driver as the example to remove the
> use of tiles, so that we can align memory resource description between
> DT and ACPI, and simpfy the driver code.
Some minor comments, in any case, FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Thanks!
> Changes for v3:
> - Remove the use of tiles.
> - Drop unneed include of <linux/acpi.h>.
>
> Changes for v2:
> - Pass soc_data pointer via .driver_data.
> - Drop use of CONFIG_ACPI and ACPI_PTR().
> - Add comment for sc8180x_acpi_reserved_gpios[] terminator.
> - Add comments for tiles handling.
>
> Shawn Guo (2):
> pinctrl: qcom: sc8180x: drop the use of tiles
> pinctrl: qcom: sc8180x: add ACPI probe support
>
> drivers/pinctrl/qcom/Kconfig | 2 +-
> drivers/pinctrl/qcom/pinctrl-sc8180x.c | 80 ++++++++++++++++----------
> 2 files changed, 52 insertions(+), 30 deletions(-)
>
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-03-04 12:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 6:05 [PATCH v3 0/2] Add ACPI support for SC8180X pinctrl driver Shawn Guo
2021-03-04 6:05 ` [PATCH v3 1/2] pinctrl: qcom: sc8180x: drop the use of tiles Shawn Guo
2021-03-09 1:08 ` Bjorn Andersson
2021-03-09 2:56 ` Shawn Guo
2021-03-09 3:42 ` Bjorn Andersson
2021-03-10 10:37 ` Shawn Guo
2021-03-04 6:05 ` [PATCH v3 2/2] pinctrl: qcom: sc8180x: add ACPI probe support Shawn Guo
2021-03-04 12:44 ` Andy Shevchenko
2021-03-07 11:54 ` Konrad Dybcio
2021-03-08 23:42 ` Bjorn Andersson
2021-03-04 12:44 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEDWRXwAp7wouzFN@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).