From: Vinod Koul <vkoul@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: cpufreq: cpufreq-qcom-hw: Document SM8350 CPUfreq compatible
Date: Mon, 8 Mar 2021 10:26:38 +0530 [thread overview]
Message-ID: <YEWuhqbNJxmCeSER@vkoul-mobl> (raw)
In-Reply-To: <20210305215712.GA710574@robh.at.kernel.org>
On 05-03-21, 15:57, Rob Herring wrote:
> On Thu, Feb 18, 2021 at 09:18:20PM +0530, Viresh Kumar wrote:
> > On 18-02-21, 18:14, Vinod Koul wrote:
> > > On 17-02-21, 10:19, Viresh Kumar wrote:
> > > > On 16-02-21, 16:42, Vinod Koul wrote:
> > > > > Add the CPUfreq compatible for SM8350 SoC along with note for using the
> > > > > specific compatible for SoCs
> > > > >
> > > > > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > > > > ---
> > > > > Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.txt | 4 +++-
> > > > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.txt b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.txt
> > > > > index 9299028ee712..3eb3cee59d79 100644
> > > > > --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.txt
> > > > > +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.txt
> > > > > @@ -8,7 +8,9 @@ Properties:
> > > > > - compatible
> > > > > Usage: required
> > > > > Value type: <string>
> > > > > - Definition: must be "qcom,cpufreq-hw" or "qcom,cpufreq-epss".
> > > > > + Definition: must be "qcom,cpufreq-hw" or "qcom,cpufreq-epss"
> > > > > + along with SoC specific compatible:
> > > > > + "qcom,sm8350-cpufreq-epss", "qcom,cpufreq-epss"
> > > >
> > > > And why is SoC specific compatible required here ? Is the implementation on
> > > > sm8350 any different than the ones using "qcom,cpufreq-epss" compatible ?
> > > >
> > > > FWIW, the same compatible string must be reused until the time there is
> > > > difference in the hardware. The compatible string must be considered as a marker
> > > > for a particular version of the hardware.
> > >
> > > Rob has indicated that we should use a SoC specific compatible and I
> > > agree with that. We are using both soc and generic one here and driver
> > > will be loaded for generic one.
> >
> > I am not sure of the context, lets see what Rob has to say on this. I
> > believe we only need 1 compatible string here (whatever it is), as
> > this is just one version of the hardware we are talking about. We
> > already have 2 somehow and you are trying to add one more and I don't
> > fell good about it. :(
>
> The h/w block is the same features and bugs in every single
> implementation? If not sure, better be safe.
>
> I don't know that I'd go back and add SoC ones for everything though.
I would prefer we have SoC ones to be future proof..
--
~Vinod
next prev parent reply other threads:[~2021-03-08 4:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 11:12 [PATCH] dt-bindings: cpufreq: cpufreq-qcom-hw: Document SM8350 CPUfreq compatible Vinod Koul
2021-02-17 4:49 ` Viresh Kumar
2021-02-18 12:44 ` Vinod Koul
2021-02-18 15:48 ` Viresh Kumar
2021-03-05 21:57 ` Rob Herring
2021-03-08 4:56 ` Vinod Koul [this message]
2021-02-18 16:11 ` Bjorn Andersson
2021-02-19 17:59 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEWuhqbNJxmCeSER@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).