From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AFCBC433DB for ; Tue, 9 Mar 2021 20:06:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E1CDB64F64 for ; Tue, 9 Mar 2021 20:06:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231719AbhCIUF4 (ORCPT ); Tue, 9 Mar 2021 15:05:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231696AbhCIUFb (ORCPT ); Tue, 9 Mar 2021 15:05:31 -0500 Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2FD5C06174A for ; Tue, 9 Mar 2021 12:05:31 -0800 (PST) Received: by mail-ot1-x333.google.com with SMTP id j22so8234409otp.2 for ; Tue, 09 Mar 2021 12:05:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Lpdt0zLAZe17/ZolXa2wLHIA6dgjRIlJmgcDz9hKEVI=; b=eKWffYyiwh8TVySSuyodQeIj3xuj3BmnlSfi2whF4VR5SpxqzVqW/cSEgTndopWiUm T4Yd5hktkb18NChbtjAFJpEu5QU8rSa2i9mf2bZMB8Dp8SaAs0eIj7dhY65OUyOSTbBp n1LOrT6jTwpesV31Fd5r4D9G2HCnTDry0Dfredu1GnwpF91PsAvnS46H/FFPDxoPzzHF inxRoKa03EX/mti10bKu0DgsZnzrHxEyina5GAYsqwNTBArZZCqM41Sy4c9sPd9ZJXaF r9NtmN/Y1FXU0Ygh1PXtopGLdcWaY9SIsbW0IirGbIUp6ria1SpyZf33N/xwLVfxbXsX sRog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Lpdt0zLAZe17/ZolXa2wLHIA6dgjRIlJmgcDz9hKEVI=; b=SxvFXOEGd45vu+Qf9s+HthAV/AAVSJIKcDi24+FGjA5NAww9mrHnP973SpbHylkGlR HnW1FeAEgNCUfZwDWc7yXpNQKlykn/9ovO/gtuxMnUQP5s3VhKcN99Q5686gmZgMjYTX wNfAC0Wc3vHAAh/XEdutiw6oSqnEKsNH8oeeL1DUwxhh7xB55EAg7ZEQyBe/1yKu+hbx /+cXuXTTujqfzUMTcTe1egSTGqQeOyAgv8GIm2XosFmKUUh23lv2OJcn7QiWCpGy28sz zKAo0pNspnEVF4yrw0LW5acixBw6aLZ9criEwCcSUPA+O1HG9WBbaaDRJuJ53kAkjDTo 4WPw== X-Gm-Message-State: AOAM533EBaun2ygvbwu2T9Ot2NR6j8Ec6qGJthvnZzJ9h1fATMaCdDsH 3VSCzzauEjedIl57+jdgnutShKBEqnVzDg== X-Google-Smtp-Source: ABdhPJyKQfLCM6cWgrKmNtKybZb+cd/Gr+M7QJnsR1ybcJGJ7/xAk5Hp2j1XAMUkgG7t+6poeYtlKg== X-Received: by 2002:a9d:561:: with SMTP id 88mr2420310otw.150.1615320330732; Tue, 09 Mar 2021 12:05:30 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id i3sm3172218oov.2.2021.03.09.12.05.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Mar 2021 12:05:30 -0800 (PST) Date: Tue, 9 Mar 2021 14:05:28 -0600 From: Bjorn Andersson To: Rajendra Nayak Cc: agross@kernel.org, linus.walleij@linaro.org, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] pinctrl: qcom: sc7280: Fix SDC_QDSD_PINGROUP and UFS_RESET offsets Message-ID: References: <1614662511-26519-1-git-send-email-rnayak@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1614662511-26519-1-git-send-email-rnayak@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon 01 Mar 23:21 CST 2021, Rajendra Nayak wrote: > The offsets for SDC_QDSD_PINGROUP and UFS_RESET were off by 0x100000 > due to an issue in the scripts generating the data. > > Fixes: ecb454594c43: ("pinctrl: qcom: Add sc7280 pinctrl driver") > > Reported-by: Veerabhadrarao Badiganti > Signed-off-by: Rajendra Nayak Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/pinctrl/qcom/pinctrl-sc7280.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280.c b/drivers/pinctrl/qcom/pinctrl-sc7280.c > index 8daccd5..49c4347 100644 > --- a/drivers/pinctrl/qcom/pinctrl-sc7280.c > +++ b/drivers/pinctrl/qcom/pinctrl-sc7280.c > @@ -1439,14 +1439,14 @@ static const struct msm_pingroup sc7280_groups[] = { > [172] = PINGROUP(172, qdss, _, _, _, _, _, _, _, _), > [173] = PINGROUP(173, qdss, _, _, _, _, _, _, _, _), > [174] = PINGROUP(174, qdss, _, _, _, _, _, _, _, _), > - [175] = UFS_RESET(ufs_reset, 0x1be000), > - [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0x1b3000, 15, 0), > - [177] = SDC_QDSD_PINGROUP(sdc1_clk, 0x1b3000, 13, 6), > - [178] = SDC_QDSD_PINGROUP(sdc1_cmd, 0x1b3000, 11, 3), > - [179] = SDC_QDSD_PINGROUP(sdc1_data, 0x1b3000, 9, 0), > - [180] = SDC_QDSD_PINGROUP(sdc2_clk, 0x1b4000, 14, 6), > - [181] = SDC_QDSD_PINGROUP(sdc2_cmd, 0x1b4000, 11, 3), > - [182] = SDC_QDSD_PINGROUP(sdc2_data, 0x1b4000, 9, 0), > + [175] = UFS_RESET(ufs_reset, 0xbe000), > + [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0xb3000, 15, 0), > + [177] = SDC_QDSD_PINGROUP(sdc1_clk, 0xb3000, 13, 6), > + [178] = SDC_QDSD_PINGROUP(sdc1_cmd, 0xb3000, 11, 3), > + [179] = SDC_QDSD_PINGROUP(sdc1_data, 0xb3000, 9, 0), > + [180] = SDC_QDSD_PINGROUP(sdc2_clk, 0xb4000, 14, 6), > + [181] = SDC_QDSD_PINGROUP(sdc2_cmd, 0xb4000, 11, 3), > + [182] = SDC_QDSD_PINGROUP(sdc2_data, 0xb4000, 9, 0), > }; > > static const struct msm_pinctrl_soc_data sc7280_pinctrl = { > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation >