From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15EA9C433ED for ; Fri, 23 Apr 2021 14:39:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E033E61445 for ; Fri, 23 Apr 2021 14:38:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231274AbhDWOjf (ORCPT ); Fri, 23 Apr 2021 10:39:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231460AbhDWOjf (ORCPT ); Fri, 23 Apr 2021 10:39:35 -0400 Received: from mail-oo1-xc2d.google.com (mail-oo1-xc2d.google.com [IPv6:2607:f8b0:4864:20::c2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74C74C061574 for ; Fri, 23 Apr 2021 07:38:58 -0700 (PDT) Received: by mail-oo1-xc2d.google.com with SMTP id m25-20020a4abc990000b02901ed4500e31dso3737496oop.1 for ; Fri, 23 Apr 2021 07:38:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=j7H66Q86PkqXddsGRSzDhW4KjXrdQxkyswMmMQ3oN5g=; b=mlD/Ib2JrhwFrgExe+x3hpDMlp3RSrHYB2tNVu80feRxTbqvMd2QpOlutN+Rvkuj+T jBH8i54eqXVT66gSXFoYtUnLqdwYCLUUJQFjkS4kt8REhBbXQWZcBYxwpoyMfx1yNMNo M913qVUpb3psQIYYSm6wx7eqSNIv080KznTJ0cIbr4jzW3P+2pTq49VJAqtFwpFB6idM Qv4uBcCraytQe0aAXGWs4XVIS5ufcxmo8HxWNQU2rX/v1bQ3TvRsrDyL+PAeheN7A7ib EV6NHRAjFz+0xzRqDpi9cLCKAbRRcj4ZrC69Zw/jTNcUD3ij2d5xAHXhHo7YrKZxZYBm du+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=j7H66Q86PkqXddsGRSzDhW4KjXrdQxkyswMmMQ3oN5g=; b=Yft5c96SibMKkk4Q24juz8fIMghbKGaxKDvRtyP2wCIJTSyIJug8a8hr/H+e5H1hMu FMTv/Ns+ERvVd0/jfElS2ekx+sA/TmTskmKpBK/u/9CoJ50cv5lX4SWo7a8JauUnpByQ zI8eWTd1OC/S8pSYVUqDD0NVdBb2yNbljd0gS+2TSKAeHPK/RzgBCrFcvzyvV6Lp33ke X8DDWD3vo/1o36uZsZZW1R2VSLlrW4c1wbuBhQJI9Tc/jEnMUCyv29OOZEDDTxWaFFZK 9PY5S/vZkRqrKG4QsVWwe4G789d4rs6nhG95M19/YpyGQIF6DUc0DEFzLHKnr8VFgm4U d4yQ== X-Gm-Message-State: AOAM530NiRacdrLhk1XEu3lk0RAxthfRbLLpxztPhuMq5K9DjT+H3HlB wruhgvw7ae2gGIMHiqltek8rTmS7qC1TnQ== X-Google-Smtp-Source: ABdhPJzZGbgXls4SipwM18uE0byctPAhPmlAZL5eg5eOD8s1W1zn+bjHr0I25Veo5FZM9qcw9Km5YQ== X-Received: by 2002:a4a:765c:: with SMTP id w28mr3325562ooe.8.1619188737811; Fri, 23 Apr 2021 07:38:57 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id q23sm1395627otc.7.2021.04.23.07.38.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Apr 2021 07:38:57 -0700 (PDT) Date: Fri, 23 Apr 2021 09:38:55 -0500 From: Bjorn Andersson To: Douglas Anderson Cc: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sam Ravnborg , Wolfram Sang , Stephen Boyd , robdclark@chromium.org, Maarten Lankhorst , Stanislav Lisovskiy , Steev Klimaszewski , linux-arm-msm@vger.kernel.org, Linus W , Daniel Vetter , David Airlie , Robert Foss , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 12/27] drm/bridge: ti-sn65dsi86: Cleanup managing of drvdata Message-ID: References: <20210416223950.3586967-1-dianders@chromium.org> <20210416153909.v4.12.If5d4d4e22e97bebcd493b76765c1759527705620@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210416153909.v4.12.If5d4d4e22e97bebcd493b76765c1759527705620@changeid> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri 16 Apr 17:39 CDT 2021, Douglas Anderson wrote: > Let's: > - Set the drvdata as soon as it's allocated. This just sets up a > pointer so there's no downside here. > - Remove the useless call to i2c_set_clientdata() which is literally > the same thing as dev_set_drvdata(). > > No functional changes intended. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Douglas Anderson > --- > > (no changes since v1) > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > index 2cbf619fbd27..a200e88fd006 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -1238,6 +1238,8 @@ static int ti_sn65dsi86_probe(struct i2c_client *client, > pdata = devm_kzalloc(dev, sizeof(struct ti_sn65dsi86), GFP_KERNEL); > if (!pdata) > return -ENOMEM; > + dev_set_drvdata(dev, pdata); > + pdata->dev = dev; > > pdata->regmap = devm_regmap_init_i2c(client, > &ti_sn65dsi86_regmap_config); > @@ -1246,16 +1248,12 @@ static int ti_sn65dsi86_probe(struct i2c_client *client, > return PTR_ERR(pdata->regmap); > } > > - pdata->dev = dev; > - > ret = drm_of_find_panel_or_bridge(dev->of_node, 1, 0, &pdata->panel, NULL); > if (ret) { > DRM_ERROR("could not find any panel node\n"); > return ret; > } > > - dev_set_drvdata(dev, pdata); > - > pdata->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW); > if (IS_ERR(pdata->enable_gpio)) { > DRM_ERROR("failed to get enable gpio from DT\n"); > @@ -1287,8 +1285,6 @@ static int ti_sn65dsi86_probe(struct i2c_client *client, > return ret; > } > > - i2c_set_clientdata(client, pdata); > - > pdata->aux.name = "ti-sn65dsi86-aux"; > pdata->aux.dev = dev; > pdata->aux.transfer = ti_sn_aux_transfer; > -- > 2.31.1.368.gbe11c130af-goog >