From: Matthias Kaehlcke <mka@chromium.org>
To: Felipe Balbi <balbi@kernel.org>
Cc: Sandeep Maheswaram <sanm@codeaurora.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stephen Boyd <swboyd@chromium.org>,
Doug Anderson <dianders@chromium.org>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
Manu Gautam <mgautam@codeaurora.org>
Subject: Re: [PATCH v7 5/5] usb: dwc3: qcom: Keep power domain on to support wakeup
Date: Thu, 13 May 2021 07:34:33 -0700 [thread overview]
Message-ID: <YJ04+aQijdSxJjm3@google.com> (raw)
In-Reply-To: <87tun67nhc.fsf@kernel.org>
On Thu, May 13, 2021 at 04:49:19PM +0300, Felipe Balbi wrote:
>
> Hi,
>
> Matthias Kaehlcke <mka@chromium.org> writes:
> >> Sandeep Maheswaram <sanm@codeaurora.org> writes:
> >> > If wakeup capable devices are connected to the controller (directly
> >> > or through hubs) at suspend time keep the power domain on in order
> >> > to support wakeup from these devices.
> >> >
> >> > Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org>
> >> > ---
> >> > drivers/usb/dwc3/dwc3-qcom.c | 17 +++++++++++++++++
> >> > 1 file changed, 17 insertions(+)
> >> >
> >> > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> >> > index 82125bc..1e220af 100644
> >> > --- a/drivers/usb/dwc3/dwc3-qcom.c
> >> > +++ b/drivers/usb/dwc3/dwc3-qcom.c
> >> > @@ -17,9 +17,11 @@
> >> > #include <linux/of_platform.h>
> >> > #include <linux/platform_device.h>
> >> > #include <linux/phy/phy.h>
> >> > +#include <linux/pm_domain.h>
> >> > #include <linux/usb/of.h>
> >> > #include <linux/reset.h>
> >> > #include <linux/iopoll.h>
> >> > +#include <linux/usb/hcd.h>
> >> >
> >> > #include "core.h"
> >> >
> >> > @@ -354,10 +356,19 @@ static int dwc3_qcom_suspend(struct dwc3_qcom *qcom)
> >> > {
> >> > u32 val;
> >> > int i, ret;
> >> > + struct dwc3 *dwc = platform_get_drvdata(qcom->dwc3);
> >> > + struct usb_hcd *hcd;
> >> > + struct generic_pm_domain *genpd = pd_to_genpd(qcom->dev->pm_domain);
> >> >
> >> > if (qcom->is_suspended)
> >> > return 0;
> >> >
> >> > + if (dwc->xhci) {
> >> > + hcd = platform_get_drvdata(dwc->xhci);
> >> > + if (usb_wakeup_enabled_descendants(hcd->self.root_hub))
> >> > + genpd->flags |= GENPD_FLAG_ACTIVE_WAKEUP;
> >> > + }
> >>
> >> wow, you really need to find a way to do these things generically
> >> instead of bypassing a bunch of layers and access stuff $this doesn't
> >> directly own.
> >>
> >> I'm gonna say 'no' to this, sorry. It looks like xhci should, directly,
> >> learn about much of this instead of hiding it 3-layers deep into the
> >> dwc3 glue layer for your specific SoC.
> >
> > Maybe this could be addressed with a pair of wakeup quirks, one for suspend,
> > another for resume. An optional genpd field could be added to struct
> > xhci_plat_priv. The wakeup quirks would set/clear GENPD_FLAG_ACTIVE_WAKEUP
> > of the genpd.
> >
> > Does the above sound more palatable?
>
> I don't get why you need quirk flags. All you're doing here is:
>
> if (usb_wakeup_enabled_descendants(hcd->self.root_hub))
> genpd->flags |= GENPD_FLAG_ACTIVE_WAKEUP;
>
> If you move this test to xhci_suspend(), you shouldn't need all the
> magic, right?
Right, the quirks shouldn't be necessary if setting/clearing the genpd
flag is the right thing to do for any controller that sets the genpd
field in _priv, which probably is the case.
prev parent reply other threads:[~2021-05-13 14:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 5:11 [PATCH v7 0/5] USB DWC3 host wake up support from system suspend Sandeep Maheswaram
2021-04-28 5:11 ` [PATCH v7 1/5] usb: dwc3: host: Set PHY mode during suspend Sandeep Maheswaram
2021-04-28 9:55 ` Felipe Balbi
[not found] ` <fd927828-a414-cd42-1e4a-b9e9b0744a3a@codeaurora.org>
2021-05-03 11:16 ` Felipe Balbi
2021-05-12 19:12 ` Matthias Kaehlcke
2021-05-13 13:46 ` Felipe Balbi
2021-05-13 14:37 ` Matthias Kaehlcke
2021-04-28 5:11 ` [PATCH v7 2/5] usb: dwc3: core: Host wake up support from system suspend Sandeep Maheswaram
2021-04-28 9:59 ` Felipe Balbi
2021-05-03 4:33 ` Sandeep Maheswaram
2021-05-03 11:20 ` Felipe Balbi
2021-05-12 21:47 ` Matthias Kaehlcke
2021-05-26 4:29 ` Sandeep Maheswaram
2021-04-28 5:11 ` [PATCH v7 3/5] usb: dwc3: qcom: Add helper functions to enable,disable wake irqs Sandeep Maheswaram
2021-04-28 5:11 ` [PATCH v7 4/5] usb: dwc3: qcom: Configure wakeup interrupts during suspend Sandeep Maheswaram
2021-04-28 10:02 ` Felipe Balbi
2021-04-28 5:11 ` [PATCH v7 5/5] usb: dwc3: qcom: Keep power domain on to support wakeup Sandeep Maheswaram
2021-04-28 10:04 ` Felipe Balbi
2021-05-13 0:23 ` Matthias Kaehlcke
2021-05-13 13:49 ` Felipe Balbi
2021-05-13 14:34 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJ04+aQijdSxJjm3@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mgautam@codeaurora.org \
--cc=sanm@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).