linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: skakit@codeaurora.org
Cc: Matthias Kaehlcke <mka@chromium.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, kgunda@codeaurora.org
Subject: Re: [RESEND PATCH V4 3/8] arm64: dts: qcom: pm7325: Add pm7325 base dts file
Date: Thu, 20 May 2021 12:50:12 +0530	[thread overview]
Message-ID: <YKYNrKFrGQlfUf4S@vkoul-mobl.Dlink> (raw)
In-Reply-To: <52d277a8598277716f37ad0c1f724845@codeaurora.org>

On 20-05-21, 12:02, skakit@codeaurora.org wrote:
> On 2021-05-18 22:12, Matthias Kaehlcke wrote:
> > On Tue, May 18, 2021 at 05:16:27PM +0530, Vinod Koul wrote:
> > > On 18-05-21, 11:50, satya priya wrote:
> > > > Add base DTS file for pm7325 along with GPIOs and temp-alarm nodes.
> > > >
> > > > Signed-off-by: satya priya <skakit@codeaurora.org>
> > > > Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> > > > ---
> > > > Changes in RESEND V4:
> > > >  - No Changes.
> > > >
> > > >  arch/arm64/boot/dts/qcom/pm7325.dtsi | 53 ++++++++++++++++++++++++++++++++++++
> > > >  1 file changed, 53 insertions(+)
> > > >  create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi
> > > >
> > > > diff --git a/arch/arm64/boot/dts/qcom/pm7325.dtsi b/arch/arm64/boot/dts/qcom/pm7325.dtsi
> > > > new file mode 100644
> > > > index 0000000..e7f64a9
> > > > --- /dev/null
> > > > +++ b/arch/arm64/boot/dts/qcom/pm7325.dtsi
> > > > @@ -0,0 +1,53 @@
> > > > +// SPDX-License-Identifier: BSD-3-Clause
> > > > +// Copyright (c) 2021, The Linux Foundation. All rights reserved.
> > > > +
> > > > +#include <dt-bindings/interrupt-controller/irq.h>
> > > > +#include <dt-bindings/spmi/spmi.h>
> > > > +
> > > > +&spmi_bus {
> > > > +	pm7325: pmic@1 {
> > > > +		compatible = "qcom,pm7325", "qcom,spmi-pmic";
> > > 
> > > where is qcom,pm7325 documented?
> 
> > 
> > good point, I missed that one.
> > 
> 
> Actually this point was discussed during V2(
> https://lore.kernel.org/patchwork/patch/1406186/#1607321 ).
> As far as I understand it is not mandatory to add "qcom,pm7325" as we are
> adding "qcom,spmi-pmic". It is just a good to have change.
> I could not find the documentation for pm8350c, pmk8350 and pmr735a as well.

Yes that is a miss too, IMO all of these should be added to
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt or the yaml
file replacing this

Thanks
-- 
~Vinod

  reply	other threads:[~2021-05-20  7:20 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18  6:20 [RESEND PATCH V4 0/8] Add PMIC DT files for sc7280 satya priya
2021-05-18  6:20 ` [RESEND PATCH V4 1/8] arm64: dts: qcom: sm8350: Add label for thermal-zones node satya priya
2021-05-18 11:43   ` Vinod Koul
2021-05-20  6:24     ` skakit
2021-05-18  6:20 ` [RESEND PATCH V4 2/8] arm64: dts: qcom: sc7280: Add " satya priya
2021-05-18 11:44   ` Vinod Koul
2021-05-18 16:27     ` Matthias Kaehlcke
2021-05-18 21:16       ` Dmitry Baryshkov
2021-05-20  6:25       ` skakit
2021-05-18  6:20 ` [RESEND PATCH V4 3/8] arm64: dts: qcom: pm7325: Add pm7325 base dts file satya priya
2021-05-18 11:46   ` Vinod Koul
2021-05-18 16:42     ` Matthias Kaehlcke
2021-05-20  6:32       ` skakit
2021-05-20  7:20         ` Vinod Koul [this message]
2021-05-21 12:22           ` skakit
2021-05-18  6:20 ` [RESEND PATCH V4 4/8] arm64: dts: qcom: pm8350c: Add temp-alarm support satya priya
2021-05-18 11:48   ` Vinod Koul
2021-05-20  6:25     ` skakit
2021-05-18  6:20 ` [RESEND PATCH V4 5/8] arm64: dts: qcom: pmr735a: " satya priya
2021-05-18  6:20 ` [RESEND PATCH V4 6/8] arm64: dts: qcom: pmk8350: Add peripherals for pmk8350 satya priya
2021-05-18  6:20 ` [RESEND PATCH V4 7/8] arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280-idp satya priya
2021-05-18  6:20 ` [RESEND PATCH V4 8/8] arm64: dts: qcom: sc7280: Add ADC channel nodes for PMIC temperatures to sc7280-idp satya priya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKYNrKFrGQlfUf4S@vkoul-mobl.Dlink \
    --to=vkoul@kernel.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kgunda@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=robh+dt@kernel.org \
    --cc=skakit@codeaurora.org \
    --subject='Re: [RESEND PATCH V4 3/8] arm64: dts: qcom: pm7325: Add pm7325 base dts file' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).