linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: Stephan Gerhold <stephan@gerhold.net>,
	~postmarketos/upstreaming@lists.sr.ht,
	martin.botka@somainline.org,
	angelogioacchino.delregno@somainline.org,
	marijn.suijten@somainline.org, jamipkettunen@somainline.org,
	Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH v3 3/3] arm64: dts: qcom: Add support for SONY Xperia X Performance / XZ / XZs (msm8996, Tone platform)
Date: Tue, 8 Jun 2021 14:47:04 -0500	[thread overview]
Message-ID: <YL/JOJibHOXYCOty@builder.lan> (raw)
In-Reply-To: <409ef9ca-0533-ddc3-3332-5cc2af0aa1e0@somainline.org>

On Tue 08 Jun 14:08 CDT 2021, Konrad Dybcio wrote:

> 
> >> +/delete-node/ &hdmi;
> >> +/delete-node/ &hdmi_phy;
> >> +/delete-node/ &mdp5_intf3_out;
> > Is it not enough to set those to status = "disabled"? Kind of strange
> > that you have to delete those entirely. I guess ideally "hdmi" should
> > even be disabled by default in the SoC device tree.
> 
> Saving memory and bloat where possible. Deleting these makes inspecting decompiled
> DTBs simpler and allows for ever so slightly bigger kernel images (the boot partition is finite).
> 

While that is true, the typical method is to disable the nodes, so
please follow that.

> 
> 
> >> +
> >> +	panel_tvdd: tvdd-regulator {
> >> +		compatible = "regulator-fixed";
> >> +		regulator-name = "panel_tvdd";
> >> +		gpio = <&tlmm 50 GPIO_ACTIVE_HIGH>;
> > regulator-fixed is active-low without "enable-active-high;"
> > If that's what you want it's probably more clear to write
> > GPIO_ACTIVE_LOW. Otherwise, perhaps you forgot that property? :)
> 
> Interestingly enough it doesn't work *with* the property, but does without :|

The regulator-fixed driver overrides the flag by the presence of
'enable-active-high" property, so if it works without said property that
would imply that your control is active-low.

So please make the flag reflect that.

Regards,
Bjorn

      reply	other threads:[~2021-06-08 19:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-08 15:27 [PATCH v3 1/3] arm64: dts: qcom: Add PMI8996 DTSI file Konrad Dybcio
2021-06-08 15:27 ` [PATCH v3 2/3] arm64: dts: qcom: Add MSM8996v3.0 " Konrad Dybcio
2021-06-08 15:27 ` [PATCH v3 3/3] arm64: dts: qcom: Add support for SONY Xperia X Performance / XZ / XZs (msm8996, Tone platform) Konrad Dybcio
2021-06-08 16:39   ` Stephan Gerhold
2021-06-08 19:08     ` Konrad Dybcio
2021-06-08 19:47       ` Bjorn Andersson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YL/JOJibHOXYCOty@builder.lan \
    --to=bjorn.andersson@linaro.org \
    --cc=agross@kernel.org \
    --cc=angelogioacchino.delregno@somainline.org \
    --cc=anton@enomsg.org \
    --cc=ccross@android.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jamipkettunen@somainline.org \
    --cc=keescook@chromium.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=martin.botka@somainline.org \
    --cc=robh+dt@kernel.org \
    --cc=stephan@gerhold.net \
    --cc=tony.luck@intel.com \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    --subject='Re: [PATCH v3 3/3] arm64: dts: qcom: Add support for SONY Xperia X Performance / XZ / XZs (msm8996, Tone platform)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).