From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Maulik Shah <mkshah@codeaurora.org>,
evgreen@chromium.org, mka@chromium.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
agross@kernel.org, dianders@chromium.org, linux@roeck-us.net,
rnayak@codeaurora.org, lsrao@codeaurora.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v8 3/5] arm64: dts: qcom: sc7180: Enable SoC sleep stats
Date: Mon, 31 May 2021 12:57:03 -0500 [thread overview]
Message-ID: <YLUjbwFSJOSWS0IV@builder.lan> (raw)
In-Reply-To: <CAE-0n53ySKwDwzRYFYjnQnqVAujVrkik2U-PeCuS61xQU-hbWA@mail.gmail.com>
On Wed 26 May 18:30 CDT 2021, Stephen Boyd wrote:
> Quoting Maulik Shah (2021-05-21 04:26:09)
> > Add device node for SoC sleep stats driver which provides various
> > low power mode stats.
> >
> > Also update the reg size of aoss_qmp device to 0x400.
> >
> > Cc: devicetree@vger.kernel.org
> > Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
> > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > ---
> > arch/arm64/boot/dts/qcom/sc7180.dtsi | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > index 6228ba2..889d04d 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > @@ -3215,7 +3215,7 @@
> >
> > aoss_qmp: power-controller@c300000 {
> > compatible = "qcom,sc7180-aoss-qmp";
> > - reg = <0 0x0c300000 0 0x100000>;
> > + reg = <0 0x0c300000 0 0x400>;
> > interrupts = <GIC_SPI 389 IRQ_TYPE_EDGE_RISING>;
> > mboxes = <&apss_shared 0>;
> >
> > @@ -3223,6 +3223,11 @@
> > #power-domain-cells = <1>;
> > };
> >
> > + rpmh-sleep-stats@c3f0000 {
> > + compatible = "qcom,rpmh-sleep-stats";
> > + reg = <0 0x0c3f0000 0 0x400>;
> > + };
> > +
>
> Does this need to be in DT? Can the sc7180-aoss-qmp driver use the
> aux-bus and stick the sleep stats device on there?
>
The AOSS memory space has N chunks of "message ram", one is used for the
QMP protocol (presumably the APSS specific one), a different one is used
for the sleep stats.
I presume we could have come up with a binding for the entire AOSS/AOP
and then describe (either implicit or explicitly) the QMP and
debug-stats under that.
But we'd also have to come up with the same container-device for the RPM
case.
Regards,
Bjorn
> > spmi_bus: spmi@c440000 {
> > compatible = "qcom,spmi-pmic-arb";
> > reg = <0 0x0c440000 0 0x1100>,
next prev parent reply other threads:[~2021-05-31 17:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 11:26 [PATCH v8 0/5] Introduce SoC sleep stats driver Maulik Shah
2021-05-21 11:26 ` [PATCH v8 1/5] dt-bindings: Introduce SoC sleep stats bindings Maulik Shah
2021-05-21 11:26 ` [PATCH v8 2/5] soc: qcom: Add SoC sleep stats driver Maulik Shah
2021-05-26 23:45 ` Stephen Boyd
2021-09-05 12:59 ` Maulik Shah
2021-05-31 17:30 ` Bjorn Andersson
2021-05-21 11:26 ` [PATCH v8 3/5] arm64: dts: qcom: sc7180: Enable SoC sleep stats Maulik Shah
2021-05-26 23:30 ` Stephen Boyd
2021-05-31 17:57 ` Bjorn Andersson [this message]
2021-06-03 0:26 ` Stephen Boyd
2021-06-03 2:44 ` Bjorn Andersson
2021-06-04 21:53 ` Stephen Boyd
2021-06-06 3:42 ` Bjorn Andersson
2021-09-05 12:59 ` Maulik Shah
2021-05-21 11:26 ` [PATCH v8 4/5] arm64: defconfig: Enable SoC sleep stats driver Maulik Shah
2021-05-26 23:30 ` Stephen Boyd
2021-05-21 11:26 ` [PATCH v8 5/5] arm64: dts: qcom: sc7280: Enable SoC sleep stats Maulik Shah
2021-05-26 23:30 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLUjbwFSJOSWS0IV@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lsrao@codeaurora.org \
--cc=mka@chromium.org \
--cc=mkshah@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).