From: Sujit Kautkar <email@example.com>
To: Doug Anderson <firstname.lastname@example.org>
Cc: Andy Gross <email@example.com>,
Bjorn Andersson <firstname.lastname@example.org>,
Rob Herring <email@example.com>,
Sibi Sankar <firstname.lastname@example.org>,
Rajendra Nayak <email@example.com>,
Mark Rutland <firstname.lastname@example.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: sc7180: SD-card GPIO pin set bias-pull up
Date: Thu, 3 Jun 2021 14:16:33 -0700 [thread overview]
Message-ID: <YLlGseTHHCTDN68V@google.com> (raw)
On Thu, Jun 03, 2021 at 01:33:07PM -0700, Doug Anderson wrote:
> On Wed, Jun 2, 2021 at 12:14 PM Sujit Kautkar <email@example.com> wrote:
> > Some SC7180 based board do not have external pull-up for cd-gpio.
> nit: s/board/boards
> Presumably Bjorn could fix this when he applies the patch. I wouldn't
> re-post just for this fix unless Bjorn asks you to.
I can repost this patch again with this fix if required
> FYI: I had my Reviewed-by tag on v2. While you did make changes
> between v2 and v3, in this case I don't think the changes were
> significant enough to warrant removing my Reviewed-by tag and I would
> have been happy if you'd kept it.
> In general, if you ever have questions about whether you should keep
> someone's reviewed tag, it never hurts to mention your logic "after
> the cut" (I think you use patman so this would be "Commit-notes:").
> For instance, you could say this if you removed Reviewed-by tags:
It is good to know this.
> I totally recombobulated the frobnication logic in v3 and removed
> previous Reviewed-by tags. Hopefully reviewers can re-add if they
> still think the patch is good.
> ...or, you could say this if you kept them but you weren't totally
> sure it was OK:
> Even though every single line in the v3 patch changed from v2, it's
> only because I fixed a stoopid spelling Mistake. Thus, I kept previous
> Reviewed-by tags. Please yell if you object. Who knew that the only
> acceptable spelling of the English word "stupid" in kerneldoc comments
> was written as "stoopid". Live and learn.
> In any case, here's my Reviewed-by tag again. I also agree that
> Bjorn's comments made sense and were good to fix...
> Reviewed-by: Douglas Anderson <firstname.lastname@example.org>
Thanks for adding review tag again. I intended to keep this tag since
only commit message is updated, but I forgot to add it back while
posting latest version.
next prev parent reply other threads:[~2021-06-03 21:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 19:13 [PATCH v3 0/2] Update sd card pinconf for sc7180 DT Sujit Kautkar
2021-06-02 19:13 ` [PATCH v3 1/2] arm64: dts: qcom: sc7180: Move sdc pinconf to board specific DT files Sujit Kautkar
2021-06-03 20:23 ` Doug Anderson
2021-06-02 19:13 ` [PATCH v3 2/2] arm64: dts: qcom: sc7180: SD-card GPIO pin set bias-pull up Sujit Kautkar
2021-06-03 20:33 ` Doug Anderson
2021-06-03 21:16 ` Sujit Kautkar [this message]
2021-06-10 14:50 ` [PATCH v3 0/2] Update sd card pinconf for sc7180 DT patchwork-bot+linux-arm-msm
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).