From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C7FEC47082 for ; Sun, 6 Jun 2021 03:34:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 61F6C6113E for ; Sun, 6 Jun 2021 03:34:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230075AbhFFDfu (ORCPT ); Sat, 5 Jun 2021 23:35:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230060AbhFFDfu (ORCPT ); Sat, 5 Jun 2021 23:35:50 -0400 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8CC1C061766 for ; Sat, 5 Jun 2021 20:33:47 -0700 (PDT) Received: by mail-ot1-x32a.google.com with SMTP id i12-20020a05683033ecb02903346fa0f74dso13261714otu.10 for ; Sat, 05 Jun 2021 20:33:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pCeXT9a5d7ZMX7CdNxFcTb0it+4u0J15VMolhmJ0Wz8=; b=jLUj0OTdBRJU8X4s/4Dw8+4TLW4dp4o0uyEPSwy9JKQvZLvQP8/ZCDHPRK4LWTF1t+ yGoN2Uz9RLtuq3Utg1bXI0z0N18psLrCUJp+luhFeOoyE0r1wnEk5jGrYCh/ockICZks cyIaF4lhHR51bzVk9IKjTu9RkWMMBjKwFECX0jUkpnJIv/5az/imrGtddE6k+A6CDbpl dU8AfGo0efxg7JjGmdRx/tBRZAqIX/A5OewSUmnyO/FCG5V7PgnESpNCFdzzTItA79Dm aZAN96FaVmSPA9BOVgwMvlh6AxTD8a3NpD2yiIzDYt8mONTBY94wOwGOphY3uSiRfYRT Uz5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pCeXT9a5d7ZMX7CdNxFcTb0it+4u0J15VMolhmJ0Wz8=; b=Mmxpn6kTAAIZ9pSMc5vBiP2q3ol8d7M+A/aCHa/gGeTI+2oizQKJaoNyJA2T7KoEl0 f/KpkmLJwIypueVyP/N432SctbDh8JmnimaaESFewhz6sJK7spXnJ4St6w8DPYTTRd6H 0LqAvcpekH93IZkFF7Iwov0o0SiD+qOsGhh2SCuzT2rWb4KtSHkEjkeySEjmU/2HY+iN BX9LMiImxNU6eQR/dmVgfQCLhhAQhmj8Ua32FCOgGbgATYjafvpixF7m42slxr7VeMmb QKPV3c+exmajiGK0yNhgHyxZzv48DA/hK1HyiUMzKX467fSEJezDVxzbLheu/c2oumPU pRkA== X-Gm-Message-State: AOAM530AIVX8d7Q0GRGFvPrG5/yeba0QHSEgY+46Qi+Zq+l+v7s+LGJB AB9cXAXagAtrcOseskse+hl+jQ== X-Google-Smtp-Source: ABdhPJxNeagQXELCYW+nbXCZDSKD7v5lxDpyV1kAtWIlIA4tc9aIwmCKQVLx7D+Mh0TiElFBDqSMRw== X-Received: by 2002:a9d:249:: with SMTP id 67mr9271547otb.356.1622950427019; Sat, 05 Jun 2021 20:33:47 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id t32sm551510oiw.44.2021.06.05.20.33.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Jun 2021 20:33:46 -0700 (PDT) Date: Sat, 5 Jun 2021 22:33:44 -0500 From: Bjorn Andersson To: Yang Yingliang Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, lee.jones@linaro.org, agross@kernel.org, gurus@codeaurora.org, dmitry.baryshkov@linaro.org Subject: Re: [PATCH net-next v3] mfd: pm8008: Fix return value check in pm8008_probe() Message-ID: References: <20210605022446.4119978-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210605022446.4119978-1-yangyingliang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri 04 Jun 21:24 CDT 2021, Yang Yingliang wrote: > In case of error, the function devm_regmap_init_i2c() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check > should be replaced with IS_ERR(). > > Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC") > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang Reviewed-by: Bjorn Andersson > --- > v3: > return PTR_ERR(chip->regmap) instead of ENODEV > --- > drivers/mfd/qcom-pm8008.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c > index c472d7f8103c..fb8915a682ad 100644 > --- a/drivers/mfd/qcom-pm8008.c > +++ b/drivers/mfd/qcom-pm8008.c > @@ -228,8 +228,8 @@ static int pm8008_probe(struct i2c_client *client) > > chip->dev = &client->dev; > chip->regmap = devm_regmap_init_i2c(client, &qcom_mfd_regmap_cfg); > - if (!chip->regmap) > - return -ENODEV; > + if (IS_ERR(chip->regmap)) > + return PTR_ERR(chip->regmap); > > i2c_set_clientdata(client, chip); > > -- > 2.25.1 >