From: Bjorn Andersson <bjorn.andersson@linaro.org> To: Douglas Anderson <dianders@chromium.org> Cc: Andrzej Hajda <a.hajda@samsung.com>, Neil Armstrong <narmstrong@baylibre.com>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jonas Karlman <jonas@kwiboo.se>, Sam Ravnborg <sam@ravnborg.org>, Linus W <linus.walleij@linaro.org>, robdclark@chromium.org, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>, Steev Klimaszewski <steev@kali.org>, linux-arm-msm@vger.kernel.org, Thierry Reding <treding@nvidia.com>, Lyude Paul <lyude@redhat.com>, dri-devel@lists.freedesktop.org, Stephen Boyd <swboyd@chromium.org>, Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 11/11] arm64: dts: qcom: sc7180-trogdor: Move panel under the bridge chip Date: Wed, 9 Jun 2021 10:27:04 -0500 [thread overview] Message-ID: <YMDdyEzCpdttQyNu@builder.lan> (raw) In-Reply-To: <20210607100234.v9.11.Ibdb7735fb1844561b902252215a69526a14f9abd@changeid> On Mon 07 Jun 12:05 CDT 2021, Douglas Anderson wrote: > Putting the panel under the bridge chip (under the aux-bus node) > allows the panel driver to get access to the DP AUX bus, enabling all > sorts of fabulous new features. > > While we're at this, get rid of a level of hierarchy for the panel > node. It doesn't need "ports / port" and can just have a "port" child. > > For Linux, this patch has a hard requirement on the patches adding DP > AUX bus support to the ti-sn65dsi86 bridge chip driver. See the patch > ("drm/bridge: ti-sn65dsi86: Add support for the DP AUX bus"). > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > Acked-by: Linus Walleij <linus.walleij@linaro.org> In case you want to merge this together with the driver changes (even though there's no direct need for them to go together): Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > > (no changes since v7) > > Changes in v7: > - Panel now under bridge chip instead of getting a link to ddc-i2c > > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 30 ++++++++++---------- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > index 24d293ef56d7..c76afd857b54 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > @@ -260,21 +260,6 @@ max98357a: audio-codec-0 { > #sound-dai-cells = <0>; > }; > > - panel: panel { > - /* Compatible will be filled in per-board */ > - power-supply = <&pp3300_dx_edp>; > - backlight = <&backlight>; > - hpd-gpios = <&sn65dsi86_bridge 2 GPIO_ACTIVE_HIGH>; > - > - ports { > - port { > - panel_in_edp: endpoint { > - remote-endpoint = <&sn65dsi86_out>; > - }; > - }; > - }; > - }; > - > pwmleds { > compatible = "pwm-leds"; > keyboard_backlight: keyboard-backlight { > @@ -674,6 +659,21 @@ sn65dsi86_out: endpoint { > }; > }; > }; > + > + aux-bus { > + panel: panel { > + /* Compatible will be filled in per-board */ > + power-supply = <&pp3300_dx_edp>; > + backlight = <&backlight>; > + hpd-gpios = <&sn65dsi86_bridge 2 GPIO_ACTIVE_HIGH>; > + > + port { > + panel_in_edp: endpoint { > + remote-endpoint = <&sn65dsi86_out>; > + }; > + }; > + }; > + }; > }; > }; > > -- > 2.32.0.rc1.229.g3e70b5a671-goog >
prev parent reply other threads:[~2021-06-09 15:27 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-07 17:05 [PATCH v9 00/11] drm: Fix EDID reading on ti-sn65dsi86 by introducing the DP AUX bus Douglas Anderson 2021-06-07 17:05 ` [PATCH v9 01/11] dt-bindings: display: simple: List hpd properties in panel-simple Douglas Anderson 2021-06-07 17:05 ` [PATCH v9 02/11] dt-bindings: drm: Introduce the DP AUX bus Douglas Anderson 2021-06-09 11:05 ` Linus Walleij 2021-06-07 17:05 ` [PATCH v9 03/11] dt-bindings: drm/bridge: ti-sn65dsi86: Add aux-bus child Douglas Anderson 2021-06-09 11:05 ` Linus Walleij 2021-06-07 17:05 ` [PATCH v9 04/11] drm: Introduce the DP AUX bus Douglas Anderson 2021-06-11 16:48 ` Lyude Paul 2021-06-07 17:05 ` [PATCH v9 05/11] drm/panel: panel-simple: Allow panel-simple be a DP AUX endpoint device Douglas Anderson 2021-06-07 17:05 ` [PATCH v9 06/11] drm/panel: panel-simple: Stash DP AUX bus; allow using it for DDC Douglas Anderson 2021-06-09 11:07 ` Linus Walleij 2021-06-07 17:05 ` [PATCH v9 07/11] drm/bridge: ti-sn65dsi86: Promote the AUX channel to its own sub-dev Douglas Anderson 2021-06-09 11:08 ` Linus Walleij 2021-06-07 17:05 ` [PATCH v9 08/11] drm/bridge: ti-sn65dsi86: Add support for the DP AUX bus Douglas Anderson 2021-06-07 17:05 ` [PATCH v9 09/11] drm/bridge: ti-sn65dsi86: Don't read EDID blob over DDC Douglas Anderson 2021-06-07 17:05 ` [PATCH v9 10/11] drm/bridge: ti-sn65dsi86: Improve probe errors with dev_err_probe() Douglas Anderson 2021-06-09 11:09 ` Linus Walleij 2021-06-07 17:05 ` [PATCH v9 11/11] arm64: dts: qcom: sc7180-trogdor: Move panel under the bridge chip Douglas Anderson 2021-06-09 15:27 ` Bjorn Andersson [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YMDdyEzCpdttQyNu@builder.lan \ --to=bjorn.andersson@linaro.org \ --cc=Laurent.pinchart@ideasonboard.com \ --cc=a.hajda@samsung.com \ --cc=agross@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=jonas@kwiboo.se \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lyude@redhat.com \ --cc=maarten.lankhorst@linux.intel.com \ --cc=narmstrong@baylibre.com \ --cc=robdclark@chromium.org \ --cc=robh+dt@kernel.org \ --cc=sam@ravnborg.org \ --cc=stanislav.lisovskiy@intel.com \ --cc=steev@kali.org \ --cc=swboyd@chromium.org \ --cc=treding@nvidia.com \ --subject='Re: [PATCH v9 11/11] arm64: dts: qcom: sc7180-trogdor: Move panel under the bridge chip' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).