From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A3FFC48BD1 for ; Fri, 11 Jun 2021 03:14:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E465A61359 for ; Fri, 11 Jun 2021 03:14:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231400AbhFKDQk (ORCPT ); Thu, 10 Jun 2021 23:16:40 -0400 Received: from mail-ot1-f41.google.com ([209.85.210.41]:46921 "EHLO mail-ot1-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231309AbhFKDQj (ORCPT ); Thu, 10 Jun 2021 23:16:39 -0400 Received: by mail-ot1-f41.google.com with SMTP id 66-20020a9d02c80000b02903615edf7c1aso1776835otl.13 for ; Thu, 10 Jun 2021 20:14:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=KQu0eDuwQvpglxFBbKjew1x6RGhhszO56HCWSTbbarA=; b=TX7g+W/s3byvmkCH7QlSOO557obd7nW2JBe6rGkstprgoJpSfCZ/kSiKJNx83GDOU+ xw1FIybt2mTCYrgfbBnXnPuMvGpx/6AH26eaDRdLGEGhxREwPMei3U1eTY48le7CbTuZ ypX7VuXGC6vMtqgn0Seq6ZTqMWOsOJe0NVNxsKFuirQl/KT3jpwq2btseiFZW8BN8eXH O6RxNAgDnLL3qOMoFpxC03Mg2lwN8TMizNBiTNerVklP/VYdpatDDAlxwyu0eprsQXt4 jkYVfYijx2pag0W5k7LD7UPmPAb+xg+jys+k8DszgOUYE+SOqvBfKYCCPNJHC1+Lan9e /77Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KQu0eDuwQvpglxFBbKjew1x6RGhhszO56HCWSTbbarA=; b=CIAB8c9Okjn0+NGkJJJClv+T15/PVDXMjGECkXNJxlF29IkdTKJsdTN7IDd2w7QcgU tKtl9jODcu0I+hFpe7D8GPjM1U1b2u2yXW9mnNtiNQDocIsuPVqYk1SM+x5jWMz0breO J9Ol91p4d5DUpYmFrOhNI6mGJXuDCdrHnB/3p6G9i4KzUDttrGjJr9YdS3r2R7qaKk3r yIkx7i6CgFqeHITzAQNOhETl+TbrxH3pFwzOtM8cJsIly3q8QftuPFKi/qr8ARqZZt3X Ocl2zwggYDQjP0w391Dwv2+QAm+N+vs7qspk+PBDs7vqz564n5614TPt8dj2QvvohkOR e8fw== X-Gm-Message-State: AOAM5325e6IxD4+HWTb4iBPOtwj2jpvdZERGtjBm79Jm+ycVdQjE+toK alcgc+B+lPlCDlPDOvBr3jc7/w== X-Google-Smtp-Source: ABdhPJw7EYbfaoXxnIco2pLxpPJBwR54SnN3GzbtMcq7eaTMq+GPiQAso6TL1BvXqJasrqSoKTQHyA== X-Received: by 2002:a05:6830:19c2:: with SMTP id p2mr1151911otp.234.1623381210437; Thu, 10 Jun 2021 20:13:30 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id z23sm601635ooz.15.2021.06.10.20.13.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 20:13:29 -0700 (PDT) Date: Thu, 10 Jun 2021 22:13:28 -0500 From: Bjorn Andersson To: Bhupesh Sharma Cc: linux-arm-msm@vger.kernel.org, Linus Walleij , Liam Girdwood , Mark Brown , Vinod Koul , Rob Herring , Andy Gross , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, bhupesh.linux@gmail.com Subject: Re: [PATCH 7/8] arm64: dts: qcom: pmm8155au_2: Add base dts file Message-ID: References: <20210607113840.15435-1-bhupesh.sharma@linaro.org> <20210607113840.15435-8-bhupesh.sharma@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210607113840.15435-8-bhupesh.sharma@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon 07 Jun 06:38 CDT 2021, Bhupesh Sharma wrote: > Add base DTS file for pmm8155au_2 along with GPIOs, power-on, rtc and vadc > nodes. > > Cc: Linus Walleij > Cc: Liam Girdwood > Cc: Mark Brown > Cc: Bjorn Andersson > Cc: Vinod Koul > Cc: Rob Herring > Cc: Andy Gross > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-gpio@vger.kernel.org > Cc: bhupesh.linux@gmail.com > Signed-off-by: Bhupesh Sharma > --- > arch/arm64/boot/dts/qcom/pmm8155au_2.dtsi | 107 ++++++++++++++++++++++ > 1 file changed, 107 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/pmm8155au_2.dtsi > > diff --git a/arch/arm64/boot/dts/qcom/pmm8155au_2.dtsi b/arch/arm64/boot/dts/qcom/pmm8155au_2.dtsi As with _1, I approve of this design. > new file mode 100644 > index 000000000000..11c0c203a4e2 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/pmm8155au_2.dtsi > @@ -0,0 +1,107 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2021, Linaro Limited > + */ > + > +#include > +#include > +#include > + > +/ { > + thermal-zones { > + pmm8155au-2-thermal { > + polling-delay-passive = <100>; > + polling-delay = <0>; > + > + thermal-sensors = <&pmm8155au_2_temp>; > + > + trips { > + trip0 { > + temperature = <95000>; > + hysteresis = <0>; > + type = "passive"; > + }; > + > + trip1 { > + temperature = <115000>; > + hysteresis = <0>; > + type = "hot"; > + }; > + > + trip2 { > + temperature = <145000>; > + hysteresis = <0>; > + type = "critical"; > + }; > + }; > + }; > + }; > +}; > + > +&spmi_bus { > + pmic@4 { > + compatible = "qcom,pmm8155au-2", "qcom,spmi-pmic"; "qcom,pmm8155au", "qcom,spmi-pmic" > + reg = <0x4 SPMI_USID>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + power-on@800 { > + compatible = "qcom,pm8916-pon"; > + reg = <0x0800>; > + > + status = "disabled"; > + }; > + > + pmm8155au_2_temp: temp-alarm@2400 { > + compatible = "qcom,spmi-temp-alarm"; > + reg = <0x2400>; > + interrupts = <0x4 0x24 0x0 IRQ_TYPE_EDGE_BOTH>; > + io-channels = <&pmm8155au_2_adc ADC5_DIE_TEMP>; > + io-channel-names = "thermal"; > + #thermal-sensor-cells = <0>; > + }; > + > + pmm8155au_2_adc: adc@3100 { > + compatible = "qcom,spmi-adc5"; > + reg = <0x3100>; > + #address-cells = <1>; > + #size-cells = <0>; > + #io-channel-cells = <1>; > + interrupts = <0x4 0x31 0x0 IRQ_TYPE_EDGE_RISING>; > + > + ref-gnd@0 { > + reg = ; > + qcom,pre-scaling = <1 1>; > + label = "ref_gnd"; > + }; > + > + vref-1p25@1 { > + reg = ; > + qcom,pre-scaling = <1 1>; > + label = "vref_1p25"; > + }; > + > + die-temp@6 { > + reg = ; > + qcom,pre-scaling = <1 1>; > + label = "die_temp"; > + }; > + }; > + > + pmm8155au_2_gpios: gpio@c000 { > + compatible = "qcom,pmm8155au-2-gpio"; "qcom,pmm8155-gpio" > + reg = <0xc000>; > + gpio-controller; > + #gpio-cells = <2>; > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + }; > + > + pmic@5 { > + compatible = "qcom,pmm8155au-2", "qcom,spmi-pmic"; "qcom,pmm8155au", "qcom,spmi-pmic" Regards, Bjorn > + reg = <0x5 SPMI_USID>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > +}; > -- > 2.31.1 >