From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3B95C48BCF for ; Sun, 13 Jun 2021 04:22:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4DD3611CC for ; Sun, 13 Jun 2021 04:22:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231444AbhFMEYY (ORCPT ); Sun, 13 Jun 2021 00:24:24 -0400 Received: from mail-oi1-f171.google.com ([209.85.167.171]:44992 "EHLO mail-oi1-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229939AbhFMEYX (ORCPT ); Sun, 13 Jun 2021 00:24:23 -0400 Received: by mail-oi1-f171.google.com with SMTP id a26so10550880oie.11 for ; Sat, 12 Jun 2021 21:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8YqT4iQ5ARuAsr6gtIHiKsiWycjnAEstDWdPEQ2s7Oo=; b=SzK65P0jNbO87tAuQU+tnH5HoSu25WKpV5S4ECBy4n4OUq7OkU4RUkEn2S9I8tpLe0 UWUHYqjE1iPLFwpK6asKcuVwZcudPJj8tYRYtZbvQrDSGgxc6RGKH8fQq0g9NhIu23S8 McOnAJ5fK4be9oGgD1gbPnDMP9nVxMbxDlULrHNEJPoDZ68LjjdNx2rsEoWgfVfYP9xk 3bNDzl4Qqw6M0tRhB9xSflSQ8UUVXWIGsU1bfP1yyDr3U+vQrZ0xhQ86orbkid2nIL/j 2KfA+jnMvihI34zfIcZsc9mJ0+BPfuGF+0yNupOR9DWyFlWnXtxHSaU1J7oahd9rOcM9 UAcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8YqT4iQ5ARuAsr6gtIHiKsiWycjnAEstDWdPEQ2s7Oo=; b=oJ4pZvfHq7LGP/jgYbKLJklZGJ5aUjX49dw+OtPsyYgsAl6y+CWXARamsSF71uULjY U2lgdC+q3af2yDKgHzstgTcrbgY7fKc1oJARIoPe32X7KF6Z9DfAIK85t7Zc1IBk88Ip p3odopnT7jg6ngHdL9xVaj2QIJwLMMadeIoYADrSwyyOFdsXg+HWyV5zKnNmk/70P+VW 4sLVvRFvyjRP6PVp+c6xcb8TuKfrug3vB8jcgRwT8YaHGdLglvoZ4YDUe3C7Ky6Ln7zE FPnlTojoSpmZI+F0QdY0A1Vr8l8sqLkMha4PEUxN3s0zZwrjGdHSKFtYSZEPU6kIYjiB +2iA== X-Gm-Message-State: AOAM531Ujpf9qMH6Kk4p8j0C+XMTFpy+xR0ywyhWXuE37VygdDGFFKu/ n11T/aIZK5OhPsnKbTfkqZynEQ== X-Google-Smtp-Source: ABdhPJx39pPSqUGZ+2JLZGZIoy2K54tmZqpddydIlq0r84X5ZZ7EvZbLXRRnITnI5LKzKYzAIeqymg== X-Received: by 2002:aca:a9c3:: with SMTP id s186mr6856373oie.103.1623558082760; Sat, 12 Jun 2021 21:21:22 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id n186sm2110995oia.1.2021.06.12.21.21.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Jun 2021 21:21:22 -0700 (PDT) Date: Sat, 12 Jun 2021 23:21:20 -0500 From: Bjorn Andersson To: Caleb Connolly Cc: Andy Gross , Rob Herring , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] arm64: dts: qcom: pmi8998: introduce qpnp haptics Message-ID: References: <20210612205405.1233588-4-caleb@connolly.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210612205405.1233588-4-caleb@connolly.tech> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sat 12 Jun 15:54 CDT 2021, Caleb Connolly wrote: > Add bindings for Qualcomm QPNP haptics, setting default values used on > most devices. > > Signed-off-by: Caleb Connolly > --- > arch/arm64/boot/dts/qcom/pmi8998.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi > index d230c510d4b7..ccf64c1898d4 100644 > --- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi > +++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi > @@ -1,4 +1,5 @@ > // SPDX-License-Identifier: GPL-2.0 > +#include > #include > #include > > @@ -41,5 +42,20 @@ lab: lab { > interrupt-names = "sc-err", "ocp"; > }; > }; > + > + qpnp_haptics: qcom,haptics@c000 { No qcom, in node name, please. > + compatible = "qcom,qpnp-haptics"; > + reg = <0xc000 0x100>; #size-cells is <0>, so this means 2 addresses. Please drop the "length". Regards, Bjorn > + > + interrupts = <0x3 0xc0 0x0 IRQ_TYPE_EDGE_BOTH>, > + <0x3 0xc0 0x1 IRQ_TYPE_EDGE_BOTH>; > + interrupt-names = "short", "play"; > + > + qcom,wave-shape = ; > + qcom,play-mode = ; > + qcom,brake-pattern = <0x3 0x3 0x2 0x1>; > + > + status = "disabled"; > + }; > }; > }; > -- > 2.31.1 > >