From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB3E1C48BCF for ; Sun, 13 Jun 2021 04:23:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F81E611CC for ; Sun, 13 Jun 2021 04:23:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229870AbhFMEZo (ORCPT ); Sun, 13 Jun 2021 00:25:44 -0400 Received: from mail-ot1-f51.google.com ([209.85.210.51]:41716 "EHLO mail-ot1-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229664AbhFMEZn (ORCPT ); Sun, 13 Jun 2021 00:25:43 -0400 Received: by mail-ot1-f51.google.com with SMTP id p5-20020a9d45450000b029043ee61dce6bso337276oti.8 for ; Sat, 12 Jun 2021 21:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FIZzF+vNdvW8c/xyt8LCztOh3ZfjKKS6HpmIg9OM5VY=; b=rvY1xartR0XzuC5JdSjapKuTtUvr/7VGuU161r7PTcuvr+HypOPsCoYN09MrI6csfx k4j/ApxxkJFRgOgkD7JFv70jie+0DVwUD0UyppFZrJaGFJsi8LbCF5OuFvJ+yp9//VNC Rg5wDKLA4qR1I4dFQdyGiitmAaIvN76W79EYpcXDQtwAGcC199yHcXdmlCA+iNQViC6B n2ZDwYsH+0hWd/xAEPx+uoAZsOZ0KMI8PXfh3+x+C5SyOnxJg3gUYEgVCywQ9hPG/2by bqB1uBi6Y7AyqMJjB8Yx1zFr81PaiaqD5Kpf+oGHmqYQoGOS0lSIGFRVWLwnhseauKtu f3Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FIZzF+vNdvW8c/xyt8LCztOh3ZfjKKS6HpmIg9OM5VY=; b=XVYq02JXH7rizcVAQmPOM1Y5/BqlcG8B7RlKUPDc4IhNsILfrMF008bmnGVhdI/1Xb vgyEhviVRyM/SCSL4+YKG96Fuzza4MeQe0a+0wqRWokJOkuhdwde0fQKE7/rK8fKoH4f srxq+7msFL6bWuw66kgixsr5PAzlWBCfudUDcGFfqVmyhcDoKgG0j7iVpfyHqIxaeZH5 8Ze3ToD3TJPLMDdYazM/gkSLSkdWp1Rl6jjYt0zaiKbzKlRSU5TkH6yMPmnm19bomdM1 FymNjeiJCiCFs2NSQ3DAIUBfGUpKikSIT0EH94PWyaUPpI+KzVCMaHqpCrg11SREQYsA cRNA== X-Gm-Message-State: AOAM530vIo0dh0pnZhM3YT45TrpEYvzrAuE9KEjCDudpmUV35GtccFxF 9u3JarGRuvn26U4UAp5u75pMHYF9IJjB3Q== X-Google-Smtp-Source: ABdhPJx0kCEOPhXvpn2xjNNrCqf5m6I1JDLPJKDrXVNK4ZZt0cNU+x3XzQgoqDWgMEA3tv+XeknKwA== X-Received: by 2002:a05:6830:1da4:: with SMTP id z4mr6169678oti.83.1623558146857; Sat, 12 Jun 2021 21:22:26 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id r2sm1423281otd.54.2021.06.12.21.22.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Jun 2021 21:22:26 -0700 (PDT) Date: Sat, 12 Jun 2021 23:22:24 -0500 From: Bjorn Andersson To: Caleb Connolly Cc: Andy Gross , Rob Herring , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] arm64: dts: qcom: pmi8998: introduce qpnp haptics Message-ID: References: <20210612205405.1233588-4-caleb@connolly.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210612205405.1233588-4-caleb@connolly.tech> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sat 12 Jun 15:54 CDT 2021, Caleb Connolly wrote: > Add bindings for Qualcomm QPNP haptics, setting default values used on > most devices. > > Signed-off-by: Caleb Connolly > --- > arch/arm64/boot/dts/qcom/pmi8998.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi > index d230c510d4b7..ccf64c1898d4 100644 > --- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi > +++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi > @@ -1,4 +1,5 @@ > // SPDX-License-Identifier: GPL-2.0 > +#include > #include > #include > > @@ -41,5 +42,20 @@ lab: lab { > interrupt-names = "sc-err", "ocp"; > }; > }; > + > + qpnp_haptics: qcom,haptics@c000 { Also, please label this pmi8998_haptics, to make it easier to find where it's defined when looking at the .dts. Thanks, Bjorn > + compatible = "qcom,qpnp-haptics"; > + reg = <0xc000 0x100>; > + > + interrupts = <0x3 0xc0 0x0 IRQ_TYPE_EDGE_BOTH>, > + <0x3 0xc0 0x1 IRQ_TYPE_EDGE_BOTH>; > + interrupt-names = "short", "play"; > + > + qcom,wave-shape = ; > + qcom,play-mode = ; > + qcom,brake-pattern = <0x3 0x3 0x2 0x1>; > + > + status = "disabled"; > + }; > }; > }; > -- > 2.31.1 > >