From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: mani@kernel.org, davem@davemloft.net,
linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+1917d778024161609247@syzkaller.appspotmail.com
Subject: Re: [PATCH] net: qrtr: fix OOB Read in qrtr_endpoint_post
Date: Mon, 14 Jun 2021 10:57:45 -0500 [thread overview]
Message-ID: <YMd8eb/yu1Ds4oVV@yoga> (raw)
In-Reply-To: <20210614120650.2731-1-paskripkin@gmail.com>
On Mon 14 Jun 07:06 CDT 2021, Pavel Skripkin wrote:
> Syzbot reported slab-out-of-bounds Read in
> qrtr_endpoint_post. The problem was in wrong
> _size_ type:
>
> if (len != ALIGN(size, 4) + hdrlen)
> goto err;
>
> If size from qrtr_hdr is 4294967293 (0xfffffffd), the result of
> ALIGN(size, 4) will be 0. In case of len == hdrlen and size == 4294967293
> in header this check won't fail and
>
> skb_put_data(skb, data + hdrlen, size);
>
> will read out of bound from data, which is hdrlen allocated block.
>
> Fixes: 194ccc88297a ("net: qrtr: Support decoding incoming v2 packets")
> Reported-and-tested-by: syzbot+1917d778024161609247@syzkaller.appspotmail.com
> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> net/qrtr/qrtr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c
> index c0477bec09bd..f2efaa4225f9 100644
> --- a/net/qrtr/qrtr.c
> +++ b/net/qrtr/qrtr.c
> @@ -436,7 +436,7 @@ int qrtr_endpoint_post(struct qrtr_endpoint *ep, const void *data, size_t len)
> struct qrtr_sock *ipc;
> struct sk_buff *skb;
> struct qrtr_cb *cb;
> - unsigned int size;
> + size_t size;
> unsigned int ver;
> size_t hdrlen;
>
> --
> 2.32.0
>
next prev parent reply other threads:[~2021-06-14 15:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 12:06 [PATCH] net: qrtr: fix OOB Read in qrtr_endpoint_post Pavel Skripkin
2021-06-14 15:57 ` Bjorn Andersson [this message]
2021-06-14 20:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMd8eb/yu1Ds4oVV@yoga \
--to=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paskripkin@gmail.com \
--cc=syzbot+1917d778024161609247@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).