From: Bjorn Andersson <bjorn.andersson@linaro.org> To: Bhupesh Sharma <bhupesh.sharma@linaro.org> Cc: linux-arm-msm@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>, devicetree <devicetree@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, bhupesh.linux@gmail.com Subject: Re: [PATCH 1/8] dt-bindings: qcom: rpmh-regulator: Add compatible for SA8155p-adp board pmics Date: Mon, 14 Jun 2021 11:28:41 -0500 [thread overview] Message-ID: <YMeDuToX+YG8CJEa@yoga> (raw) In-Reply-To: <CAH=2NtyV=qMn32d9nE7qBheTscUejF1UwVZSc99uiv_P65S03Q@mail.gmail.com> On Mon 14 Jun 03:05 CDT 2021, Bhupesh Sharma wrote: > Hello Bjorn, > > Thanks for the review comments. > > On Fri, 11 Jun 2021 at 08:18, Bjorn Andersson > <bjorn.andersson@linaro.org> wrote: > > > > On Mon 07 Jun 06:38 CDT 2021, Bhupesh Sharma wrote: > > > > > Add compatible strings for pmm8155au_1 and pmm8155au_2 pmics > > > found on SA8155p-adp board. > > > > > > Cc: Linus Walleij <linus.walleij@linaro.org> > > > Cc: Liam Girdwood <lgirdwood@gmail.com> > > > Cc: Mark Brown <broonie@kernel.org> > > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > > > Cc: Vinod Koul <vkoul@kernel.org> > > > Cc: Rob Herring <robh+dt@kernel.org> > > > Cc: Andy Gross <agross@kernel.org> > > > Cc: devicetree@vger.kernel.org > > > Cc: linux-kernel@vger.kernel.org > > > Cc: linux-gpio@vger.kernel.org > > > Cc: bhupesh.linux@gmail.com > > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > > --- > > > .../devicetree/bindings/regulator/qcom,rpmh-regulator.yaml | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml > > > index e561a5b941e4..ea5cd71aa0c7 100644 > > > --- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml > > > +++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml > > > @@ -55,6 +55,8 @@ properties: > > > - qcom,pm8009-1-rpmh-regulators > > > - qcom,pm8150-rpmh-regulators > > > - qcom,pm8150l-rpmh-regulators > > > + - qcom,pmm8155au-1-rpmh-regulators > > > + - qcom,pmm8155au-2-rpmh-regulators > > > > Looking at the component documentation and the schematics I think the > > component is "PMM8155AU" and we have two of them. > > > > Unless I'm mistaken we should have the compatible describe the single > > component and we should have DT describe the fact that we have 2 of > > them. > > If we refer to the PM8155AU device specifications, there are two > regulators mentioned there PMM8155AU_1 and PMM8155AU_2. Although most > parameters of the regulators seem similar the smps regulator summary > for both appear different (Transient Load, mA ratings etc). > > Although most of these differences don't probably matter to the Linux > world, others like the gpios on the pmic are different. > > So, IMO, it makes sense to mention the different pmic types on the board. > > Please let me know your views on the same. > Afaict, they are both physically the same component, but there is some configuration differences between them. I don't see any differences that will show up in Linux, but afaict we would capture those in the DT anyways. Let me know if you see anything I'm missing, but I think we should have a single compatible. Regards, Bjorn > Thanks, > Bhupesh > > > > > > - qcom,pm8350-rpmh-regulators > > > - qcom,pm8350c-rpmh-regulators > > > - qcom,pm8998-rpmh-regulators > > > -- > > > 2.31.1 > > >
next prev parent reply other threads:[~2021-06-14 16:29 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-07 11:38 [PATCH 0/8] arm64: dts: qcom: Add SA8155p-adp board DTS Bhupesh Sharma 2021-06-07 11:38 ` [PATCH 1/8] dt-bindings: qcom: rpmh-regulator: Add compatible for SA8155p-adp board pmics Bhupesh Sharma 2021-06-11 2:48 ` Bjorn Andersson 2021-06-14 8:05 ` Bhupesh Sharma 2021-06-14 16:28 ` Bjorn Andersson [this message] 2021-06-15 4:43 ` Bhupesh Sharma 2021-06-07 11:38 ` [PATCH 2/8] dt-bindings: pinctrl: qcom,pmic-gpio: Add compatible for SA8155p-adp Bhupesh Sharma 2021-06-11 2:51 ` Bjorn Andersson 2021-06-14 8:13 ` Bhupesh Sharma 2021-06-14 16:09 ` Bjorn Andersson 2021-06-07 11:38 ` [PATCH 3/8] dt-bindings: arm: qcom: Add compatible for SA8155p-adp board Bhupesh Sharma 2021-06-11 2:59 ` Bjorn Andersson 2021-06-14 8:14 ` Bhupesh Sharma 2021-06-07 11:38 ` [PATCH 4/8] regulator: qcom-rpmh: Add new regulator types found on SA8155p adp board Bhupesh Sharma 2021-06-07 12:09 ` Andy Shevchenko 2021-06-07 12:30 ` Bhupesh Sharma 2021-06-14 16:17 ` Bjorn Andersson 2021-06-15 4:47 ` Bhupesh Sharma 2021-06-07 11:38 ` [PATCH 5/8] pinctrl: qcom/pinctrl-spmi-gpio: Add compatibles for pmic-gpios on SA8155p-adp Bhupesh Sharma 2021-06-11 3:00 ` Bjorn Andersson 2021-06-14 8:30 ` Bhupesh Sharma 2021-06-14 16:12 ` Bjorn Andersson 2021-06-07 11:38 ` [PATCH 6/8] arm64: dts: qcom: pmm8155au_1: Add base dts file Bhupesh Sharma 2021-06-11 3:12 ` Bjorn Andersson 2021-06-07 11:38 ` [PATCH 7/8] arm64: dts: qcom: pmm8155au_2: " Bhupesh Sharma 2021-06-11 3:13 ` Bjorn Andersson 2021-06-07 11:38 ` [PATCH 8/8] arm64: dts: qcom: sa8155p-adp: " Bhupesh Sharma 2021-06-07 15:22 ` Vinod Koul 2021-06-07 21:22 ` Bhupesh Sharma 2021-06-11 2:25 ` Bjorn Andersson 2021-06-14 8:19 ` Bhupesh Sharma 2021-06-15 4:41 ` Bhupesh Sharma
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YMeDuToX+YG8CJEa@yoga \ --to=bjorn.andersson@linaro.org \ --cc=agross@kernel.org \ --cc=bhupesh.linux@gmail.com \ --cc=bhupesh.sharma@linaro.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=lgirdwood@gmail.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=vkoul@kernel.org \ --subject='Re: [PATCH 1/8] dt-bindings: qcom: rpmh-regulator: Add compatible for SA8155p-adp board pmics' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).