From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98229C48BDF for ; Tue, 15 Jun 2021 21:10:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 733B0613CC for ; Tue, 15 Jun 2021 21:10:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231444AbhFOVMw (ORCPT ); Tue, 15 Jun 2021 17:12:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231357AbhFOVMv (ORCPT ); Tue, 15 Jun 2021 17:12:51 -0400 Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96656C061767 for ; Tue, 15 Jun 2021 14:10:45 -0700 (PDT) Received: by mail-ot1-x32c.google.com with SMTP id 102-20020a9d0eef0000b02903fccc5b733fso313531otj.4 for ; Tue, 15 Jun 2021 14:10:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WkzhRbVFIgsr0heAbxBvDzw6jHRgA2esFwM/DKd3EyE=; b=GLpKQJWLyWxKu2kjdrJ+K+in8MCFzZblnO/mxP7t2GLlZXhJdW3eG/1O5YQaXc3mC2 GzmJhKAafAi+2YHGqDk01Et0j+5+5jfC09ug+GYfUw1Ggs2LBp+i/2n2/YpDn+HLChb6 dsz8pjtmqof8o1sl8NIEPc9xs57FrXLQpXM7DR29JjtHQTfJeULCpjb6Pfcbr4OVjxIg HFSsykxl6d2bKhF7kKuEqxSt/jqxpKDj64wFAUREZ1UTU4mbcwQd2/LAN2UQVm4SSBsy AcHfTr4GQr4o+8a8GuIN0ZqUagviRykROQfFhhIZugrb3bmvpf/cHdqiYqwf4zSy8xSr J4Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WkzhRbVFIgsr0heAbxBvDzw6jHRgA2esFwM/DKd3EyE=; b=IcE6u+AfJj17zEWDiHcLZgrVim1fWxFFQvlA9rg6+Vjbez3KeV7PVvdl1pBWJUEUpW YENj2y5mK10F4Ng944v1bP8+AK6cClpdIHzhnXEBU2waZpPW7g8hZf/ItORsDMNYXNcr JHSs8wqAqdf6othlOz0U5YhdiHv3y9pDt6a5s8G2+MZ47l7VjTxvJdncg/u8lLpW77d2 a49P3Pu46HnMdcIMTv/NaA7QEM7wdMlooh4zw+Xk7PEvsrZ7ST4hdCf6U/lslEf88gd6 5rWDsR0FE4Tn0JXgJkgASHrwbpIlmn4Qd7gEIvhgKup02hehGjNXavJ3utgsPhxNi9An 2g1Q== X-Gm-Message-State: AOAM533ol6pnSNxf7436hZ76lD60D+KjgEkKYJgDch6GHHgSjPhEqej4 GS42tEJksgh3pkzRK0bFePcIYQ== X-Google-Smtp-Source: ABdhPJw7qeXG/5lTImKm0KdNyRK03SnhL5SAOJK8UevYph48QoAUeoEgbSLe19hRV48oZu268cPfig== X-Received: by 2002:a9d:6f93:: with SMTP id h19mr972789otq.100.1623791444974; Tue, 15 Jun 2021 14:10:44 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id w17sm8002oif.44.2021.06.15.14.10.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 14:10:44 -0700 (PDT) Date: Tue, 15 Jun 2021 16:10:42 -0500 From: Bjorn Andersson To: Bhupesh Sharma Cc: linux-arm-msm@vger.kernel.org, bhupesh.linux@gmail.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Linus Walleij , Liam Girdwood , Mark Brown , Vinod Koul , Rob Herring , Andy Gross Subject: Re: [PATCH v2 06/10] regulator: qcom-rpmh: Add new regulator found on SA8155p adp board Message-ID: References: <20210615074543.26700-1-bhupesh.sharma@linaro.org> <20210615074543.26700-7-bhupesh.sharma@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210615074543.26700-7-bhupesh.sharma@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue 15 Jun 02:45 CDT 2021, Bhupesh Sharma wrote: > SA8155p-adp board supports a new regulator - pmm8155au. > > The output power management circuits in this regulator include: > - FTS510 smps, > - HFS510 smps, and > - LDO510 linear regulators > > Add support for the same. > > Cc: Linus Walleij > Cc: Liam Girdwood > Cc: Mark Brown > Cc: Bjorn Andersson > Cc: Vinod Koul > Cc: Rob Herring > Cc: Andy Gross > Signed-off-by: Bhupesh Sharma Not sure if I should interpret Mark's comment in the way that he already picked this patch up. > --- > drivers/regulator/qcom-rpmh-regulator.c | 36 +++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c > index af41a517da99..73623d51929b 100644 > --- a/drivers/regulator/qcom-rpmh-regulator.c > +++ b/drivers/regulator/qcom-rpmh-regulator.c > @@ -883,6 +883,38 @@ static const struct rpmh_vreg_init_data pm8150l_vreg_data[] = { > {} > }; > > +static const struct rpmh_vreg_init_data pmm8155au_vreg_data[] = { > + RPMH_VREG("smps1", "smp%s1", &pmic5_ftsmps510, "vdd-s1"), > + RPMH_VREG("smps2", "smp%s2", &pmic5_ftsmps510, "vdd-s2"), > + RPMH_VREG("smps3", "smp%s3", &pmic5_ftsmps510, "vdd-s3"), > + RPMH_VREG("smps4", "smp%s4", &pmic5_hfsmps510, "vdd-s4"), > + RPMH_VREG("smps5", "smp%s5", &pmic5_hfsmps510, "vdd-s5"), > + RPMH_VREG("smps6", "smp%s6", &pmic5_ftsmps510, "vdd-s6"), > + RPMH_VREG("smps7", "smp%s7", &pmic5_ftsmps510, "vdd-s7"), > + RPMH_VREG("smps8", "smp%s8", &pmic5_ftsmps510, "vdd-s8"), > + RPMH_VREG("smps9", "smp%s9", &pmic5_ftsmps510, "vdd-s9"), > + RPMH_VREG("smps10", "smp%s10", &pmic5_ftsmps510, "vdd-s10"), > + RPMH_VREG("ldo1", "ldo%s1", &pmic5_nldo, "vdd-l1-l8-l11"), > + RPMH_VREG("ldo2", "ldo%s2", &pmic5_pldo, "vdd-l2-l10"), > + RPMH_VREG("ldo3", "ldo%s3", &pmic5_nldo, "vdd-l3-l4-l5-l18"), > + RPMH_VREG("ldo4", "ldo%s4", &pmic5_nldo, "vdd-l3-l4-l5-l18"), > + RPMH_VREG("ldo5", "ldo%s5", &pmic5_nldo, "vdd-l3-l4-l5-l18"), > + RPMH_VREG("ldo6", "ldo%s6", &pmic5_nldo, "vdd-l6-l9"), > + RPMH_VREG("ldo7", "ldo%s7", &pmic5_pldo_lv, "vdd-l7-l12-l14-l15"), > + RPMH_VREG("ldo8", "ldo%s8", &pmic5_nldo, "vdd-l1-l8-l11"), > + RPMH_VREG("ldo9", "ldo%s9", &pmic5_nldo, "vdd-l6-l9"), > + RPMH_VREG("ldo10", "ldo%s10", &pmic5_pldo, "vdd-l2-l10"), > + RPMH_VREG("ldo11", "ldo%s11", &pmic5_nldo, "vdd-l1-l8-l11"), > + RPMH_VREG("ldo12", "ldo%s12", &pmic5_pldo_lv, "vdd-l7-l12-l14-l15"), > + RPMH_VREG("ldo13", "ldo%s13", &pmic5_pldo, "vdd-l13-l16-l17"), > + RPMH_VREG("ldo14", "ldo%s14", &pmic5_pldo_lv, "vdd-l7-l12-l14-l15"), > + RPMH_VREG("ldo15", "ldo%s15", &pmic5_pldo_lv, "vdd-l7-l12-l14-l15"), > + RPMH_VREG("ldo16", "ldo%s16", &pmic5_pldo, "vdd-l13-l16-l17"), > + RPMH_VREG("ldo17", "ldo%s17", &pmic5_pldo, "vdd-l13-l16-l17"), > + RPMH_VREG("ldo18", "ldo%s18", &pmic5_nldo, "vdd-l3-l4-l5-l18"), > + {} > +}; > + > static const struct rpmh_vreg_init_data pm8350_vreg_data[] = { > RPMH_VREG("smps1", "smp%s1", &pmic5_ftsmps510, "vdd-s1"), > RPMH_VREG("smps2", "smp%s2", &pmic5_ftsmps510, "vdd-s2"), > @@ -1145,6 +1177,10 @@ static const struct of_device_id __maybe_unused rpmh_regulator_match_table[] = { > .compatible = "qcom,pm8150l-rpmh-regulators", > .data = pm8150l_vreg_data, > }, > + { > + .compatible = "qcom,pmm8155au-rpmh-regulators", It would be preferable if this was sorted alphabetically (on the compatible). With that, Reviewed-by: Bjorn Andersson Regards, Bjorn > + .data = pmm8155au_vreg_data, > + }, > { > .compatible = "qcom,pm8350-rpmh-regulators", > .data = pm8350_vreg_data, > -- > 2.31.1 >