From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: sbhanu@codeaurora.org
Cc: adrian.hunter@intel.com, ulf.hansson@linaro.org,
robh+dt@kernel.org, asutoshd@codeaurora.org,
stummala@codeaurora.org, vbadigan@codeaurora.org,
rampraka@codeaurora.org, sayalil@codeaurora.org,
sartgarg@codeaurora.org, rnayak@codeaurora.org,
saiprakash.ranjan@codeaurora.org, sibis@codeaurora.org,
okukatla@codeaurora.org, djakov@kernel.org, cang@codeaurora.org,
pragalla@codeaurora.org, nitirawa@codeaurora.org,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
agross@kernel.org
Subject: Re: [PATCH V3] arm64: dts: qcom: sc7280: Add nodes for eMMC and SD card
Date: Tue, 15 Jun 2021 19:08:37 -0500 [thread overview]
Message-ID: <YMlBBeT1VK5snsM7@builder.lan> (raw)
In-Reply-To: <0ce40daf1f8146f47b1877fb2c83cd95@codeaurora.org>
On Tue 15 Jun 03:56 CDT 2021, sbhanu@codeaurora.org wrote:
> On 2021-06-14 17:00, sbhanu@codeaurora.org wrote:
> > On 2021-06-11 09:12, Bjorn Andersson wrote:
> > > On Wed 09 Jun 10:20 CDT 2021, Shaik Sajida Bhanu wrote:
[..]
> > > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
[..]
> > > > + sdhc_1: sdhci@7c4000 {
[..]
> > > > + sdhc1_opp_table: sdhc1-opp-table {
> > >
> > > No need for "sdhc1-" in the node name.
> > ok
> Hi,
>
> For Sd card also we have opp-table info so if we remove "sdhc1-" here and
> "sdhc2-" in Sd crad opp table we may have dublicate nodes so,
> it is better to keep sdhc1 and sdhc2 in node numbers right.
>
Are you saying that /soc/sdhci@7c4000/opp-table needs to have a unique
name to not collide with /soc/sdhci@8804000/opp-table?
Regards,
Bjorn
next prev parent reply other threads:[~2021-06-16 0:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 15:20 [PATCH V3] arm64: dts: qcom: sc7280: Add nodes for eMMC and SD card Shaik Sajida Bhanu
2021-06-09 20:45 ` Konrad Dybcio
2021-06-14 11:25 ` sbhanu
2021-06-11 3:42 ` Bjorn Andersson
2021-06-14 11:30 ` sbhanu
2021-06-15 8:56 ` sbhanu
2021-06-16 0:08 ` Bjorn Andersson [this message]
2021-06-16 5:54 ` sbhanu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMlBBeT1VK5snsM7@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=agross@kernel.org \
--cc=asutoshd@codeaurora.org \
--cc=cang@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nitirawa@codeaurora.org \
--cc=okukatla@codeaurora.org \
--cc=pragalla@codeaurora.org \
--cc=rampraka@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=sartgarg@codeaurora.org \
--cc=sayalil@codeaurora.org \
--cc=sbhanu@codeaurora.org \
--cc=sibis@codeaurora.org \
--cc=stummala@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=vbadigan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).