[PATCH 00/10] Rid W=1 warnings from Bus

[PATCH 00/10] Rid W=1 warnings from Bus

[Lee Jones]

This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.

Lee Jones (10):
  bus: fsl-mc: mc-io: Supply function names for 'fsl_create_mc_io()' and
    'fsl_destroy_mc_io()'
  bus: fsl-mc: mc-sys: Supply missing function names in kernel-doc
    headers
  bus: fsl-mc: fsl-mc-bus: Demote a bunch of non-conformant kernel-doc
    headers and help others
  bus: fsl-mc: dprc: Fix a couple of misspelling and formatting issues
  bus: fsl-mc: dprc-driver: Fix some missing/incorrect function
    parameter descriptions
  bus: fsl-mc: fsl-mc-allocator: Fix misspelling of 'new_mc_adev' and
    demote non-kernel-doc headers
  bus: qcom-ebi2: Fix incorrect documentation for '{slow,fast}_cfg'
  bus: fsl-mc-msi: Fix a little doc-rot pertaining to 'np' to 'fwnode'
    conversion
  bus: ti-sysc: Correct misdocumentation of 'sysc_ioremap()'
  bus: fsl-mc: mc-io: Correct misdocumentation of 'dpmcp_dev' param

 drivers/bus/fsl-mc/dprc-driver.c      |  8 +++++---
 drivers/bus/fsl-mc/dprc.c             |  4 ++--
 drivers/bus/fsl-mc/fsl-mc-allocator.c | 10 +++++-----
 drivers/bus/fsl-mc/fsl-mc-bus.c       | 19 ++++++++++---------
 drivers/bus/fsl-mc/fsl-mc-msi.c       |  2 +-
 drivers/bus/fsl-mc/mc-io.c            |  6 +++---
 drivers/bus/fsl-mc/mc-sys.c           | 19 ++++++++++---------
 drivers/bus/qcom-ebi2.c               |  4 ++--
 drivers/bus/ti-sysc.c                 |  2 +-
 9 files changed, 39 insertions(+), 35 deletions(-)

Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: German Rivera <German.Rivera@freescale.com>
Cc: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-omap@vger.kernel.org
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Stuart Yoder <stuyoder@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>
-- 
2.31.1

[PATCH 07/10] bus: qcom-ebi2: Fix incorrect documentation for '{slow,fast}_cfg'

[Lee Jones]

Fixes the following W=1 kernel build warning(s):

 drivers/bus/qcom-ebi2.c:112: warning: Function parameter or member 'slow_cfg' not described in 'cs_data'
 drivers/bus/qcom-ebi2.c:112: warning: Function parameter or member 'fast_cfg' not described in 'cs_data'

Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-msm@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/bus/qcom-ebi2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/qcom-ebi2.c b/drivers/bus/qcom-ebi2.c
index 0b8f53a688b8a..663c827492223 100644
--- a/drivers/bus/qcom-ebi2.c
+++ b/drivers/bus/qcom-ebi2.c
@@ -102,8 +102,8 @@
 /**
  * struct cs_data - struct with info on a chipselect setting
  * @enable_mask: mask to enable the chipselect in the EBI2 config
- * @slow_cfg0: offset to XMEMC slow CS config
- * @fast_cfg1: offset to XMEMC fast CS config
+ * @slow_cfg: offset to XMEMC slow CS config
+ * @fast_cfg: offset to XMEMC fast CS config
  */
 struct cs_data {
 	u32 enable_mask;
-- 
2.31.1

Re: [PATCH 07/10] bus: qcom-ebi2: Fix incorrect documentation for '{slow,fast}_cfg'

[Linus Walleij]

On Wed, May 26, 2021 at 10:10 AM Lee Jones <lee.jones@linaro.org> wrote:

> Fixes the following W=1 kernel build warning(s):
>
>  drivers/bus/qcom-ebi2.c:112: warning: Function parameter or member 'slow_cfg' not described in 'cs_data'
>  drivers/bus/qcom-ebi2.c:112: warning: Function parameter or member 'fast_cfg' not described in 'cs_data'
>
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-arm-msm@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org

Thanks Lee!

Yours,
Linus Walleij

Re: [PATCH 07/10] bus: qcom-ebi2: Fix incorrect documentation for '{slow,fast}_cfg'

[Bjorn Andersson]

On Wed 26 May 03:10 CDT 2021, Lee Jones wrote:

> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/bus/qcom-ebi2.c:112: warning: Function parameter or member 'slow_cfg' not described in 'cs_data'
>  drivers/bus/qcom-ebi2.c:112: warning: Function parameter or member 'fast_cfg' not described in 'cs_data'
> 
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-arm-msm@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Thanks Lee, I've picked this up in the qcom tree.

Regards,
Bjorn

> ---
>  drivers/bus/qcom-ebi2.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/bus/qcom-ebi2.c b/drivers/bus/qcom-ebi2.c
> index 0b8f53a688b8a..663c827492223 100644
> --- a/drivers/bus/qcom-ebi2.c
> +++ b/drivers/bus/qcom-ebi2.c
> @@ -102,8 +102,8 @@
>  /**
>   * struct cs_data - struct with info on a chipselect setting
>   * @enable_mask: mask to enable the chipselect in the EBI2 config
> - * @slow_cfg0: offset to XMEMC slow CS config
> - * @fast_cfg1: offset to XMEMC fast CS config
> + * @slow_cfg: offset to XMEMC slow CS config
> + * @fast_cfg: offset to XMEMC fast CS config
>   */
>  struct cs_data {
>  	u32 enable_mask;
> -- 
> 2.31.1
> 

Re: [PATCH 00/10] Rid W=1 warnings from Bus

[Laurentiu Tudor]

Hi Lee,

On 5/26/2021 11:10 AM, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
> 
> Lee Jones (10):
>   bus: fsl-mc: mc-io: Supply function names for 'fsl_create_mc_io()' and
>     'fsl_destroy_mc_io()'
>   bus: fsl-mc: mc-sys: Supply missing function names in kernel-doc
>     headers
>   bus: fsl-mc: fsl-mc-bus: Demote a bunch of non-conformant kernel-doc
>     headers and help others
>   bus: fsl-mc: dprc: Fix a couple of misspelling and formatting issues
>   bus: fsl-mc: dprc-driver: Fix some missing/incorrect function
>     parameter descriptions
>   bus: fsl-mc: fsl-mc-allocator: Fix misspelling of 'new_mc_adev' and
>     demote non-kernel-doc headers
>   bus: qcom-ebi2: Fix incorrect documentation for '{slow,fast}_cfg'
>   bus: fsl-mc-msi: Fix a little doc-rot pertaining to 'np' to 'fwnode'
>     conversion
>   bus: ti-sysc: Correct misdocumentation of 'sysc_ioremap()'
>   bus: fsl-mc: mc-io: Correct misdocumentation of 'dpmcp_dev' param
> 
>  drivers/bus/fsl-mc/dprc-driver.c      |  8 +++++---
>  drivers/bus/fsl-mc/dprc.c             |  4 ++--
>  drivers/bus/fsl-mc/fsl-mc-allocator.c | 10 +++++-----
>  drivers/bus/fsl-mc/fsl-mc-bus.c       | 19 ++++++++++---------
>  drivers/bus/fsl-mc/fsl-mc-msi.c       |  2 +-
>  drivers/bus/fsl-mc/mc-io.c            |  6 +++---
>  drivers/bus/fsl-mc/mc-sys.c           | 19 ++++++++++---------

Thanks for this. For drivers/bus/fsl-mc/*:

Reviewed-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>

---
Best Regards, Laurentiu

Re: [PATCH 00/10] Rid W=1 warnings from Bus

[Lee Jones]

On Wed, 26 May 2021, Laurentiu Tudor wrote:

> Hi Lee,
> 
> On 5/26/2021 11:10 AM, Lee Jones wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> > 
> > Lee Jones (10):
> >   bus: fsl-mc: mc-io: Supply function names for 'fsl_create_mc_io()' and
> >     'fsl_destroy_mc_io()'
> >   bus: fsl-mc: mc-sys: Supply missing function names in kernel-doc
> >     headers
> >   bus: fsl-mc: fsl-mc-bus: Demote a bunch of non-conformant kernel-doc
> >     headers and help others
> >   bus: fsl-mc: dprc: Fix a couple of misspelling and formatting issues
> >   bus: fsl-mc: dprc-driver: Fix some missing/incorrect function
> >     parameter descriptions
> >   bus: fsl-mc: fsl-mc-allocator: Fix misspelling of 'new_mc_adev' and
> >     demote non-kernel-doc headers
> >   bus: qcom-ebi2: Fix incorrect documentation for '{slow,fast}_cfg'
> >   bus: fsl-mc-msi: Fix a little doc-rot pertaining to 'np' to 'fwnode'
> >     conversion
> >   bus: ti-sysc: Correct misdocumentation of 'sysc_ioremap()'
> >   bus: fsl-mc: mc-io: Correct misdocumentation of 'dpmcp_dev' param
> > 
> >  drivers/bus/fsl-mc/dprc-driver.c      |  8 +++++---
> >  drivers/bus/fsl-mc/dprc.c             |  4 ++--
> >  drivers/bus/fsl-mc/fsl-mc-allocator.c | 10 +++++-----
> >  drivers/bus/fsl-mc/fsl-mc-bus.c       | 19 ++++++++++---------
> >  drivers/bus/fsl-mc/fsl-mc-msi.c       |  2 +-
> >  drivers/bus/fsl-mc/mc-io.c            |  6 +++---
> >  drivers/bus/fsl-mc/mc-sys.c           | 19 ++++++++++---------
> 
> Thanks for this. For drivers/bus/fsl-mc/*:
> 
> Reviewed-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>

Any idea who will take the 'fsl-mc' patches please?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 00/10] Rid W=1 warnings from Bus

[Laurentiu Tudor]

On 6/17/2021 12:49 PM, Lee Jones wrote:
> On Wed, 26 May 2021, Laurentiu Tudor wrote:
> 
>> Hi Lee,
>>
>> On 5/26/2021 11:10 AM, Lee Jones wrote:
>>> This set is part of a larger effort attempting to clean-up W=1
>>> kernel builds, which are currently overwhelmingly riddled with
>>> niggly little warnings.
>>>
>>> Lee Jones (10):
>>>   bus: fsl-mc: mc-io: Supply function names for 'fsl_create_mc_io()' and
>>>     'fsl_destroy_mc_io()'
>>>   bus: fsl-mc: mc-sys: Supply missing function names in kernel-doc
>>>     headers
>>>   bus: fsl-mc: fsl-mc-bus: Demote a bunch of non-conformant kernel-doc
>>>     headers and help others
>>>   bus: fsl-mc: dprc: Fix a couple of misspelling and formatting issues
>>>   bus: fsl-mc: dprc-driver: Fix some missing/incorrect function
>>>     parameter descriptions
>>>   bus: fsl-mc: fsl-mc-allocator: Fix misspelling of 'new_mc_adev' and
>>>     demote non-kernel-doc headers
>>>   bus: qcom-ebi2: Fix incorrect documentation for '{slow,fast}_cfg'
>>>   bus: fsl-mc-msi: Fix a little doc-rot pertaining to 'np' to 'fwnode'
>>>     conversion
>>>   bus: ti-sysc: Correct misdocumentation of 'sysc_ioremap()'
>>>   bus: fsl-mc: mc-io: Correct misdocumentation of 'dpmcp_dev' param
>>>
>>>  drivers/bus/fsl-mc/dprc-driver.c      |  8 +++++---
>>>  drivers/bus/fsl-mc/dprc.c             |  4 ++--
>>>  drivers/bus/fsl-mc/fsl-mc-allocator.c | 10 +++++-----
>>>  drivers/bus/fsl-mc/fsl-mc-bus.c       | 19 ++++++++++---------
>>>  drivers/bus/fsl-mc/fsl-mc-msi.c       |  2 +-
>>>  drivers/bus/fsl-mc/mc-io.c            |  6 +++---
>>>  drivers/bus/fsl-mc/mc-sys.c           | 19 ++++++++++---------
>>
>> Thanks for this. For drivers/bus/fsl-mc/*:
>>
>> Reviewed-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> 
> Any idea who will take the 'fsl-mc' patches please?
> 

Usually GregKH (added in the thread) picks them up through his char-misc
tree.

---
Best Regards, Laurentiu

Re: [PATCH 00/10] Rid W=1 warnings from Bus

[Greg KH]

On Thu, Jun 17, 2021 at 01:11:39PM +0300, Laurentiu Tudor wrote:
> 
> 
> On 6/17/2021 12:49 PM, Lee Jones wrote:
> > On Wed, 26 May 2021, Laurentiu Tudor wrote:
> > 
> >> Hi Lee,
> >>
> >> On 5/26/2021 11:10 AM, Lee Jones wrote:
> >>> This set is part of a larger effort attempting to clean-up W=1
> >>> kernel builds, which are currently overwhelmingly riddled with
> >>> niggly little warnings.
> >>>
> >>> Lee Jones (10):
> >>>   bus: fsl-mc: mc-io: Supply function names for 'fsl_create_mc_io()' and
> >>>     'fsl_destroy_mc_io()'
> >>>   bus: fsl-mc: mc-sys: Supply missing function names in kernel-doc
> >>>     headers
> >>>   bus: fsl-mc: fsl-mc-bus: Demote a bunch of non-conformant kernel-doc
> >>>     headers and help others
> >>>   bus: fsl-mc: dprc: Fix a couple of misspelling and formatting issues
> >>>   bus: fsl-mc: dprc-driver: Fix some missing/incorrect function
> >>>     parameter descriptions
> >>>   bus: fsl-mc: fsl-mc-allocator: Fix misspelling of 'new_mc_adev' and
> >>>     demote non-kernel-doc headers
> >>>   bus: qcom-ebi2: Fix incorrect documentation for '{slow,fast}_cfg'
> >>>   bus: fsl-mc-msi: Fix a little doc-rot pertaining to 'np' to 'fwnode'
> >>>     conversion
> >>>   bus: ti-sysc: Correct misdocumentation of 'sysc_ioremap()'
> >>>   bus: fsl-mc: mc-io: Correct misdocumentation of 'dpmcp_dev' param
> >>>
> >>>  drivers/bus/fsl-mc/dprc-driver.c      |  8 +++++---
> >>>  drivers/bus/fsl-mc/dprc.c             |  4 ++--
> >>>  drivers/bus/fsl-mc/fsl-mc-allocator.c | 10 +++++-----
> >>>  drivers/bus/fsl-mc/fsl-mc-bus.c       | 19 ++++++++++---------
> >>>  drivers/bus/fsl-mc/fsl-mc-msi.c       |  2 +-
> >>>  drivers/bus/fsl-mc/mc-io.c            |  6 +++---
> >>>  drivers/bus/fsl-mc/mc-sys.c           | 19 ++++++++++---------
> >>
> >> Thanks for this. For drivers/bus/fsl-mc/*:
> >>
> >> Reviewed-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> > 
> > Any idea who will take the 'fsl-mc' patches please?
> > 
> 
> Usually GregKH (added in the thread) picks them up through his char-misc
> tree.

If you resend just the fsl-mc patches as a series, I can pick them up
that way.  Otherwise trying to pick out individual ones here is pretty
much impossible...

thanks,

greg k-h