From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DE24C48BE5 for ; Thu, 17 Jun 2021 18:08:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 699B7613D5 for ; Thu, 17 Jun 2021 18:08:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232024AbhFQSK4 (ORCPT ); Thu, 17 Jun 2021 14:10:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232339AbhFQSKz (ORCPT ); Thu, 17 Jun 2021 14:10:55 -0400 Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AC43C061574 for ; Thu, 17 Jun 2021 11:08:46 -0700 (PDT) Received: by mail-oi1-x22e.google.com with SMTP id m137so7474118oig.6 for ; Thu, 17 Jun 2021 11:08:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZWAtKejhgz7UVc2zxEARtNZRO1cFJMdr53epcTcnzQU=; b=SmXNfNN2GaeN/N9ZSUYywQZRxGS1n0N3xvZ9k20jD/BQxh/8cpcWPHrfQ4V0PBbsLw 7pG7rMJxSCTKe4/c0KWbQzAiQvGRd3P5jTfMElHq8h+N9/XxlzRCeA/li264bWpoulP8 W5iq9X83wZjEhb3EMAgTYTszLcWT/wy/qT3anZD7LVMbacfbAdnGyPfSot69Ce0p6uLe JcBS07LfKiLpYxMuW7DbxUnAjVmluJ6l4sETLGuTnkU2VP+esxiJlTejCn5z0pcQkKIi Vnov8GzWZvbXq2/MWj3kI5ZJg2uRnFY2OyJooAGoBQ17cD0aVUR94WMg+dOCpCL69pUm 301g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZWAtKejhgz7UVc2zxEARtNZRO1cFJMdr53epcTcnzQU=; b=D/WWjIvKk1dsfs9f3NJLfpdFwYyoC2hfO4nXH6j32ZMrQOPfJnfa/dsvn6S7pifIur 7EbEt8zHt+WnuQrhoStLJvroRL+TZ5CC0d2fyPzROKfckW6xx5sl4Luj2eQVtMfDj88D bM+dr4p6lXUuoIs9NBAOQfcDJP2wQ/JYMSiatnIPjsrDSbUdkoXTlzMIZ1as8/ssr/S1 ArMMO6aCZQfN1L0Ubcvw1c1z+HzaF4G5SioNQAqHpm6+Adl8JB+uvIjR3F6JWthgWo4p X0LG2ffE8hvp8SsUrbOynRVqqcgp52msT2oLkKLupRu3l+Sxy7s2nZ5y89Aa70eomaWi FUmA== X-Gm-Message-State: AOAM531ECyJNC4u4Tbtp4Lve9YXiIoszfB7sB/qWLHhvcM1uDhr8VuZl LTWMENZ+lh/vJY4XK+vdia+0CA== X-Google-Smtp-Source: ABdhPJxzYhs5dxvu+rAjh/dDCuwN000ZxS95j0d7tuw6JhuGYHb0ckK49VOQdB3Jwk6DvH7y19F7PQ== X-Received: by 2002:aca:d54f:: with SMTP id m76mr11073112oig.178.1623953325492; Thu, 17 Jun 2021 11:08:45 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id o20sm371996ook.40.2021.06.17.11.08.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jun 2021 11:08:44 -0700 (PDT) Date: Thu, 17 Jun 2021 13:08:43 -0500 From: Bjorn Andersson To: Martin Botka Cc: ~postmarketos/upstreaming@lists.sr.ht, konrad.dybcio@somainline.org, angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, jamipkettunen@somainline.org, Andy Gross , Rob Herring , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] arch: arm64: dts: qcom: Add support for SM6125 Message-ID: References: <20210613080522.25230-1-martin.botka@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed 16 Jun 08:01 CDT 2021, Martin Botka wrote: > > > On Tue, Jun 15 2021 at 07:29:49 PM -0500, Bjorn Andersson > wrote: > > On Sun 13 Jun 03:05 CDT 2021, Martin Botka wrote: > > > > > This commits adds the Device tree file for SM6125 SoC. > > > > > > Signed-off-by: Martin Botka > > > > Thanks for your work on this Martin, just spotted a few minor finishing > > touches below. > > :) > > > > > > --- > > > Changes in V2: > > > Update compatibles for mailbox & pinctrl > > > Changes in V3: > > > Fix reg for sdhci1 > > > Replace hc_mem with hc and core_mem with core > > > arch/arm64/boot/dts/qcom/sm6125.dtsi | 603 > > > +++++++++++++++++++++++++++ > > > 1 file changed, 603 insertions(+) > > > create mode 100644 arch/arm64/boot/dts/qcom/sm6125.dtsi > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi > > > b/arch/arm64/boot/dts/qcom/sm6125.dtsi [..] > > > + sdc2_state_off: sdc2-off { > > > > This should be common between all boards (except possibly the cd line), > > so this is okay to share here. > > Do you want me to move the cd as well or > do you want it to stay in here? > While the pin assignment typically follows the reference design, in my view it's just any random GPIO and hence better suited to live in the board file. Regards, Bjorn