From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
Matthias Kaehlcke <mka@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] soc: qcom: geni: move struct geni_wrapper to header
Date: Fri, 18 Jun 2021 12:10:36 -0500 [thread overview]
Message-ID: <YMzTjMNNCR9bsvfu@yoga> (raw)
In-Reply-To: <20210618141839.3777270-3-vkoul@kernel.org>
On Fri 18 Jun 09:18 CDT 2021, Vinod Koul wrote:
> SPI & I2C geni driver needs to access struct geni_wrapper, so move it to
> header. The drivers needs this header to find the geni device and use it
> in dma mapping.
>
How does this differ from engine->dev->parent?
> Using this method works for both DT and ACPI systems
>
I was under the impression that the wrapper and engines are describe
completely independently in ACPI, so we don't have a link between them.
If that's not the case, then I guess that answers the above question
about ->parent.
Regards,
Bjorn
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> drivers/soc/qcom/qcom-geni-se.c | 14 --------------
> include/linux/qcom-geni-se.h | 14 ++++++++++++++
> 2 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c
> index fe666ea0c487..08d645b90ed3 100644
> --- a/drivers/soc/qcom/qcom-geni-se.c
> +++ b/drivers/soc/qcom/qcom-geni-se.c
> @@ -78,20 +78,6 @@
> */
>
> #define MAX_CLK_PERF_LEVEL 32
> -#define NUM_AHB_CLKS 2
> -
> -/**
> - * struct geni_wrapper - Data structure to represent the QUP Wrapper Core
> - * @dev: Device pointer of the QUP wrapper core
> - * @base: Base address of this instance of QUP wrapper core
> - * @ahb_clks: Handle to the primary & secondary AHB clocks
> - * @to_core: Core ICC path
> - */
> -struct geni_wrapper {
> - struct device *dev;
> - void __iomem *base;
> - struct clk_bulk_data ahb_clks[NUM_AHB_CLKS];
> -};
>
> static const char * const icc_path_names[] = {"qup-core", "qup-config",
> "qup-memory"};
> diff --git a/include/linux/qcom-geni-se.h b/include/linux/qcom-geni-se.h
> index 5114e2144b17..5fda675c5cfe 100644
> --- a/include/linux/qcom-geni-se.h
> +++ b/include/linux/qcom-geni-se.h
> @@ -38,6 +38,20 @@ struct geni_icc_path {
> unsigned int avg_bw;
> };
>
> +#define NUM_AHB_CLKS 2
> +
> +/**
> + * @struct geni_wrapper - Data structure to represent the QUP Wrapper Core
> + * @dev: Device pointer of the QUP wrapper core
> + * @base: Base address of this instance of QUP wrapper core
> + * @ahb_clks: Handle to the primary & secondary AHB clocks
> + */
> +struct geni_wrapper {
> + struct device *dev;
> + void __iomem *base;
> + struct clk_bulk_data ahb_clks[NUM_AHB_CLKS];
> +};
> +
> /**
> * struct geni_se - GENI Serial Engine
> * @base: Base Address of the Serial Engine's register block
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-06-18 17:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 14:18 [PATCH v2 0/3] soc: qcom: geni: add support for gpi dma Vinod Koul
2021-06-18 14:18 ` [PATCH v2 1/3] soc: qcom: geni: move GENI_IF_DISABLE_RO to common header Vinod Koul
2021-06-18 17:03 ` Bjorn Andersson
2021-06-22 12:13 ` Vinod Koul
2021-06-18 14:18 ` [PATCH v2 2/3] soc: qcom: geni: move struct geni_wrapper to header Vinod Koul
2021-06-18 17:10 ` Bjorn Andersson [this message]
2021-06-18 14:18 ` [PATCH v2 3/3] soc: qcom: geni: Add support for gpi dma Vinod Koul
2021-06-18 17:23 ` Bjorn Andersson
2021-06-22 12:15 ` Vinod Koul
2021-06-18 16:59 ` [PATCH v2 0/3] soc: qcom: geni: add " Bjorn Andersson
2021-06-20 11:06 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMzTjMNNCR9bsvfu@yoga \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=sumit.semwal@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).