From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Andy Gross <agross@kernel.org>, Sibi S <sibis@codeaurora.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: soc: qcom: aoss: Add SC8180X compatible
Date: Thu, 1 Jul 2021 14:34:00 -0500 [thread overview]
Message-ID: <YN4YqCgOei+IobEB@yoga> (raw)
In-Reply-To: <20210701190359.GB2736150@robh.at.kernel.org>
On Thu 01 Jul 14:03 CDT 2021, Rob Herring wrote:
> On Fri, Jun 25, 2021 at 04:40:16PM -0700, Bjorn Andersson wrote:
> > Add compatible for the Qualcomm SC8180x platform to the AOSS QMP
> > binding.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > ---
> > Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt
> > index 783dc81b0f26..3747032311a4 100644
> > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt
> > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt
> > @@ -18,10 +18,13 @@ power-domains.
> > Definition: must be one of:
> > "qcom,sc7180-aoss-qmp"
> > "qcom,sc7280-aoss-qmp"
> > + "qcom,sc8180x-aoss-qmp"
> > "qcom,sdm845-aoss-qmp"
> > "qcom,sm8150-aoss-qmp"
> > "qcom,sm8250-aoss-qmp"
> > "qcom,sm8350-aoss-qmp"
> > + and:
> > + "qcom,aoss-qmp"
>
> This was missing from all the existing ones or is an addition?
>
We've only had platform-specific compatibles for this binding (and
implementation) so far, this patch adds sc8180x and a common compatible.
So the commit message should have been rewritten to cover this as I
extended my original patch. Sorry for missing that.
Regards,
Bjorn
> >
> > - reg:
> > Usage: required
> > @@ -70,7 +73,7 @@ The following example represents the AOSS side-channel message RAM and the
> > mechanism exposing the power-domains, as found in SDM845.
> >
> > aoss_qmp: qmp@c300000 {
> > - compatible = "qcom,sdm845-aoss-qmp";
> > + compatible = "qcom,sdm845-aoss-qmp", "qcom,aoss-qmp";
> > reg = <0x0c300000 0x100000>;
> > interrupts = <GIC_SPI 389 IRQ_TYPE_EDGE_RISING>;
> > mboxes = <&apss_shared 0>;
> > --
> > 2.29.2
> >
> >
next prev parent reply other threads:[~2021-07-01 19:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 23:40 [PATCH 0/3] dt-bindings: soc: qcom: aoss: Support sc8180x and convert to YAML Bjorn Andersson
2021-06-25 23:40 ` [PATCH 1/3] dt-bindings: soc: qcom: aoss: Add SC8180X compatible Bjorn Andersson
2021-07-01 19:03 ` Rob Herring
2021-07-01 19:34 ` Bjorn Andersson [this message]
2021-06-25 23:40 ` [PATCH 2/3] dt-bindings: soc: qcom: aoss: Convert to YAML Bjorn Andersson
2021-06-28 14:49 ` Manivannan Sadhasivam
2021-06-28 16:09 ` Bjorn Andersson
2021-07-01 14:02 ` Rob Herring
2021-07-01 19:03 ` Rob Herring
2021-07-09 17:27 ` Bjorn Andersson
2021-07-12 19:29 ` Rob Herring
2021-06-25 23:40 ` [PATCH 3/3] soc: qcom: aoss: Add generic compatible Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YN4YqCgOei+IobEB@yoga \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sibis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).