From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFAF0C2B9F4 for ; Wed, 23 Jun 2021 02:53:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D323A6112D for ; Wed, 23 Jun 2021 02:53:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230286AbhFWCzR (ORCPT ); Tue, 22 Jun 2021 22:55:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229934AbhFWCzR (ORCPT ); Tue, 22 Jun 2021 22:55:17 -0400 Received: from mail-oo1-xc30.google.com (mail-oo1-xc30.google.com [IPv6:2607:f8b0:4864:20::c30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80E50C061574 for ; Tue, 22 Jun 2021 19:52:59 -0700 (PDT) Received: by mail-oo1-xc30.google.com with SMTP id n20-20020a4abd140000b029024b43f59314so381526oop.9 for ; Tue, 22 Jun 2021 19:52:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iQPRI9VlPTgzdRBNR9cu3Y1yAK0KjUj8zkwoLnfL0b4=; b=lKjieprEHNd7Gb8ed6WjZQQ07ZiX+Sd9cNiqccT7+sEcQDfrm+HHCEBQexAKJTcgA7 MX72dblVd23f/ukS4JXLpuijOSA7yQYSqe5XTe9TF/i4vJ3mTUwTE70m873fS/ZgmQlJ liH1VEjGJ7790IVoi0uTbd06WZBzluEmi9RcMPhuFEV/SctmZmCZkZJ17mMiWA8zre0s tklNAYxjXM0QPKEyyZF2vChePNcztFFyuwmKMfhpzxiEAOghVKCwrWzKeqC4/eK9dbMS gsDErwpgmyMGUNgPFHq2k2d/+5SmQfUCJuRYBba/T9S83Arq0t4uXMVCVQ7RTyoLxxPI RHUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iQPRI9VlPTgzdRBNR9cu3Y1yAK0KjUj8zkwoLnfL0b4=; b=j7irSRSov6TZHAPGMeOuecFvndZYz37N+fvmQGj5uQOiOnbyD/K0gj1NE6kVwOnU3Y b/zk8YG5e5tQYi3W2EEQ2U1khw3q1H5SPnuXn1xpL7GrSqMkR6IMT5zz6voiKdFnUBj/ 4Z6g1pBhE1TsJbg/nAJd1LV63iMMk4AIkXp6zYJixuYOpGi7y+QcAXZuR3tq9AL0PP9U TF2N0aRzIcPcI4wQ9xh8H0IIlMazL+LwOXrBeQdwzObk0y51tXkHTl7BeFWtoUcEvlLN ek6rfulGl884LOxROREoA0YmQGS5CTUNO/aJiNQKaPkOaiHncZIREDGfmHT8USftczor 9MPQ== X-Gm-Message-State: AOAM532tBL5XdSw+YL1YqcQ0/RO0zdmRid0LoKvmgZRBnWbIsobTvAwy FiO5O6McX6mof/+odAV2+jQEGA== X-Google-Smtp-Source: ABdhPJwPMPpfbBtL3Z9YpwuUqIcllFoSMkx42NLNfW0CK2SsGCgoPgM5m65L/Rj3yow7GnTvEMSzAw== X-Received: by 2002:a4a:4fc8:: with SMTP id c191mr6038147oob.68.1624416778780; Tue, 22 Jun 2021 19:52:58 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id b198sm4718927oii.19.2021.06.22.19.52.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jun 2021 19:52:58 -0700 (PDT) Date: Tue, 22 Jun 2021 21:52:56 -0500 From: Bjorn Andersson To: Stephen Boyd Cc: khsieh@codeaurora.org, robdclark@gmail.com, sean@poorly.run, vkoul@kernel.org, agross@kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org, abhinavk@codeaurora.org, aravindh@codeaurora.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64/dts/qcom/sc7180: Add Display Port dt node Message-ID: References: <21dc5c9fc2efdc1a0ba924354bfd9d75@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue 22 Jun 15:23 CDT 2021, Stephen Boyd wrote: > Quoting Bjorn Andersson (2021-06-18 14:41:50) > > On Fri 18 Jun 15:49 CDT 2021, Stephen Boyd wrote: > > > > > Quoting khsieh@codeaurora.org (2021-06-10 09:54:05) > > > > On 2021-06-08 16:10, Bjorn Andersson wrote: > > > > > On Tue 08 Jun 17:44 CDT 2021, Stephen Boyd wrote: > > > > > > > > > >> Honestly I suspect the DP PHY is _not_ in the CX domain as CX is for > > > > >> digital logic. Probably the PLL is the hardware that has some minimum > > > > >> CX > > > > >> requirement, and that flows down into the various display clks like > > > > >> the > > > > >> link clk that actually clock the DP controller hardware. The mdss_gdsc > > > > >> probably gates CX for the display subsystem (mdss) so if we had proper > > > > >> corner aggregation logic we could indicate that mdss_gdsc is a child > > > > >> of > > > > >> the CX domain and then make requests from the DP driver for particular > > > > >> link frequencies on the mdss_gdsc and then have that bubble up to CX > > > > >> appropriately. I don't think any of that sort of code is in place > > > > >> though, right? > > > > > > > > > > I haven't checked sc7180, but I'm guessing that it's following the > > > > > other > > > > > modern platforms, where all the MDSS related pieces (including e.g. > > > > > dispcc) lives in the MMCX domain, which is separate from CX. > > > > > > > > > > So the parent of MDSS_GDSC should be MMCX, while Kuogee's answer (and > > > > > the dp-opp-table) tells us that the PLL lives in the CX domain. > > > > > > Isn't MMCX a "child" of CX? At least my understanding is that MMCX is > > > basically a GDSC that clamps all of multimedia hardware block power > > > logic so that the leakage is minimized when multimedia isn't in use, > > > i.e. the device is suspended. In terms of bumping up the voltage we have > > > to pin that on CX though as far as I know because that's the only power > > > domain that can actually change voltage, while MMCX merely gates that > > > voltage for multimedia. > > > > > > > No, MMCX is a separate rail from CX, which powers the display blocks and > > is parent of MDSS_GDSC. But I see in rpmhpd that sc7180 is not one of > > these platforms, so I presume this means that the displayport controller > > thereby sits in MDSS_GDSC parented by CX. > > > > But in line with what you're saying, the naming of the supplies to the > > QMP indicates that the power for the PLLs is static. As such the only > > moving things would be the clock rates in the DP controller and as such > > that's what needs to scale the voltage. > > > > So if the resources we're scaling is the clocks in the DP controller > > then the gist of the patch is correct. The only details I see is that > > the DP controller actually sits in MDSS_GDSC - while it should control > > the level of its parent (CX). Not sure if we can describe that in a > > simple way. > > Right. I'm not sure things could be described any better right now. If > we need to change this to be MDSS_GDSC power domain and control the > level of the parent then I suppose we'll have to make some sort of DT > change and pair that with a driver change. Maybe if that happens we can > just pick a new compatible and leave the old code in place. > I would prefer that we stay away from making up a new compatible for that, but let's see when we get there. > Are you happy enough with this current patch? > Yes, I think this looks good. > > > > > > PS. Why does the node name of the opp-table have to be globally unique? > > Presumably the opp table node name can be 'opp-table' as long as it > lives under the node that's using it. If the opp table is at / or /soc > then it will need to be unique. I'd prefer just 'opp-table' if possible. I asked the same question (if it has to be globally unique) in the patch adding sdhci nodes for sc7280 and I didn't get a sufficient answer... So now I do want to know why "opp-table" wouldn't be sufficient name for these device-internal nodes. Regards, Bjorn