From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A9EDC49EA7 for ; Fri, 25 Jun 2021 12:39:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8003D61933 for ; Fri, 25 Jun 2021 12:39:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229712AbhFYMlW (ORCPT ); Fri, 25 Jun 2021 08:41:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:39540 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbhFYMlV (ORCPT ); Fri, 25 Jun 2021 08:41:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 32AC461926; Fri, 25 Jun 2021 12:39:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624624740; bh=l8O+fjyGjRv3cj2MPL8Ia2Ha1nrIh5AMEL/MVYZ7Wt4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1Wv76E15eJbmLpdMCIhfp499N7uAArrFCus5Q4uIEeJqENUKjsgfvrZWV8Hr+Vxgv it8a6E+KnLh/FASAzHKFyErMD2CVsm+3v3yVbIZou5ou5qYOvf89dGr3A4fGCzuViS AWCRHIBBWKkuR9NzHkMjWrsiaz3pgM8HpuweVVnk= Date: Fri, 25 Jun 2021 14:38:58 +0200 From: Greg KH To: Manivannan Sadhasivam Cc: hemantk@codeaurora.org, bbhatt@codeaurora.org, linux-arm-msm@vger.kernel.org, jhugo@codeaurora.org, linux-kernel@vger.kernel.org, loic.poulain@linaro.org, kvalo@codeaurora.org, ath11k@lists.infradead.org, stable@vger.kernel.org, Jeffrey Hugo Subject: Re: [PATCH 06/10] bus: mhi: core: Set BHI and BHIe pointers to NULL in clean-up Message-ID: References: <20210625123355.11578-1-manivannan.sadhasivam@linaro.org> <20210625123355.11578-7-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210625123355.11578-7-manivannan.sadhasivam@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Jun 25, 2021 at 06:03:51PM +0530, Manivannan Sadhasivam wrote: > From: Bhaumik Bhatt > > Set the BHI and BHIe pointers to NULL as part of clean-up. This > makes sure that stale pointers are not accessed after powering > MHI down. > > Cc: stable@vger.kernel.org Why is this needed for stable, but patch 5/10 is not? And what commit does this fix? How far back should it go? And is this really fixing anything? thanks, greg k-h