From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 686FEC49EA7 for ; Fri, 25 Jun 2021 22:42:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E7336194D for ; Fri, 25 Jun 2021 22:42:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229776AbhFYWpP (ORCPT ); Fri, 25 Jun 2021 18:45:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229955AbhFYWpP (ORCPT ); Fri, 25 Jun 2021 18:45:15 -0400 Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B028C061768 for ; Fri, 25 Jun 2021 15:42:54 -0700 (PDT) Received: by mail-ot1-x334.google.com with SMTP id w23-20020a9d5a970000b02903d0ef989477so10980712oth.9 for ; Fri, 25 Jun 2021 15:42:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xtN9ANVfYXkPzwu38mMzyB0Issc28w9lzEk1ITbrKYg=; b=sGCu/kq1nhIOE5s5PkeiJ/x0aKlD2fFX5DUoxiX85lsBv9FKyK1onolU19QQyePcRr hw2lGzAl97idn4S7utOdrPy6c3pq7ck/XiYl6++CCQl+KII0K9gEMhva29B52G0WkdH8 SIGdvFgN48NCcacJqxS86jRqmv2ENn6JlFbLDy0YwWYWfpGuHNw7VYlEYeQN1Pt3XcgA fAHb2CgfRbQUTXvk4wPgVDRsvbOH+Xz11965TCsojw8wXkf3+f1lv7D5Dmu+lFjTtnby PDA541m341nAaedbwR97Lahqfxu9eHPCL/WEESE7w+tXMuqwwBwwT8KCiYoP4nxur1Qw qEsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xtN9ANVfYXkPzwu38mMzyB0Issc28w9lzEk1ITbrKYg=; b=tpKRudSeDw44LOoLDAYsNTwRPNTevL0e+mFlV/r4BqFAdoKyWXUXceGkSTmUhE13Nq NeP6GSUoS+92I/vvBproIBtlbtodEyJuBjqrRS0X9vA2Ssd6hIwRJqT/3PcGAbMyXSZ1 TKxCyyaYc6hx7YR+G6es/SUbtuMX7DaV0VM5/DN5MwGwJEORsCHURQYw3kOgflE10cJq U92hBWE3rLYF1v+HQxbjklY3DR+zWq+Papkv3x5hnwgPlNpOCrVChP3H+2dQ+dKOaCfR FJJYn9kzIkxxrX2ZaQqXdDh2vpbYV7Ff4oASMxianRt3tx2i1t7MJAhXTFrel/l/6CxZ urSw== X-Gm-Message-State: AOAM532WWuk345YvWo0Oh34tWWTNMwj4cz9j3tE1051AiPGuJfxam3mV QzCwKANuN5Ckap1OmvjZu2pwNw== X-Google-Smtp-Source: ABdhPJxL4hY1zoMOq4i+Qkhu22O0kRlynKmYAUUcmMO0c+3v0Vmu0qbFAyja7RMqCZn4DFO7Wdg3vA== X-Received: by 2002:a9d:389:: with SMTP id f9mr11610020otf.213.1624660973107; Fri, 25 Jun 2021 15:42:53 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id t21sm1737366otl.23.2021.06.25.15.42.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jun 2021 15:42:52 -0700 (PDT) Date: Fri, 25 Jun 2021 17:42:50 -0500 From: Bjorn Andersson To: Manivannan Sadhasivam Cc: Andy Gross , Ohad Ben-Cohen , Mathieu Poirier , Rob Herring , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] remoteproc: qcom: pas: Add SC8180X adsp, cdsp and mpss Message-ID: References: <20210608174944.2045215-1-bjorn.andersson@linaro.org> <20210608174944.2045215-2-bjorn.andersson@linaro.org> <20210625044736.GA4974@workstation> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210625044736.GA4974@workstation> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu 24 Jun 23:47 CDT 2021, Manivannan Sadhasivam wrote: > On Tue, Jun 08, 2021 at 10:49:44AM -0700, Bjorn Andersson wrote: > > The Qualcomm SC8180X has the typical ADSP, CDSP and MPSS remote > > processors operated using the PAS interface, add support for these. > > > > Attempts to configuring mss.lvl is failing, so a new adsp_data is > > provided that skips this resource, for now. > > > > What is the impact of this skipped resource? I guess it is enabled by > the bootloader so we can't change it in runtime? > The reason for voting for the "proxy" resources is such that if apss power collapses we might cut the power before the firmware has had a chance to tell the RPMh to keep the power on. So, there is a chance that an unfortunately timed power collapse might cause the modem to loose power, but given that I can't poke mss.lvl I would expect that this is handled in some other way - if necessary... > > Signed-off-by: Bjorn Andersson > > Given that adsp remoteproc works without configuring mss power domain, > > Reviewed-by: Manivannan Sadhasivam > Thank you! Regards, Bjorn > Thanks, > Mani > > > --- > > > > Changes since v1: > > - None > > > > drivers/remoteproc/qcom_q6v5_pas.c | 22 ++++++++++++++++++++++ > > 1 file changed, 22 insertions(+) > > > > diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c > > index b921fc26cd04..a79bee901e9b 100644 > > --- a/drivers/remoteproc/qcom_q6v5_pas.c > > +++ b/drivers/remoteproc/qcom_q6v5_pas.c > > @@ -689,6 +689,25 @@ static const struct adsp_data mpss_resource_init = { > > .ssctl_id = 0x12, > > }; > > > > +static const struct adsp_data sc8180x_mpss_resource = { > > + .crash_reason_smem = 421, > > + .firmware_name = "modem.mdt", > > + .pas_id = 4, > > + .has_aggre2_clk = false, > > + .auto_boot = false, > > + .active_pd_names = (char*[]){ > > + "load_state", > > + NULL > > + }, > > + .proxy_pd_names = (char*[]){ > > + "cx", > > + NULL > > + }, > > + .ssr_name = "mpss", > > + .sysmon_name = "modem", > > + .ssctl_id = 0x12, > > +}; > > + > > static const struct adsp_data slpi_resource_init = { > > .crash_reason_smem = 424, > > .firmware_name = "slpi.mdt", > > @@ -811,6 +830,9 @@ static const struct of_device_id adsp_of_match[] = { > > { .compatible = "qcom,qcs404-cdsp-pas", .data = &cdsp_resource_init }, > > { .compatible = "qcom,qcs404-wcss-pas", .data = &wcss_resource_init }, > > { .compatible = "qcom,sc7180-mpss-pas", .data = &mpss_resource_init}, > > + { .compatible = "qcom,sc8180x-adsp-pas", .data = &sm8150_adsp_resource}, > > + { .compatible = "qcom,sc8180x-cdsp-pas", .data = &sm8150_cdsp_resource}, > > + { .compatible = "qcom,sc8180x-mpss-pas", .data = &sc8180x_mpss_resource}, > > { .compatible = "qcom,sdm845-adsp-pas", .data = &adsp_resource_init}, > > { .compatible = "qcom,sdm845-cdsp-pas", .data = &cdsp_resource_init}, > > { .compatible = "qcom,sdx55-mpss-pas", .data = &sdx55_mpss_resource}, > > -- > > 2.29.2 > >