From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5E9DC4320E for ; Tue, 3 Aug 2021 23:12:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BCFDD60F58 for ; Tue, 3 Aug 2021 23:12:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232965AbhHCXM4 (ORCPT ); Tue, 3 Aug 2021 19:12:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232814AbhHCXM4 (ORCPT ); Tue, 3 Aug 2021 19:12:56 -0400 Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62FA1C061757 for ; Tue, 3 Aug 2021 16:12:44 -0700 (PDT) Received: by mail-oi1-x22f.google.com with SMTP id a19so722384oiw.6 for ; Tue, 03 Aug 2021 16:12:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=i+DGuoeLoChs6Ei4AJ031ih+E+zcev4zRO6x+z1vz+s=; b=tgrVhS0xsGM0woAKFLMfnMFTciJ1Rc6vsLIQyP/i2i8ArCp0ErwmvRnIh5IaCpVlVT de6ZVG4jUMWYikAZYeiPkbmPlV2DsOGvq7lZUJ/cnhqGCo4bUXEcWINETSM5w7fv7Hva meSj8az8RjT/s1kpdDIlaAiSnkSjO8AKAfP1EltllFdN/t4WHr4SCA0oVy31rtY3s0+V kQJB1KPg20T8AJ2dmOSmm6ilkk26gRow/9MByAqNm5NK8kFyfkBDFOqIfG7Uz9E3879/ 4zcK42u0y90EM4WwbBLdEpGe+F+chBSADThwzz8A/bEGNJrRef2ktx867M7jdQKxXcRn 0DGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=i+DGuoeLoChs6Ei4AJ031ih+E+zcev4zRO6x+z1vz+s=; b=rhBooFZVOUSixMHG4xyDMxWIf5bmL8doScaVnM7LGtTdln87Qc/UTgZTwVfK3QwOmh gtSNAonbu/HWHKnAvQ4+NHG81gMf+Cgk/Ne1AyLWmZwQgD7qR0a8/5fk9cQ4CmoNrrXu 0XGs/Pc3AQcLjFFh/urZdoMUYC39+ASpB8qpIHXiLZOPKalKIqZerRruC4G5DhBpv2zL nQlnEdVUg334ijeNO/OnYrPnpkRXXcnHW/7rhlD7GUk+B26+EkGzxNHC8QAT+h2PjLtJ U3I330SBUp9FqtmTm7uN2Sa1GVZqDCEbAcG7rE2I+iR8EHbCePDp2kBhN9l/83qfX/E8 bk3Q== X-Gm-Message-State: AOAM533JOTGGfLMOzIjQaXq5PzHIobp/MZ7Lf5HOTA/VEu3M4kM5zjb+ Szi9uU3ZEHlzF0P7Me3Fm78uPA== X-Google-Smtp-Source: ABdhPJwa87SFdE7d4lnFkZg5tizEp+UNMG3WPscx4sDxJhPVVs2Sft3z8URa70QYD0vL7GWqu3V4gw== X-Received: by 2002:a54:4107:: with SMTP id l7mr4759521oic.66.1628032363639; Tue, 03 Aug 2021 16:12:43 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id q187sm132746oif.2.2021.08.03.16.12.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Aug 2021 16:12:43 -0700 (PDT) Date: Tue, 3 Aug 2021 18:12:41 -0500 From: Bjorn Andersson To: Doug Anderson Cc: "Rafael J . Wysocki" , Niklas Cassel , Akhil P Oommen , linux-arm-msm , Ulf Hansson , Andy Gross , Niklas Cassel , LKML , Linux PM Subject: Re: [PATCH v2] PM: AVS: qcom-cpr: Use nvmem_cell_read_variable_le_u32() Message-ID: References: <20210521134437.v2.1.Id1c70158722750aec0673d60c12e46a9c66bbfed@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri 23 Jul 18:05 CDT 2021, Doug Anderson wrote: > Rafael / Bjorn, > > On Fri, May 21, 2021 at 1:45 PM Douglas Anderson wrote: > > > > Let's delete the private function cpr_read_efuse() since it does the > > basically the same thing as the new API call > > nvmem_cell_read_variable_le_u32(). > > > > Differences between the new API call and the old private function: > > * less error printing (I assume this is OK). > > * will give an error if the value doesn't fit in 32-bits (the old code > > would have truncated silently). > > > > Signed-off-by: Douglas Anderson > > --- > > I haven't done any more than compile-test this. Mostly I'm just > > writing this patch because it helped provide inspiration for the > > general API function. > > > > Changes in v2: > > - Resending v1 as a singleton patch; dependency is merged in mainline. > > > > drivers/soc/qcom/cpr.c | 43 +++++------------------------------------- > > 1 file changed, 5 insertions(+), 38 deletions(-) > > Are either of you interested in landing this? I guess Rafael landed > most of the recent changes to this driver, but it used to be under the > 'power' directory. Now that it's under 'drivers/soc/qcom' maybe it > should go through Bjorn's tree? > Yes, it makes sense to pick it up through my tree, unfortunately I forgot about this move and ignored the patch in my queue based on the $subject. I've picked it up now. Regards, Bjorn