From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10FA6C433F5 for ; Fri, 3 Sep 2021 19:00:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E93946056B for ; Fri, 3 Sep 2021 19:00:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350572AbhICTB4 (ORCPT ); Fri, 3 Sep 2021 15:01:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350564AbhICTB4 (ORCPT ); Fri, 3 Sep 2021 15:01:56 -0400 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6D85C061575 for ; Fri, 3 Sep 2021 12:00:55 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id w7so6365766pgk.13 for ; Fri, 03 Sep 2021 12:00:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/RAyYN7XSWdMXJkR/E7oV/FAskQ62li2eXUaN70sJiQ=; b=LlSfdxokQTHak+lCCI/rYOtrG3FYCueY+bffw3RtBxX8x1AOgO1F0SSTERzIsZ3kmE Fay2nHsEaXJpEDLLuBsP/1QftwcjzJZCWn3sfaX01bEOSD4c6n1x3wbwIl6w+IuIXu/F SHHh2aE2gKbO966yYee7W5oKwJc2l4rMheo0M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/RAyYN7XSWdMXJkR/E7oV/FAskQ62li2eXUaN70sJiQ=; b=uXW8jcOArhJg/EAdNQ4e+u4bLy+jdbJ1yo0fCw3+MqNqLrSZ2wwccqBQ/bE5QI9Ohe zYR+V+lcz+/KcORGRvF4NX9pcRNe7gQqTA38PobE2eZnX6geT0hvW3DGex1ETNg0XXVx 52/8QXEOtyd4AVmsiJ/7+2LlvoCqss0pmH1MvqenkWKX/IgzeGSNZHYgI7ClBeTCb8VO p9nJKUi+B+s2tHvjlAtq6bW0DZCw9y/PT7uRpvgn0yZIin61BoIsMjErZ/Zp7WbDCtQs B9rIw6n8wFkp5zzHuRryLCp09V1s60h0JIoJUFAn3oiiMVoC7MC71IJLfRCK8A2xSzmn iHSA== X-Gm-Message-State: AOAM532W9srD1QyH+dybGDTJBbeMUKqphm5PxDVmCSX25WXbNYirsus/ W0znMNsjXXBvfTo/lm8pphWI0Q== X-Google-Smtp-Source: ABdhPJxTKBNFM52lTpurPfhlKUeZfeipurGeOuwOfFDVCXHJ8EDkoOeCLegHdP7fE/3OLWlLR7rPaw== X-Received: by 2002:a65:6287:: with SMTP id f7mr443437pgv.444.1630695655326; Fri, 03 Sep 2021 12:00:55 -0700 (PDT) Received: from localhost ([2620:15c:202:201:80b3:9f00:3170:fd8b]) by smtp.gmail.com with UTF8SMTPSA id i5sm124517pgp.53.2021.09.03.12.00.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 12:00:54 -0700 (PDT) Date: Fri, 3 Sep 2021 12:00:53 -0700 From: Matthias Kaehlcke To: Stephen Boyd Cc: Andy Gross , Bjorn Andersson , Rob Herring , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Douglas Anderson Subject: Re: [PATCH] arm64: dts: qcom: sc7180-trogdor: Delete ADC config for unused thermistors Message-ID: References: <20210902154711.1.I9777d0036ecbb749a4fb9ebb892f94c6e3a51772@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Sep 02, 2021 at 05:20:43PM -0700, Stephen Boyd wrote: > Quoting Matthias Kaehlcke (2021-09-02 15:47:44) > > The charger thermistor on Lazor, CoachZ rev1 and Pompom rev1+2 is > > either the wrong part or not stuffed at all, the same is true for > > the skin temperature thermistor on CoachZ rev1. The corresponding > > thermal zones are already disabled for these devices, in addition > > delete the ADC nodes of the thermistors. > > > > For Lazor and CoachZ rev1 also disable the PM6150 ADC thermal > > monitor since there are no other temperatures to monitor. > > > > Signed-off-by: Matthias Kaehlcke > > --- > > > > .../arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dts | 12 ++++++++++++ > > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi | 10 ++++++++++ > > .../arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dts | 8 ++++++++ > > .../arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dts | 8 ++++++++ > > 4 files changed, 38 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dts > > index 21b516e0694a..edfcd47e1a00 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dts > > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dts > > @@ -23,6 +23,18 @@ &charger_thermal { > > status = "disabled"; > > }; > > > > +&pm6150_adc { > > + /delete-node/ skin-temp-thermistor@4e; > > + /delete-node/ charger-thermistor@4f; > > Is there any other child node? I only see two, unless I missed > something. In which case the whole node can be disabled? Right, the ADC itself can also be disabled in this case. > > > +}; > > + > > +&pm6150_adc_tm { > > + status = "disabled"; > > + > > + /delete-node/ charger-thermistor@0; > > + /delete-node/ skin-temp-thermistor@1; > > +}; > > + > > /* > > * CoachZ rev1 is stuffed with a 47k NTC as thermistor for skin temperature, > > * which currently is not supported by the PM6150 ADC driver. Disable the > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi > > index 00535aaa43c9..57f7b19f83b0 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi > > @@ -54,6 +54,16 @@ &panel { > > compatible = "boe,nv133fhm-n62"; > > }; > > > > +&pm6150_adc { > > + /delete-node/ charger-thermistor@4f; > > Same question here. Yes, the ADC can be disabled here too.