From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Stephan Gerhold <stephan@gerhold.net>,
Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 2/3] arm64: dts: qcom: msm8916: Drop underscore in node name
Date: Tue, 21 Sep 2021 14:38:26 -0500 [thread overview]
Message-ID: <YUo0suaIugOco1Vu@builder.lan> (raw)
In-Reply-To: <CAE-0n51Ukr0FMhzHotrGnrJjE3=w2X_u4ukc1KC_HpjjsUdNfg@mail.gmail.com>
On Tue 21 Sep 13:20 CDT 2021, Stephen Boyd wrote:
> Quoting Stephan Gerhold (2021-09-21 08:21:19)
> > Using underscores in device tree nodes is not very common.
> > Additionally, the _region suffix in "smem_region@..." is not really
> > useful since it's obvious that it describes a reserved memory region.
> >
> > Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> > ---
> > arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> > index 5551dba2d5fd..95dea20cde75 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> > @@ -41,7 +41,7 @@ tz-apps@86000000 {
> > no-map;
> > };
> >
> > - smem_mem: smem_region@86300000 {
> > + smem_mem: smem@86300000 {
>
> Shouldn't that be smem_mem: memory@86300000? Node names should be
> generic.
>
I agree, that seems better.
In the meantime, I've picked patch 1 and 3.
Regards,
Bjorn
> > reg = <0x0 0x86300000 0x0 0x100000>;
> > no-map;
> > };
next prev parent reply other threads:[~2021-09-21 19:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 15:21 [PATCH 1/3] arm64: dts: qcom: msm8916: Add unit name for /soc node Stephan Gerhold
2021-09-21 15:21 ` [PATCH 2/3] arm64: dts: qcom: msm8916: Drop underscore in node name Stephan Gerhold
2021-09-21 18:20 ` Stephen Boyd
2021-09-21 19:38 ` Bjorn Andersson [this message]
2021-09-21 19:45 ` Stephan Gerhold
2021-09-22 0:34 ` Stephen Boyd
2021-10-17 15:31 ` (subset) " Bjorn Andersson
2021-09-21 15:21 ` [PATCH 3/3] arm64: dts: qcom: msm8916: Add "qcom,msm8916-sdhci" compatible Stephan Gerhold
2021-09-21 18:21 ` Stephen Boyd
2021-09-21 18:19 ` [PATCH 1/3] arm64: dts: qcom: msm8916: Add unit name for /soc node Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUo0suaIugOco1Vu@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=stephan@gerhold.net \
--cc=swboyd@chromium.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).