From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 263D0C433EF for ; Wed, 6 Oct 2021 17:29:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A7D961175 for ; Wed, 6 Oct 2021 17:29:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231784AbhJFRbq (ORCPT ); Wed, 6 Oct 2021 13:31:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229835AbhJFRbp (ORCPT ); Wed, 6 Oct 2021 13:31:45 -0400 Received: from mail-ot1-x332.google.com (mail-ot1-x332.google.com [IPv6:2607:f8b0:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CE94C061746 for ; Wed, 6 Oct 2021 10:29:53 -0700 (PDT) Received: by mail-ot1-x332.google.com with SMTP id r43-20020a05683044ab00b0054716b40005so4045446otv.4 for ; Wed, 06 Oct 2021 10:29:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=sriAlmS/O1ECrsUc2OnPgpiaqh82uZoYCygtIK25Qms=; b=U5/BlyXEMbL16pTIuvauG2ZaIDGc6fUX3EV72SGDx4T74Tpwj7UsA4oMhgwrGuZ0rW fcA3XyEz97l1ejfg/T3jSNAKYJfOn3lgIulJaltlOzES327tc9JDntqc1WoDwL3IQY+I ZX1T766ELr1cACdNGgEYpKpbd4Pd2IiW5/0EdQea1shQixU0ojEhOwdPfmKvKPa1Wm42 llCsdKQGeEgbfvYOVDfukom68SPhSvDcSK3fFkcrVK4pywZp8HYdJ6x7hp4mpZORmK+y iCrBFqSBLAhcSpdFT2gVkB1duSzYAnhDyvHMt7Bb5Cf8jI+opOh59nm4Zr8BHDD6Hd56 tclA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sriAlmS/O1ECrsUc2OnPgpiaqh82uZoYCygtIK25Qms=; b=tH9Bkw0yACZgJOEfVRz9MVJwaRRzgYooiNLQ1e0qlYg3GYAclNt3q0WTR9O+Q3tnRV J9lLuKnICj0ouHwmbdVmNIytQ5XT6vhKy8mIvT4++UpK/EcicVY0GCgRWYZL7KD4Cay+ GM5t1at2OC7MGtUtkTyWZpz+rZSOLH420mctW7NW+73bwfqPN9pDyt0vABmE/uPbN6SY Y8y3+YVnEARy4kUdtZFFrQluqmzRog/9nIJmeFGwusLYIlAUjZ8C8WZE7tF79g9MMuCz CoQMAnP4f6RNNQkCqqBLD5sZgWkTkCpuxu5CvH2C9Y+zgqcP/76NfH2FJ4J3AWpszJ3V 2UiQ== X-Gm-Message-State: AOAM531v/sW6Fe0YzmfzFiYfZ4fWvYAuKvbFMcOqLbkB8JPJ7O+4mF3W fTPT0EXUeYaKAwPTosmIEBn94A== X-Google-Smtp-Source: ABdhPJyS/b8mbpHQI/Rhb/Fwvm6HfYEn/3btWLeRutifqSrkBNiIKsEaa4tSBor2yY437OBnLj1jhg== X-Received: by 2002:a9d:1716:: with SMTP id i22mr20008206ota.20.1633541392652; Wed, 06 Oct 2021 10:29:52 -0700 (PDT) Received: from ripper ([2600:1700:a0:3dc8:205:1bff:fec0:b9b3]) by smtp.gmail.com with ESMTPSA id z24sm4027968oic.26.2021.10.06.10.29.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Oct 2021 10:29:52 -0700 (PDT) Date: Wed, 6 Oct 2021 10:31:33 -0700 From: Bjorn Andersson To: khsieh@codeaurora.org Cc: Stephen Boyd , Abhinav Kumar , Daniel Vetter , David Airlie , Dmitry Baryshkov , Rob Clark , Sean Paul , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sankeerth Billakanti Subject: Re: [PATCH] drm/msm/dp: Shorten SETUP timeout Message-ID: References: <20211005023750.2037631-1-bjorn.andersson@linaro.org> <3dbe0fe48da88af9dee396a85b940e76@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3dbe0fe48da88af9dee396a85b940e76@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed 06 Oct 08:37 PDT 2021, khsieh@codeaurora.org wrote: > On 2021-10-05 19:10, Bjorn Andersson wrote: > > On Tue 05 Oct 16:04 PDT 2021, khsieh@codeaurora.org wrote: > > > > > On 2021-10-05 15:36, Stephen Boyd wrote: > > > > Quoting Bjorn Andersson (2021-10-05 14:40:38) > > > > > On Tue 05 Oct 11:45 PDT 2021, Stephen Boyd wrote: > > > > > > > > > > > Quoting Bjorn Andersson (2021-10-04 19:37:50) > > > > > > > Found in the middle of a patch from Sankeerth was the reduction of the > > > > > > > INIT_SETUP timeout from 10s to 100ms. Upon INIT_SETUP timeout the host > > > > > > > is initalized and HPD interrupt start to be serviced, so in the case of > > > > > > > eDP this reduction improves the user experience dramatically - i.e. > > > > > > > removes 9.9s of bland screen time at boot. > > > > > > > > > > > > > > Suggested-by: Sankeerth Billakanti > > > > > > > Signed-off-by: Bjorn Andersson > > > > > > > --- > > > > > > > > > > > > Any Fixes tag? BTW, the delay design is pretty convoluted. I had to go > > > > > > re-read the code a couple times to understand that it's waiting 100ms > > > > > > times the 'delay' number. Whaaaaat? > > > > > > > > > > > > > > > > I assume you're happy with the current 10s delay on the current > > > > > devices, so I don't think we should push for this to be backported. > > > > > I have no need for it to be backported on my side at least. > > > > > > > > > > > > > Sure. Fixes tag != backported to stable trees but it is close. > > > > > > > > > > Reviewed-by: Stephen Boyd > > > > > > > > dp_add_event(dp, EV_HPD_INIT_SETUP, 0, 1); <== to 100ms > > > > > > This patch will prevent usb3 from working due to dp driver > > > initialize phy > > > earlier than usb3 which cause timeout error at power up usb3 phy > > > when both > > > edp and dp are enabled. > > > > Can you please help me understand what you mean here, I use this on my > > sc8180x with both eDP and USB-C/DP right now. What is it that doesn't > > work? Or am I just lucky in some race condition? > > > > Thanks, > > Bjorn > > > The problem is seen at sc7280. > Apple dongle have both hdmi and usb port. > plug Apple dongle into type-c, then plug DP into apple's hdmi port and usb > mouse into apple's usb port. > If edp enabled at this time, then usb mouse will not work due to timeout at > phy power up. > Okay, so you're saying that if the DP driver invokes phy_power_on() before the USB driver does, USB initialization fails (or at least USB doesn't work)? Sounds like something we need to work out in the QMP phy driver. Do you have any more details about what's going wrong. Also, I've seen various references to said "Apple dongle", do you have a link to the exact one you're testing with so I can pick one up for testing purposes as well? Regards, Bjorn > > > I had prepared a patch (drm/msm/dp: do not initialize combo phy > > > until plugin > > > interrupt) to fix this problem. > > > Unfortunately, my patch is depend on Bjorn's patch (PATCH v3 3/5] > > > drm/msm/dp: Support up to 3 DP controllers). > > > I will submit my patch for review once Bjorn's patches merged in. > > > Therefore I would think this patch should go after both Bjorn's > > > patches and > > > my patch. > > > > > > > > >