From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3A7AC433F5 for ; Tue, 19 Oct 2021 13:31:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC58561378 for ; Tue, 19 Oct 2021 13:31:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231564AbhJSNdj (ORCPT ); Tue, 19 Oct 2021 09:33:39 -0400 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.53]:11050 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231563AbhJSNde (ORCPT ); Tue, 19 Oct 2021 09:33:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1634650271; s=strato-dkim-0002; d=gerhold.net; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=Q/NtJ7KiFCCIZLLJe6eyRG2jqj17800w/HejDZWo5fU=; b=AZSL3FWYlJWnXLmLbVr3hbc/1HGF95QmiBNeB14RNYwupVBKZFUzA+Q2yBmAoES+No E1RmkdV7PYGQwnFi2CO7uHAv8nY9U469hiC3FpMoQEGn2FFbH8/Pmu5Q7Z3T4yHdpWIt LuEvNWBEOVedrcjMsk+Hib9jakIAnTDoodEuslmlsDN3kJNQiLnhUK4gXFYLwZxZIwQ4 yAoaNHtHQKuDHKIsUYIV7jjcRoN4W+REZo7IHJU82I0O+ldUKZfr4p+aKN+VYWBG2gaU 1J/nEi8klDQcCvO717VaAtIO+494qKzsVYtso1TMTzOZDHxhJmhdv8MZ+UG9fduzSyXY KVGQ== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P3gBZUipdd93FF5ZZvYFPugejmSTVR2nRPhVOQ/OcYgojyw4j34+u267FZF9PwpcNKLVrKw5+aY=" X-RZG-CLASS-ID: mo00 Received: from gerhold.net by smtp.strato.de (RZmta 47.33.8 AUTH) with ESMTPSA id 301038x9JDV9e1k (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Tue, 19 Oct 2021 15:31:09 +0200 (CEST) Date: Tue, 19 Oct 2021 15:31:04 +0200 From: Stephan Gerhold To: Rob Herring Cc: "David S. Miller" , Jakub Kicinski , Loic Poulain , Sergey Ryazanov , Johannes Berg , Bjorn Andersson , Andy Gross , Vinod Koul , Aleksander Morgado , netdev , linux-arm-msm , "open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM" , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , phone-devel@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS , Hans de Goede , Andy Shevchenko ," <~postmarketos/upstreaming@lists.sr.ht>, Jeffrey Hugo Subject: Re: [PATCH net-next v2 3/4] dt-bindings: net: Add schema for Qualcomm BAM-DMUX Message-ID: References: <20211011141733.3999-1-stephan@gerhold.net> <20211011141733.3999-4-stephan@gerhold.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Oct 19, 2021 at 08:19:42AM -0500, Rob Herring wrote: > On Tue, Oct 19, 2021 at 2:03 AM Stephan Gerhold wrote: > > > > On Mon, Oct 18, 2021 at 03:22:25PM -0500, Rob Herring wrote: > > > On Mon, Oct 11, 2021 at 04:17:35PM +0200, Stephan Gerhold wrote: > > > > The BAM Data Multiplexer provides access to the network data channels of > > > > modems integrated into many older Qualcomm SoCs, e.g. Qualcomm MSM8916 or > > > > MSM8974. It is built using a simple protocol layer on top of a DMA engine > > > > (Qualcomm BAM) and bidirectional interrupts to coordinate power control. > > > > > > > > The device tree node combines the incoming interrupt with the outgoing > > > > interrupts (smem-states) as well as the two DMA channels, which allows > > > > the BAM-DMUX driver to request all necessary resources. > > > > > > > > Signed-off-by: Stephan Gerhold > > > > --- > > > > Changes since RFC: None. > > > > --- > > > > .../bindings/net/qcom,bam-dmux.yaml | 87 +++++++++++++++++++ > > > > 1 file changed, 87 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/net/qcom,bam-dmux.yaml > > > > > > > > diff --git a/Documentation/devicetree/bindings/net/qcom,bam-dmux.yaml b/Documentation/devicetree/bindings/net/qcom,bam-dmux.yaml > > > > new file mode 100644 > > > > index 000000000000..33e125e70cb4 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/net/qcom,bam-dmux.yaml > > > > @@ -0,0 +1,87 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/net/qcom,bam-dmux.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: Qualcomm BAM Data Multiplexer > > > > + > > > > +maintainers: > > > > + - Stephan Gerhold > > > > + > > > > +description: | > > > > + The BAM Data Multiplexer provides access to the network data channels > > > > + of modems integrated into many older Qualcomm SoCs, e.g. Qualcomm MSM8916 > > > > + or MSM8974. It is built using a simple protocol layer on top of a DMA engine > > > > + (Qualcomm BAM DMA) and bidirectional interrupts to coordinate power control. > > > > + > > > > +properties: > > > > + compatible: > > > > + const: qcom,bam-dmux > > > > > > Is this block the same on every SoC? It needs to be SoC specific. > > > > > > > Hm, I think describing it as *SoC*-specific wouldn't be accurate: > > This node does not describe any hardware block, it's more a "firmware > > convention". The only hardware involved is the BAM DMA engine, which > > already has SoC/IP-specific compatibles in its own device tree node. > > > > This means that if anything there should be "firmware version"-specific > > compatibles, because one SoC might have different (typically signed) > > firmware versions that provide slightly different functionality. > > However, I have to admit that I'm not familiar enough with the different > > firmware versions to come up with a reasonable naming schema for the > > compatible. :/ > > > > In general, I cannot think of any difference between different versions > > that would matter to a driver. The protocol is quite simple, and minor > > firmware differences can be better handled through the control channel > > that sets up the connection for the modem. > > > > Does that make sense? > > Okay. Please add some of the above details to the binding. > OK, I will try to clarify this a bit in v3. Thanks! Stephan