From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mfd: qcom-spmi-pmic: Document eight more PMICs to binding
Date: Tue, 12 Oct 2021 12:04:08 -0500 [thread overview]
Message-ID: <YWXACBenQ4xrBZvY@builder.lan> (raw)
In-Reply-To: <YWWfkyoV0rF4C4PP@google.com>
On Tue 12 Oct 09:46 CDT 2021, Lee Jones wrote:
> On Mon, 04 Oct 2021, Bjorn Andersson wrote:
>
> > Update the binding with eitght more SPMI PMIC compatibles found in the
>
> Spell check.
>
Bummer...
> > PMIC info list in the Qualcomm socinfo driver.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > ---
> > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
> > index 5ef79bf3d035..1d2b5f067556 100644
> > --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
> > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
> > @@ -29,6 +29,8 @@ Required properties:
> > "qcom,pm8916",
> > "qcom,pm8004",
> > "qcom,pm8909",
> > + "qcom,pm8028",
> > + "qcom,pm8901",
> > "qcom,pm8950",
> > "qcom,pmi8950",
> > "qcom,pm8998",
> > @@ -38,6 +40,12 @@ Required properties:
> > "qcom,pmk8350",
> > "qcom,pm7325",
> > "qcom,pmr735a",
> > + "qcom,pm8150",
> > + "qcom,pm8150l",
> > + "qcom,pm8150b",
> > + "qcom,pmk8002",
> > + "qcom,pm8150c",
> > + "qcom,smb2351",
> > or generalized "qcom,spmi-pmic".
> > - reg: Specifies the SPMI USID slave address for this device.
> > For more information see:
>
> Is there any reason why these can't be in lexicographical order?
>
Definitely not, both this list and the list compatible list in the
driver would be better of sorted. I just didn't want to sort and add the
entries in a single commit.
Do you want me to respin this, adding two patches that sort the
elements? Or will you fix my awesome spelling of 8 above and I send you
the patches that shuffles the entries?
Thanks,
Bjorn
> --
> Lee Jones [?????????]
> Senior Technical Lead - Developer Services
> Linaro.org ??? Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-10-12 17:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 2:48 [PATCH 1/2] mfd: qcom-spmi-pmic: Document eight more PMICs to binding Bjorn Andersson
2021-10-05 2:48 ` [PATCH 2/2] mfd: qcom-spmi-pmic: Add missing PMICs supported by socinfo Bjorn Andersson
2021-10-12 14:46 ` [PATCH 1/2] mfd: qcom-spmi-pmic: Document eight more PMICs to binding Lee Jones
2021-10-12 17:04 ` Bjorn Andersson [this message]
2021-10-12 18:33 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWXACBenQ4xrBZvY@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).