From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, sudeep.holla@arm.com,
will@kernel.org, catalin.marinas@arm.com, linux@armlinux.org.uk,
gregkh@linuxfoundation.org, rafael@kernel.org,
viresh.kumar@linaro.org, amitk@kernel.org,
daniel.lezcano@linaro.org, amit.kachhap@gmail.com,
thara.gopinath@linaro.org, agross@kernel.org
Subject: Re: [PATCH v2 1/5] arch_topology: Introduce thermal pressure update function
Date: Wed, 27 Oct 2021 11:43:21 -0700 [thread overview]
Message-ID: <YXmdyeOmNS2x3K0W@ripper> (raw)
In-Reply-To: <20211015144550.23719-2-lukasz.luba@arm.com>
On Fri 15 Oct 07:45 PDT 2021, Lukasz Luba wrote:
> diff --git a/arch/arm64/include/asm/topology.h b/arch/arm64/include/asm/topology.h
[..]
> +/**
> + * topology_thermal_pressure_update() - Update thermal pressure for CPUs
> + * @cpus : The related CPUs for which capacity has been reduced
> + * @capped_freq : The maximum allowed frequency that CPUs can run at
I know this matches what I see in e.g. the Qualcomm cpufreq hw driver,
but in what cases will @capped_freq differ from
cpufreq_get_hw_max_freq(cpumask_first(cpus))?
Regards,
Bjorn
> + *
> + * Update the value of thermal pressure for all @cpus in the mask. The
> + * cpumask should include all (online+offline) affected CPUs, to avoid
> + * operating on stale data when hot-plug is used for some CPUs. The
> + * @capped_freq must be less or equal to the max possible frequency and
> + * reflects the currently allowed max CPUs frequency due to thermal capping.
> + * The @capped_freq must be provided in kHz.
> + */
> +void topology_thermal_pressure_update(const struct cpumask *cpus,
> + unsigned long capped_freq)
> +{
> + unsigned long max_capacity, capacity;
> + int cpu;
> +
> + if (!cpus)
> + return;
> +
> + cpu = cpumask_first(cpus);
> + max_capacity = arch_scale_cpu_capacity(cpu);
> +
> + /* Convert to MHz scale which is used in 'freq_factor' */
> + capped_freq /= 1000;
> +
> + capacity = mult_frac(capped_freq, max_capacity,
> + per_cpu(freq_factor, cpu));
> +
> + arch_set_thermal_pressure(cpus, max_capacity - capacity);
> +}
> +EXPORT_SYMBOL_GPL(topology_thermal_pressure_update);
> +
> static ssize_t cpu_capacity_show(struct device *dev,
> struct device_attribute *attr,
> char *buf)
> @@ -220,7 +255,6 @@ static void update_topology_flags_workfn(struct work_struct *work)
> update_topology = 0;
> }
>
> -static DEFINE_PER_CPU(u32, freq_factor) = 1;
> static u32 *raw_capacity;
>
> static int free_raw_capacity(void)
next prev parent reply other threads:[~2021-10-27 18:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 14:45 [PATCH v2 0/5] Refactor thermal pressure update to avoid code duplication Lukasz Luba
2021-10-15 14:45 ` [PATCH v2 1/5] arch_topology: Introduce thermal pressure update function Lukasz Luba
2021-10-26 16:51 ` Dietmar Eggemann
2021-10-27 8:56 ` Lukasz Luba
2021-10-27 13:35 ` Dietmar Eggemann
2021-10-27 18:43 ` Bjorn Andersson [this message]
2021-10-28 7:16 ` Lukasz Luba
2021-10-28 23:12 ` Bjorn Andersson
2021-10-28 5:44 ` Viresh Kumar
2021-10-28 7:19 ` Lukasz Luba
2021-10-15 14:45 ` [PATCH v2 2/5] thermal: cpufreq_cooling: Use new " Lukasz Luba
2021-10-26 16:51 ` Dietmar Eggemann
2021-10-27 9:00 ` Lukasz Luba
2021-10-15 14:45 ` [PATCH v2 3/5] cpufreq: qcom-cpufreq-hw: Update offline CPUs per-cpu thermal pressure Lukasz Luba
2021-10-15 14:45 ` [PATCH v2 4/5] cpufreq: qcom-cpufreq-hw: Use new thermal pressure update function Lukasz Luba
2021-10-15 14:45 ` [PATCH v2 5/5] arch_topology: Remove unused topology_set_thermal_pressure() and related Lukasz Luba
2021-10-25 16:43 ` [PATCH v2 0/5] Refactor thermal pressure update to avoid code duplication Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXmdyeOmNS2x3K0W@ripper \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=amit.kachhap@gmail.com \
--cc=amitk@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=thara.gopinath@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).