From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CEE9C4332F for ; Mon, 15 Nov 2021 20:26:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E45D963238 for ; Mon, 15 Nov 2021 20:26:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233369AbhKOUZw (ORCPT ); Mon, 15 Nov 2021 15:25:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245134AbhKOTTc (ORCPT ); Mon, 15 Nov 2021 14:19:32 -0500 Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8996C0386CB for ; Mon, 15 Nov 2021 10:10:48 -0800 (PST) Received: by mail-ot1-x334.google.com with SMTP id a23-20020a9d4717000000b0056c15d6d0caso21765950otf.12 for ; Mon, 15 Nov 2021 10:10:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=btXP5JTOTPHN2wBCk/VjqAMkewryvyIZIdcv+nbDmjs=; b=KFeET7Jo1zA/GLeNPXLNhLjW4GX0S6rNhH8crHvhvla+DjueTpwSw5iF9onmZhMU9U L0TJbxv9B85FBo1rztKCQARvrlLxO1EPlOuS5DNmtX3uwAJezbb+oDBMZuylRANWbUfb WL4s4i4FGldWsdq8g8HvmZUDRFg7eJFE8JnQITAd2WSFuuYb6Oasun9CD2yHY7GfUr8C HTpFSjPJPCGefDJE8i+K/58Ccq0yEPlwFXXds4//i1UEl3XfUxlo/tHnVfLJyu8maid6 6hXMppAVCA2WE36IwlazSwxpQfgxWXam5ezKWFxLRXOUYdxJZM7HplXaFG8ZSytzUCXH /D+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=btXP5JTOTPHN2wBCk/VjqAMkewryvyIZIdcv+nbDmjs=; b=8C4kSY4qENdcw7C1AJZYQDH2Dp8FFBMz+mun2gEqrSHbAt0P303JgKpaV7U4bOYMzG //q4SwYMowbqgJKXZWKlmyq9iSvmjLK8T8JdRT5jvOCoWka4q9mK4l0DhJx5XXCT4w4N Pb9c8qJ3sVY0WRNm/cbkwZ82XAgSlYhTU/QvVpPU3qMCPJkAOCvLpXSONufIi31U43IN aV/hcSvDldS1SQRFgQ5n/ssOb495+uMbZLVdtXJqXYILYjTzQNVAUvmuEHhwiv+LuHtk w2B8c1EeGspGhs/DXVPj7tGEr5CsS5OsiVR8ot+06T2vEho5bj++j1fwsOaCd0j4tL6e dAHw== X-Gm-Message-State: AOAM532enUj3RP+t1D7DMpHhrqTVjJ/FKbjBGN5Djcqj6fdSJXGFyDFA tB9Bvf1V8LNC+2qMw+nTDTO/Yg== X-Google-Smtp-Source: ABdhPJwvZP5w9iunnbVacXS+t5Qx3X/+MhKg+S8e/AkaARLNqNF8AI5kwj0o3zSAz8HdWkU64r1Diw== X-Received: by 2002:a05:6830:3155:: with SMTP id c21mr764093ots.183.1636999848157; Mon, 15 Nov 2021 10:10:48 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id n23sm3309780oic.26.2021.11.15.10.10.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Nov 2021 10:10:47 -0800 (PST) Date: Mon, 15 Nov 2021 12:10:42 -0600 From: Bjorn Andersson To: Bhupesh Sharma Cc: linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, agross@kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, stephan@gerhold.net, Thara Gopinath Subject: Re: [PATCH v5 17/22] crypto: qce: Print a failure msg in case probe() fails Message-ID: References: <20211110105922.217895-1-bhupesh.sharma@linaro.org> <20211110105922.217895-18-bhupesh.sharma@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211110105922.217895-18-bhupesh.sharma@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed 10 Nov 04:59 CST 2021, Bhupesh Sharma wrote: > Print a failure message (dev_err) in case the qcom qce crypto > driver probe() fails. > > Cc: Bjorn Andersson > Cc: Rob Herring > Reviewed-by: Thara Gopinath > Signed-off-by: Bhupesh Sharma > --- > drivers/crypto/qce/core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c > index 98784d63d78c..7c90401a2ef1 100644 > --- a/drivers/crypto/qce/core.c > +++ b/drivers/crypto/qce/core.c > @@ -280,6 +280,7 @@ static int qce_crypto_probe(struct platform_device *pdev) > err_mem_path_disable: > icc_set_bw(qce->mem_path, 0, 0); > err: > + dev_err(dev, "%s failed : %d\n", __func__, ret); There's two possible outcomes of this style of error logging: 1) You came through a code path with a specific error message, so you will have something that will say: qce: Some useful error text qce: qce_crypto_probe failed: -22 2) You came through a code path without a specific error message: qce: qce_crypto_probe failed: -22 In the first case the second line is just pure spam, in the second case the bare -22 is typically completely useless - given that there tend to be just a few commonly used errno values coming from multiple possible error sources. As such, no thanks. If you have an error case in qce_crypto_probe() that doesn't have a good, useful, error message, please fix that. Regards, Bjorn > return ret; > } > > -- > 2.31.1 >