From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0902C433F5 for ; Wed, 17 Nov 2021 18:57:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B48AB61B93 for ; Wed, 17 Nov 2021 18:57:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236388AbhKQTAU (ORCPT ); Wed, 17 Nov 2021 14:00:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236462AbhKQTAP (ORCPT ); Wed, 17 Nov 2021 14:00:15 -0500 Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FBB7C061767 for ; Wed, 17 Nov 2021 10:57:16 -0800 (PST) Received: by mail-ot1-x334.google.com with SMTP id h12-20020a056830034c00b0055c8458126fso6503909ote.0 for ; Wed, 17 Nov 2021 10:57:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=J0Ee9uS/yNgK0Q38kRm9WiYIRO1wJYHsfH9qjA2K+7w=; b=kzHn6zBkFHRDLpiKcjHC6wdwdCAsiEWlU1A5ga8fIQG/NkKrfuEM8UZ3GubHSyljZi dlmvBmBNnQT9teK9HvVXlqZvz+6UVAeg1BFSrCcJUtplhufu5Op8acDCURafV1GBgdfU z1u1DnUZ8YuocgW5tefkx3WD5X6RKKxK4xOsVED+2Lzq87RbE6PuwJONo8w2o6CS+WxH Zlo2jgIXcZRhHnYTxS3GURFTCVj5NmhUGUAd3ZaCaDItviXTrhJSz34JvZj0aP2CYB4o sxtCxhNc/0Lnv3GnEHGqPMy42lbkh/09Dx+kOwc6UKyIoGh0FDOH8Le4th2dj5XVWYVf dZtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=J0Ee9uS/yNgK0Q38kRm9WiYIRO1wJYHsfH9qjA2K+7w=; b=gy1KoqZ57dybpd1OSu1z9NhCnY0SrrmWz14lSTWIRvaxMGeIPLg4jTAWPaW6bnI0QG lW2Mte6CsA+MHP/HI1kE4MU5v6DYeaVeaGfLLlfcuYzI8XAqj/HW4Bli8rw2eemBPLkw OnIhtX7/7d7QId0sDIOcPE+7VWALaEXolMOBEJI1m7jcRzhtt84SqfW63HWBmi9IxUvV /nwOIcqI/ud7XUKh2u6IjboXpmW9SSvs7SVTSvkEtZveywl8fnGdPA6pMUC/xVQgjkxU LKxhiuuVV/uc32pLx0xlHlTWQFt1x9vYtxLrudRoRjFw99FcaHZU9y7V1b6M/6Bxf42z 9XIQ== X-Gm-Message-State: AOAM5320+8JwsEHDIR4ysSDX9PMg6rM60HBX//6lqlpWzhpUED5Vtdsm IbtPruVNw4SE9kTadHYlJtnkOQ== X-Google-Smtp-Source: ABdhPJynSXjZcC1ekGOZbGSEKHkQCV4LlmAj0G8v/H9dQsgtSOa6o3k4RrWaDEeFL6ED7RfR1PFFkA== X-Received: by 2002:a9d:7dca:: with SMTP id k10mr15971598otn.274.1637175435285; Wed, 17 Nov 2021 10:57:15 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id a13sm150174oiy.9.2021.11.17.10.57.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Nov 2021 10:57:14 -0800 (PST) Date: Wed, 17 Nov 2021 12:57:12 -0600 From: Bjorn Andersson To: Sibi Sankar Cc: vkoul@kernel.org, agross@kernel.org, ohad@wizery.com, mathieu.poirier@linaro.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] remoteproc: qcom: pas: Add missing power-domain "mxc" for CDSP Message-ID: References: <1624559605-29847-1-git-send-email-sibis@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1624559605-29847-1-git-send-email-sibis@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu 24 Jun 13:33 CDT 2021, Sibi Sankar wrote: > Add missing power-domain "mxc" required by CDSP PAS remoteproc on SM8350 > SoC. > > Fixes: e8b4e9a21af7 ("remoteproc: qcom: pas: Add SM8350 PAS remoteprocs") > Signed-off-by: Sibi Sankar > Cc: stable@vger.kernel.org > --- > > The device tree and pas documentation lists mcx as a required pd for cdsp. > Looks like it was missed while adding the proxy pds in the pas driver. > Bjorn/Vinod you'll need to test this patch before picking it up. > At least on the HDK mxc seems to be optional given the current system state, but I don't see any regressions so let's land this before we put the system in a state where it would matter. Tested-by: Bjorn Andersson Regards, Bjorn > drivers/remoteproc/qcom_q6v5_pas.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c > index b921fc26cd04..ad20065dbdea 100644 > --- a/drivers/remoteproc/qcom_q6v5_pas.c > +++ b/drivers/remoteproc/qcom_q6v5_pas.c > @@ -661,6 +661,7 @@ static const struct adsp_data sm8350_cdsp_resource = { > }, > .proxy_pd_names = (char*[]){ > "cx", > + "mxc", > NULL > }, > .ssr_name = "cdsp", > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >