From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DAC1C43217 for ; Tue, 7 Dec 2021 18:22:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239597AbhLGSZv (ORCPT ); Tue, 7 Dec 2021 13:25:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240266AbhLGSZu (ORCPT ); Tue, 7 Dec 2021 13:25:50 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC135C0617A1 for ; Tue, 7 Dec 2021 10:22:19 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id o13so31234105wrs.12 for ; Tue, 07 Dec 2021 10:22:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=08Y7iJI/PLTRM2a75Lt/X18n1ghFVyrjUSIXA87jB1c=; b=NaDI0vUgbYnBOYtMUBltHLOUYkBXWIXJLzv1PJ7Qa9rHdOKP9n7wD2RgoiI26BUkdU CZEv7LjjD++6EkU7BPSrcm5S5wjFQxbu6pQpfZBClnaei3kVbRcKDTFCdpA2g/elj3oJ 9KfrkXcOBOAK/G7Zr0zvdI5whTEkEdr8KfEX0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=08Y7iJI/PLTRM2a75Lt/X18n1ghFVyrjUSIXA87jB1c=; b=YfBWxcl2Dke0v2gGduz5X9MF5qRmd/f1zy0/gj/RFJy9Gdk8Ebj6syomeHZrz1XH6L O+msqUjwTWd3ZWv+f3Q2puDKd7Cdiq06U641LS+rt5j4j1LS0ak807AtkE85xyr8MT9O JQ3C5ILRvjiH3g0xfdR2lr5uoUiJGwnbErthiZHdPCgm4vG19XO8xW/XBLanH2md10ce UTBPPqzJfiLjZ94uzrbw8ZBjjklQ1u+kw3ICF/Rbl4rrCBwJD66nrOXBOkoFOKjV/YyF mMn5E0JFEf5019kIDJxSn4d6m9lO/wAFvUlki7NjG+tiy8AKLpsKK0T8+Ou33+TIzT74 tAGw== X-Gm-Message-State: AOAM533kq94z6FhUgrPaSakXevIX03NO9mFLsOTz/cEdZf5UTk1b6s4U 5D+doMPHw5ADnAK/W283X9oqlA== X-Google-Smtp-Source: ABdhPJxK2mhzgF3YMS/fG40gJ9DDy/bEcttiC7rT6MkCLhX411tsNH3w2Tru9t1nhhNXbQLQaKdz8Q== X-Received: by 2002:adf:d1e2:: with SMTP id g2mr54445987wrd.362.1638901338335; Tue, 07 Dec 2021 10:22:18 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id w4sm421952wrs.88.2021.12.07.10.22.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Dec 2021 10:22:17 -0800 (PST) Date: Tue, 7 Dec 2021 19:22:15 +0100 From: Daniel Vetter To: Stephen Boyd Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Arnd Bergmann , Benjamin Gaignard , Chen Feng , Chen-Yu Tsai , Christian Gmeiner , Chun-Kuang Hu , Daniel Vetter , Emma Anholt , Heiko =?iso-8859-1?Q?St=FCbner?= , Inki Dae , James Qian Wang , Jaroslav Kysela , Joerg Roedel , John Stultz , Joonyoung Shim , Jyri Sarha , Kai Vehmanen , Kyungmin Park , Laurent Pinchart , linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org, linux-pm@vger.kernel.org, Linus Walleij , Liviu Dudau , Lucas Stach , Mark Brown , Maxime Ripard , Neil Armstrong , Paul Cercueil , Philipp Zabel , "Rafael J. Wysocki" , Rob Clark , Russell King , Russell King , Russell King , Sandy Huang , Saravana Kannan , Sebastian Reichel , Seung-Woo Kim , Takashi Iwai , Tian Tao , Tomas Winkler , Tomi Valkeinen , Will Deacon , Xinliang Liu , Xinwei Kong , Yong Wu , Vitaly Lubart , Daniele Ceraolo Spurio , Rodrigo Vivi Subject: Re: [PATCH v4 00/34] component: Make into an aggregate bus Message-ID: Mail-Followup-To: Stephen Boyd , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Arnd Bergmann , Benjamin Gaignard , Chen Feng , Chen-Yu Tsai , Christian Gmeiner , Chun-Kuang Hu , Emma Anholt , Heiko =?iso-8859-1?Q?St=FCbner?= , Inki Dae , James Qian Wang , Jaroslav Kysela , Joerg Roedel , John Stultz , Joonyoung Shim , Jyri Sarha , Kai Vehmanen , Kyungmin Park , Laurent Pinchart , linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org, linux-pm@vger.kernel.org, Linus Walleij , Liviu Dudau , Lucas Stach , Mark Brown , Maxime Ripard , Neil Armstrong , Paul Cercueil , Philipp Zabel , "Rafael J. Wysocki" , Rob Clark , Russell King , Russell King , Russell King , Sandy Huang , Saravana Kannan , Sebastian Reichel , Seung-Woo Kim , Takashi Iwai , Tian Tao , Tomas Winkler , Tomi Valkeinen , Will Deacon , Xinliang Liu , Xinwei Kong , Yong Wu , Vitaly Lubart , Daniele Ceraolo Spurio , Rodrigo Vivi References: <20211202222732.2453851-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211202222732.2453851-1-swboyd@chromium.org> X-Operating-System: Linux phenom 5.10.0-8-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Dec 02, 2021 at 02:26:58PM -0800, Stephen Boyd wrote: > This series is from discussion we had on reordering the device lists for > drm shutdown paths[1]. I've introduced an 'aggregate' bus that we put > the aggregate device onto and then we probe the aggregate device once > all the components are probed and call component_add(). The probe/remove > hooks are where the bind/unbind calls go, and then a shutdown hook is > added that can be used to shutdown the drm display pipeline at the right > time. > > This works for me on my sc7180 board. I no longer get a warning from i2c > at shutdown that we're trying to make an i2c transaction after the i2c > bus has been shutdown. There's more work to do on the msm drm driver to > extract component device resources like clks, regulators, etc. out of > the component bind function into the driver probe but I wanted to move > everything over now in other component drivers before tackling that > problem. > > Tested-by tags would be appreciated, and Acked-by/Reviewed-by tags too. Thanks for pushing this forward. Unfortunately I'm completely burried and it's just not improving, so merge plan: - please get Greg KH to ack the bus/driver core stuff - please get one of the drm-misc committers we have from Google's Chromeos team (there should be a few by now) to review&push this. Otherwise I fear this might get stuck and I'd really like to avoid that. Cheers, Daniel > > Changes since v3 (https://lore.kernel.org/r/20211026000044.885195-1-swboyd@chromium.org): > - Picked up tags > - Rebased to v5.16-rc2 > - Updated component.c for a few new patches there > - Dropped a conversion patch > - Added a conversion patch > > Changes since v2 (https://lore.kernel.org/r/20211006193819.2654854-1-swboyd@chromium.org): > - Picked up acks > - Fixed build warnings/errors > - Reworked patch series to rename 'master' in a different patch > > Changes since v1 (https://lore.kernel.org/r/20210520002519.3538432-1-swboyd@chromium.org): > - Use devlink to connect components to the aggregate device > - Don't set the registering device as a parent of the aggregate device > - New patch for bind_component/unbind_component ops that takes the > aggregate device > - Convert all drivers in the tree to use the aggregate driver approach > - Allow one aggregate driver to be used for multiple aggregate devices > > [1] https://lore.kernel.org/r/20210508074118.1621729-1-swboyd@chromium.org > > > Stephen Boyd (34): > component: Introduce struct aggregate_device > component: Remove most references to 'master' > component: Introduce the aggregate bus_type > component: Move struct aggregate_device out to header file > component: Add {bind,unbind}_component() ops that take aggregate > device > drm/of: Add a drm_of_aggregate_probe() API > drm/msm: Migrate to aggregate driver > drm/komeda: Migrate to aggregate driver > drm/arm/hdlcd: Migrate to aggregate driver > drm/malidp: Migrate to aggregate driver > drm/armada: Migrate to aggregate driver > drm/etnaviv: Migrate to aggregate driver > drm/kirin: Migrate to aggregate driver > drm/exynos: Migrate to aggregate driver > drm/imx: Migrate to aggregate driver > drm/ingenic: Migrate to aggregate driver > drm/mcde: Migrate to aggregate driver > drm/mediatek: Migrate to aggregate driver > drm/meson: Migrate to aggregate driver > drm/omap: Migrate to aggregate driver > drm/rockchip: Migrate to aggregate driver > drm/sti: Migrate to aggregate driver > drm/sun4i: Migrate to aggregate driver > drm/tilcdc: Migrate to aggregate driver > drm/vc4: Migrate to aggregate driver > iommu/mtk: Migrate to aggregate driver > mei: Migrate to aggregate driver > power: supply: ab8500: Migrate to aggregate driver > fbdev: omap2: Migrate to aggregate driver > sound: hdac: Migrate to aggregate driver > ASoC: codecs: wcd938x: Migrate to aggregate driver > mei: pxp: Migrate to aggregate driver > component: Get rid of drm_of_component_probe() > component: Remove component_master_ops and friends > > drivers/base/component.c | 544 ++++++++++-------- > .../gpu/drm/arm/display/komeda/komeda_drv.c | 20 +- > drivers/gpu/drm/arm/hdlcd_drv.c | 21 +- > drivers/gpu/drm/arm/malidp_drv.c | 21 +- > drivers/gpu/drm/armada/armada_drv.c | 23 +- > drivers/gpu/drm/drm_drv.c | 2 +- > drivers/gpu/drm/drm_of.c | 18 +- > drivers/gpu/drm/etnaviv/etnaviv_drv.c | 20 +- > drivers/gpu/drm/exynos/exynos_drm_drv.c | 21 +- > .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 20 +- > drivers/gpu/drm/imx/imx-drm-core.c | 20 +- > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 25 +- > drivers/gpu/drm/mcde/mcde_drv.c | 23 +- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 20 +- > drivers/gpu/drm/meson/meson_drv.c | 21 +- > drivers/gpu/drm/msm/msm_drv.c | 46 +- > drivers/gpu/drm/omapdrm/dss/dss.c | 20 +- > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 20 +- > drivers/gpu/drm/sti/sti_drv.c | 20 +- > drivers/gpu/drm/sun4i/sun4i_drv.c | 26 +- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 28 +- > drivers/gpu/drm/vc4/vc4_drv.c | 20 +- > drivers/iommu/mtk_iommu.c | 14 +- > drivers/iommu/mtk_iommu.h | 6 +- > drivers/iommu/mtk_iommu_v1.c | 14 +- > drivers/misc/mei/hdcp/mei_hdcp.c | 22 +- > drivers/misc/mei/pxp/mei_pxp.c | 22 +- > drivers/power/supply/ab8500_charger.c | 22 +- > drivers/video/fbdev/omap2/omapfb/dss/dss.c | 20 +- > include/drm/drm_of.h | 10 +- > include/linux/component.h | 92 ++- > sound/hda/hdac_component.c | 21 +- > sound/soc/codecs/wcd938x.c | 20 +- > 33 files changed, 772 insertions(+), 490 deletions(-) > > Cc: Arnd Bergmann > Cc: Benjamin Gaignard > Cc: Chen Feng > Cc: Chen-Yu Tsai > Cc: Christian Gmeiner > Cc: Chun-Kuang Hu > Cc: Daniel Vetter > Cc: Emma Anholt > Cc: Greg Kroah-Hartman > Cc: "Heiko Stübner" > Cc: Inki Dae > Cc: James Qian Wang (Arm Technology China) > Cc: Jaroslav Kysela > Cc: Joerg Roedel > Cc: John Stultz > Cc: Joonyoung Shim > Cc: Jyri Sarha > Cc: Kai Vehmanen > Cc: Kyungmin Park > Cc: Laurent Pinchart > Cc: > Cc: > Cc: > Cc: Linus Walleij > Cc: Liviu Dudau > Cc: Lucas Stach > Cc: Mark Brown > Cc: Maxime Ripard > Cc: Neil Armstrong > Cc: Paul Cercueil > Cc: Philipp Zabel > Cc: "Rafael J. Wysocki" > Cc: Rob Clark > Cc: Russell King > Cc: Russell King > Cc: Russell King > Cc: Sandy Huang > Cc: Saravana Kannan > Cc: Sebastian Reichel > Cc: Seung-Woo Kim > Cc: Takashi Iwai > Cc: Tian Tao > Cc: Tomas Winkler > Cc: Tomi Valkeinen > Cc: Will Deacon > Cc: Xinliang Liu > Cc: Xinwei Kong > Cc: Yong Wu > Cc: Vitaly Lubart > Cc: Daniele Ceraolo Spurio > Cc: Rodrigo Vivi > Cc: Kai Vehmanen > > base-commit: 136057256686de39cc3a07c2e39ef6bc43003ff6 > -- > https://chromeos.dev > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch