linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: Vinod Koul <vkoul@kernel.org>,
	linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/15] arm64: dts: qcom: sm8450-qrd: include pmic files
Date: Tue, 7 Dec 2021 07:05:05 -0800	[thread overview]
Message-ID: <Ya94IRoUg4ArHjSO@ripper> (raw)
In-Reply-To: <eb2373bc-f9f5-d97a-13ec-d3d580566101@somainline.org>

On Wed 01 Dec 07:23 PST 2021, Konrad Dybcio wrote:

> 
> On 01.12.2021 08:29, Vinod Koul wrote:
> > SM8450 QRD platform has bunch of PMICs, include the common ones PM8350,
> > PM8350b and PMR735b
> >
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
> >  arch/arm64/boot/dts/qcom/sm8450-qrd.dts | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
> > index 3e65d662ab8c..48228888f500 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
> > +++ b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
> > @@ -8,6 +8,9 @@
> >  #include <dt-bindings/gpio/gpio.h>
> >  #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> >  #include "sm8450.dtsi"
> > +#include "pm8350.dtsi"
> > +#include "pm8350b.dtsi"
> > +#include "pmr735b.dtsi"
> >  
> >  / {
> >  	model = "Qualcomm Technologies, Inc. SM8450 QRD";
> >
> Again, this could have gone into a single "add board DTS" patch, but this
> 
> works too, I guess..
> 

I like that suggestion, putting the qrd.dts as a single patch at the end
of the series would look nice.

Regards,
Bjorn

> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> 
> 
> Konrad
> 

  reply	other threads:[~2021-12-07 15:03 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-01  7:29 [PATCH 00/15] arm64: dts: qcom: Add support for SM8450 SoC and QRD board Vinod Koul
2021-12-01  7:29 ` [PATCH 01/15] arm64: dts: qcom: Add base SM8450 DTSI Vinod Koul
2021-12-01 15:03   ` Konrad Dybcio
2021-12-06  5:39     ` Vinod Koul
2021-12-07 14:35       ` Bjorn Andersson
2021-12-07 14:53   ` Bjorn Andersson
2021-12-01  7:29 ` [PATCH 02/15] arm64: dts: qcom: Add base SM8450 QRD DTS Vinod Koul
2021-12-01 15:05   ` Konrad Dybcio
2021-12-01  7:29 ` [PATCH 03/15] arm64: dts: qcom: sm8450: Add tlmm nodes Vinod Koul
2021-12-07 14:37   ` Bjorn Andersson
2021-12-01  7:29 ` [PATCH 04/15] arm64: dts: qcom: sm8450-qrd: Add reserved gpio range for QRD Vinod Koul
2021-12-01 15:07   ` Konrad Dybcio
2021-12-06  5:53     ` Vinod Koul
2021-12-07 14:56       ` Bjorn Andersson
2021-12-01  7:29 ` [PATCH 05/15] arm64: dts: qcom: sm8450: Add reserved memory nodes Vinod Koul
2021-12-01 15:11   ` Konrad Dybcio
2021-12-06  5:42     ` Vinod Koul
2021-12-01  7:29 ` [PATCH 06/15] arm64: dts: qcom: sm8450: add smmu nodes Vinod Koul
2021-12-01 15:13   ` Konrad Dybcio
2021-12-01  7:29 ` [PATCH 07/15] arm64: dts: qcom: sm8450-qrd: Add rpmh regulator nodes Vinod Koul
2021-12-01 15:14   ` Konrad Dybcio
2021-12-01  7:29 ` [PATCH 08/15] arm64: dts: qcom: sm8450: add ufs nodes Vinod Koul
2021-12-01 15:16   ` Konrad Dybcio
2021-12-01  7:29 ` [PATCH 09/15] arm64: dts: qcom: sm8450-qrd: enable " Vinod Koul
2021-12-01 15:18   ` Konrad Dybcio
2021-12-06  5:58     ` Vinod Koul
2021-12-07 15:01       ` Bjorn Andersson
2021-12-01  7:29 ` [PATCH 10/15] arm64: dts: qcom: sm8450: add interconnect nodes Vinod Koul
2021-12-01 15:20   ` Konrad Dybcio
2021-12-06  6:12     ` Vinod Koul
2021-12-01  7:29 ` [PATCH 11/15] arm64: dts: qcom: sm8450: add spmi node Vinod Koul
2021-12-01 15:22   ` Konrad Dybcio
2021-12-01  7:29 ` [PATCH 12/15] arm64: dts: qcom: sm8450-qrd: include pmic files Vinod Koul
2021-12-01 15:23   ` Konrad Dybcio
2021-12-07 15:05     ` Bjorn Andersson [this message]
2021-12-07 15:51       ` Vinod Koul
2021-12-01  7:29 ` [PATCH 13/15] arm64: dts: qcom: sm8450: Add rpmhpd node Vinod Koul
2021-12-01 15:24   ` Konrad Dybcio
2021-12-01  7:29 ` [PATCH 14/15] arm64: dts: qcom: sm8450: add cpufreq support Vinod Koul
2021-12-01 15:28   ` Konrad Dybcio
2021-12-09  7:11     ` Vinod Koul
2021-12-01  7:29 ` [PATCH 15/15] arm64: dts: qcom: sm8450: add i2c13 and i2c14 device nodes Vinod Koul
2021-12-01 15:30   ` Konrad Dybcio
2021-12-09  7:13     ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ya94IRoUg4ArHjSO@ripper \
    --to=bjorn.andersson@linaro.org \
    --cc=agross@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).