From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEA08C7EE24 for ; Wed, 31 May 2023 07:28:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234381AbjEaH2i (ORCPT ); Wed, 31 May 2023 03:28:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234123AbjEaH2h (ORCPT ); Wed, 31 May 2023 03:28:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 187DB123; Wed, 31 May 2023 00:28:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9DE076376B; Wed, 31 May 2023 07:28:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05087C433A0; Wed, 31 May 2023 07:28:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685518113; bh=UE35bN0SYktAgtulGtfRw0ZGksuMveOylG6L1tzctnk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SGEvusDHV50xFpcIlZ1fNz5joNg7Q2NhNz97qTLqpKYfqfj3PcrVzptKrQlT5mzUy hxhCZUr8tkDTTox8iy4inhitrzU1oQ4JxFYmNlE40tcdNa8vYIxeKAubbBc4CZHAj+ cNcmoljlW3a7V7NvHkWdh+xMcjkG/mUXhKckg/z8KjNyEkH4o2p7HvNNGiIO4RB1j1 Yoki+MSxlYabo0hDhzuE0Zgj/qvqcAUwFYEemMOd63otKh4AcYsQcFhqTM2xAr0BYu D8mcbQErrxFK0EcNby/YjZvor33EHAiBFB+Fp48pygeQyRMbkmbCLQY6WrmnVNbbSc j/yIUKtBDaGtg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1q4GG3-0006k2-F1; Wed, 31 May 2023 09:28:36 +0200 Date: Wed, 31 May 2023 09:28:35 +0200 From: Johan Hovold To: Bjorn Andersson Cc: Bjorn Andersson , Konrad Dybcio , Rob Clark , Dmitry Baryshkov , Sean Paul , Akhil P Oommen , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, mani@kernel.org, Steev Klimaszewski Subject: Re: [PATCH v3 2/3] arm64: dts: qcom: sc8280xp: Add GPU related nodes Message-ID: References: <20230531030945.4109453-1-quic_bjorande@quicinc.com> <20230531030945.4109453-3-quic_bjorande@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230531030945.4109453-3-quic_bjorande@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, May 30, 2023 at 08:09:44PM -0700, Bjorn Andersson wrote: > From: Bjorn Andersson > > Add Adreno SMMU, GPU clock controller, GMU and GPU nodes for the > SC8280XP. > > Tested-by: Steev Klimaszewski > Signed-off-by: Bjorn Andersson > Signed-off-by: Bjorn Andersson > --- > > Changes since v2: > - Added missing opp level (both gpu and gmu) > - Corrected opp-level for highest gpu opp > - Added dma-coherent to gpu smmu > > Note that in order for the GPU driver to probe, the last change > requires: > https://lore.kernel.org/linux-arm-msm/20230410185226.3240336-1-dmitry.baryshkov@linaro.org/ That's a pretty well-hidden notice about a critical dependency. I just spent the morning debugging why this series broke the probe of the GPU and only saw this when I was going to report my findings. Please consider putting information like this in the cover letter in the future. > Changes since v1: > - Dropped gmu_pdc_seq region from &gmu, as it shouldn't have been used. > - Added missing compatible to &adreno_smmu. > - Dropped aoss_qmp clock in &gmu and &adreno_smmu. Changelogs are also preferably placed in the cover letter so that you don't have to read through N patches to determine what changed from one revision of a series to the next. Johan