From: Vinod Koul <vkoul@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
linux-arm-msm@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Georgi Djakov <djakov@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 03/15] dt-bindings: interconnect: split SC8180x to own schema
Date: Thu, 1 Jun 2023 12:53:50 +0530 [thread overview]
Message-ID: <ZHhHhk/4BX53R1p/@matsya> (raw)
In-Reply-To: <25e3ed2f-d691-1a80-e2ba-6c7413b7261a@linaro.org>
On 31-05-23, 10:22, Krzysztof Kozlowski wrote:
> On 30/05/2023 18:24, Vinod Koul wrote:
> > SC8180x comes with interconnects with missing IO address space and
> > variable number of clocks, so split it from common file for easier
> > maintenance and to fix warnings like:
> >
> > sc8180x-lenovo-flex-5g.dtb: interconnect-0: 'reg' is a required property
> >
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
> > .../bindings/interconnect/qcom,rpmh.yaml | 11 -----
> > .../interconnect/qcom,sc8180x-rpmh.yaml | 49 +++++++++++++++++++
> > 2 files changed, 49 insertions(+), 11 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sc8180x-rpmh.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
> > index 4d93ad415e0b..5cbc3be49e99 100644
> > --- a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
> > +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
> > @@ -39,17 +39,6 @@ properties:
> > - qcom,sc7180-npu-noc
> > - qcom,sc7180-qup-virt
> > - qcom,sc7180-system-noc
> > - - qcom,sc8180x-aggre1-noc
> > - - qcom,sc8180x-aggre2-noc
> > - - qcom,sc8180x-camnoc-virt
> > - - qcom,sc8180x-compute-noc
> > - - qcom,sc8180x-config-noc
> > - - qcom,sc8180x-dc-noc
> > - - qcom,sc8180x-gem-noc
> > - - qcom,sc8180x-mc-virt
> > - - qcom,sc8180x-mmss-noc
> > - - qcom,sc8180x-qup-virt
> > - - qcom,sc8180x-system-noc
> > - qcom,sdm670-aggre1-noc
> > - qcom,sdm670-aggre2-noc
> > - qcom,sdm670-config-noc
> > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sc8180x-rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sc8180x-rpmh.yaml
> > new file mode 100644
> > index 000000000000..b182c2c5addc
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/interconnect/qcom,sc8180x-rpmh.yaml
> > @@ -0,0 +1,49 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/interconnect/qcom,sc8180x-rpmh.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm RPMh Network-On-Chip Interconnect on SC8180X
> > +
> > +maintainers:
> > + - Bjorn Andersson <andersson@kernel.org>
> > + - Konrad Dybcio <konrad.dybcio@linaro.org>
> > +
> > +description: |
> > + RPMh interconnect providers support system bandwidth requirements through
> > + RPMh hardware accelerators known as Bus Clock Manager (BCM).
> > +
> > + See also:: include/dt-bindings/interconnect/qcom,sc8180x.h
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - qcom,sc8180x-aggre1-noc
> > + - qcom,sc8180x-aggre2-noc
> > + - qcom,sc8180x-camnoc-virt
> > + - qcom,sc8180x-compute-noc
> > + - qcom,sc8180x-config-noc
> > + - qcom,sc8180x-dc-noc
> > + - qcom,sc8180x-gem-noc
> > + - qcom,sc8180x-ipa-virt
> > + - qcom,sc8180x-mc-virt
> > + - qcom,sc8180x-mmss-noc
> > + - qcom,sc8180x-qup-virt
> > + - qcom,sc8180x-system-noc
> > +
> > +required:
> > + - compatible
> > +
> > +allOf:
> > + - $ref: qcom,rpmh-common.yaml#
>
> This should be based on sc7280. You need reg for some of the entries.
Yes missed reg part here.
Question is should it be added sc7280 or have a different file, I think
doing former is better
>
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > + - |
> > + interconnect-0 {
>
> Just "interconnect"
Nope. We have multiple virtual nodes here so interconnect-N would
need to be done
--
~Vinod
next prev parent reply other threads:[~2023-06-01 7:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 16:24 [PATCH v3 00/15] Introduce the SC8180x devices Vinod Koul
2023-05-30 16:24 ` [PATCH v3 01/15] dt-bindings: PCI: qcom: Fix sc8180x clocks and interrupts Vinod Koul
2023-05-31 8:19 ` Krzysztof Kozlowski
2023-06-01 7:21 ` Vinod Koul
2023-06-01 7:25 ` Krzysztof Kozlowski
2023-06-01 7:26 ` Krzysztof Kozlowski
2023-05-30 16:24 ` [PATCH v3 02/15] dt-bindings: usb: qcom,dwc3: Add SC8180x binding Vinod Koul
2023-05-31 8:19 ` Krzysztof Kozlowski
2023-05-30 16:24 ` [PATCH v3 03/15] dt-bindings: interconnect: split SC8180x to own schema Vinod Koul
2023-05-31 8:22 ` Krzysztof Kozlowski
2023-06-01 7:23 ` Vinod Koul [this message]
2023-06-01 7:26 ` Krzysztof Kozlowski
2023-05-30 16:24 ` [PATCH v3 04/15] scsi: ufs: dt-bindings: Add SC8180x binding Vinod Koul
2023-05-31 8:24 ` Krzysztof Kozlowski
2023-05-30 16:24 ` [PATCH v3 05/15] dt-bindings: qcom,pdc: Add SC8180x compatible Vinod Koul
2023-05-31 8:24 ` Krzysztof Kozlowski
2023-05-30 16:24 ` [PATCH v3 06/15] arm64: dts: qcom: Introduce the SC8180x platform Vinod Koul
2023-05-30 16:24 ` [PATCH v3 07/15] arm64: dts: qcom: sc8180x: Add interconnects and lmh Vinod Koul
2023-05-31 8:26 ` Krzysztof Kozlowski
2023-06-01 7:17 ` Vinod Koul
2023-06-01 13:27 ` Bjorn Andersson
2023-06-01 15:27 ` Krzysztof Kozlowski
2023-06-10 16:24 ` Bjorn Andersson
2023-05-30 16:24 ` [PATCH v3 08/15] arm64: dts: qcom: sc8180x: Add thermal zones Vinod Koul
2023-05-30 16:24 ` [PATCH v3 09/15] arm64: dts: qcom: sc8180x: Add QUPs Vinod Koul
2023-05-30 16:24 ` [PATCH v3 10/15] arm64: dts: qcom: sc8180x: Add PCIe instances Vinod Koul
2023-05-30 16:24 ` [PATCH v3 11/15] arm64: dts: qcom: sc8180x: Add remoteprocs, wifi and usb nodes Vinod Koul
2023-05-30 16:24 ` [PATCH v3 12/15] arm64: dts: qcom: sc8180x: Add display and gpu nodes Vinod Koul
2023-05-30 16:24 ` [PATCH v3 13/15] arm64: dts: qcom: sc8180x: Add pmics Vinod Koul
2023-06-07 19:31 ` Rob Herring
2023-05-30 16:24 ` [PATCH v3 14/15] arm64: dts: qcom: sc8180x: Introduce Primus Vinod Koul
2023-05-30 16:24 ` [PATCH v3 15/15] arm64: dts: qcom: sc8180x: Introduce Lenovo Flex 5G Vinod Koul
2023-05-30 17:22 ` (subset) [PATCH v3 00/15] Introduce the SC8180x devices Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHhHhk/4BX53R1p/@matsya \
--to=vkoul@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).