From: Abel Vesa <abel.vesa@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] arm64: dts: qcom: sm8250: Add missing interconnect paths to USB HCs
Date: Fri, 2 Jun 2023 08:43:05 +0300 [thread overview]
Message-ID: <ZHmBaVFF7Vys9dev@linaro.org> (raw)
In-Reply-To: <eb7b8485-6c6c-da4d-cf90-334139b21ce6@linaro.org>
On 23-06-01 14:22:35, Konrad Dybcio wrote:
>
>
> On 1.06.2023 14:00, Abel Vesa wrote:
> > The USB HCs nodes are missing the interconnect paths, so add them.
> >
> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > ---
> > arch/arm64/boot/dts/qcom/sm8250.dtsi | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> > index e5c60a6e4074..eefd3dcbb2e1 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> > @@ -3750,6 +3750,10 @@ usb_1: usb@a6f8800 {
> >
> > resets = <&gcc GCC_USB30_PRIM_BCR>;
> >
> > + interconnects = <&aggre1_noc MASTER_USB3 0 &mc_virt SLAVE_EBI_CH0 0>,
> > + <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_USB3 0>;
> You need to update #interconnect-cells to 2.
Ugh, missed that. Will send a new version.
Thanks,
Abel
>
> Konrad
> > + interconnect-names = "usb-ddr", "apps-usb";
> > +
> > usb_1_dwc3: usb@a600000 {
> > compatible = "snps,dwc3";
> > reg = <0 0x0a600000 0 0xcd00>;
> > @@ -3810,6 +3814,10 @@ usb_2: usb@a8f8800 {
> >
> > resets = <&gcc GCC_USB30_SEC_BCR>;
> >
> > + interconnects = <&aggre1_noc MASTER_USB3_1 0 &mc_virt SLAVE_EBI_CH0 0>,
> > + <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_USB3_1 0>;
> > + interconnect-names = "usb-ddr", "apps-usb";
> > +
> > usb_2_dwc3: usb@a800000 {
> > compatible = "snps,dwc3";
> > reg = <0 0x0a800000 0 0xcd00>;
next prev parent reply other threads:[~2023-06-02 5:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 12:00 [PATCH 1/4] arm64: dts: qcom: sm8150: Add missing interconnect paths to USB HCs Abel Vesa
2023-06-01 12:00 ` [PATCH 2/4] arm64: dts: qcom: sm8250: " Abel Vesa
2023-06-01 12:22 ` Konrad Dybcio
2023-06-02 5:43 ` Abel Vesa [this message]
2023-06-01 12:00 ` [PATCH 3/4] arm64: dts: qcom: sm8350: " Abel Vesa
2023-06-01 12:23 ` Konrad Dybcio
2023-06-01 12:00 ` [PATCH 4/4] arm64: dts: qcom: sm8450: Add missing interconnect paths to USB HC Abel Vesa
2023-06-01 12:23 ` Konrad Dybcio
2023-06-01 12:22 ` [PATCH 1/4] arm64: dts: qcom: sm8150: Add missing interconnect paths to USB HCs Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHmBaVFF7Vys9dev@linaro.org \
--to=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).