From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22361C388F9 for ; Mon, 16 Nov 2020 23:49:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B96ED24641 for ; Mon, 16 Nov 2020 23:49:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=connolly.tech header.i=@connolly.tech header.b="DdL1gEWN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726487AbgKPXti (ORCPT ); Mon, 16 Nov 2020 18:49:38 -0500 Received: from mail1.protonmail.ch ([185.70.40.18]:37271 "EHLO mail1.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726287AbgKPXti (ORCPT ); Mon, 16 Nov 2020 18:49:38 -0500 Date: Mon, 16 Nov 2020 23:49:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=connolly.tech; s=protonmail; t=1605570576; bh=CJNL1D7Vyb/1gRN55OqVYcG4Y4k6wH1TamA2FlX7qmA=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=DdL1gEWN0Zi5e+tBQtIO9kJyjCo14VqPl+yb8SAsX9qn0W6Th/WAq2fgt98LlZDgs UyeZuNVpsQ/EHUvEWZiXTkHo2GrI9sILYdKvvHgP9Dks5zbaJXccctp0E9txr1T4vf g6ZVYtqkg8DM5ZFKjEgIAZxJ0bEUcHWkNgdrV/yI= To: Pavel Machek From: Caleb Connolly Cc: linux-arm-msm@vger.kernel.org, Andy Gross , Bjorn Andersson , Rob Herring , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Reply-To: Caleb Connolly Subject: Re: [PATCH 3/5] arm64: dts: sdm845: add oneplus 6/t devices Message-ID: In-Reply-To: <20201116220153.GA1003@bug> References: <20201112161920.2671430-1-caleb@connolly.tech> <20201112161920.2671430-4-caleb@connolly.tech> <20201116220153.GA1003@bug> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2020-11-16 22:01, Pavel Machek wrote: > Hi! > >> Add initial support for the OnePlus 6 (enchilada) and 6T (fajita) based >> on the sdm845-mtp DT. Support includes: >> >> * Display panels and Adreno 630 >> * Touch screen support with synaptics rmi4 >> * All remoteprocs start correctly >> * WLAN / Bluetooth >> * Volume / power buttons and OnePlus Tri-State switch are functional >> The tri-state switch is a 3 state mute slider on the side of the ph= one * USB >> support, currently forced to peripheral as type C detection isn't functi= onal. > I have similar switches on my joystick... but I don't believe modelling i= t as 3 separate > keys with "macro" keysym is the right way to go. Hi! I agree that this is a bit of a weird way to model the switch, do=20 you have any ideas for a better solution? I'm happy to drop this from the patch for now and come up with a better=20 method down the line. Regards, Caleb >> +=09=09state-top { >> +=09=09=09label =3D "Tri-state key top"; >> +=09=09=09linux,code =3D ; >> +=09=09=09interrupt-parent =3D <&tlmm>; >> +=09=09=09interrupts =3D <24 IRQ_TYPE_EDGE_FALLING>; >> +=09=09=09debounce-interval =3D <500>; >> +=09=09=09linux,can-disable; >> +=09=09}; >> + >> +=09=09state-middle { >> +=09=09=09label =3D "Tri-state key middle"; >> +=09=09=09linux,code =3D ; >> +=09=09=09interrupt-parent =3D <&tlmm>; >> +=09=09=09interrupts =3D <52 IRQ_TYPE_EDGE_FALLING>; >> +=09=09=09debounce-interval =3D <500>; >> +=09=09=09linux,can-disable; >> +=09=09}; >> + >> +=09=09state-bottom { >> +=09=09=09label =3D "Tri-state key bottom"; >> +=09=09=09linux,code =3D ; >> +=09=09=09interrupt-parent =3D <&tlmm>; >> +=09=09=09interrupts =3D <126 IRQ_TYPE_EDGE_FALLING>; >> +=09=09=09debounce-interval =3D <500>; >> +=09=09=09linux,can-disable; >> +=09=09}; > Best regards, > =09=09=09=09=09=09=09=09=09Pavel > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/b= log.html